From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Frankie Chang <Frankie.Chang@mediatek.com>
Cc: "Todd Kjos" <tkjos@android.com>,
wsd_upstream <wsd_upstream@mediatek.com>,
LKML <linux-kernel@vger.kernel.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Jian-Min Liu" <Jian-Min.Liu@mediatek.com>,
linux-mediatek@lists.infradead.org,
"Joel Fernandes" <joel@joelfernandes.org>,
"Martijn Coenen" <maco@android.com>,
"Christian Brauner" <christian@brauner.io>,
"Todd Kjos" <tkjos@google.com>
Subject: Re: [PATCH v3 1/1] binder: transaction latency tracking for user build
Date: Thu, 30 Apr 2020 10:51:05 +0200 [thread overview]
Message-ID: <20200430085105.GF2496467@kroah.com> (raw)
In-Reply-To: <1588234439-7959-2-git-send-email-Frankie.Chang@mediatek.com>
On Thu, Apr 30, 2020 at 04:13:59PM +0800, Frankie Chang wrote:
> Record start/end timestamp for binder transaction.
> When transaction is completed or transaction is free,
> it would be checked if transaction latency over threshold (2 sec),
> if yes, printing related information for tracing.
>
> /* Implement details */
> - Add tracepoint/trace at free transaction.
> Since the original trace_binder_transaction_received cannot
> precisely present the real finished time of transaction, adding a
> trace_binder_free_transaction at the point of free transaction
> may be more close to it.
>
> - Add latency tracer module to monitor slow transaction.
> The trace_binder_free_transaction would not be enabled
> by default. Monitoring which transaction is too slow to
> cause some of exceptions is important. So we hook the
> tracepoint to call the monitor function.
>
> - Move some struct from core file to header file.
> Need some struct defined in core file in latency trace module
> In addition, moving all structs to header file makes module
> more extendable, and make all these strcuts to be defined
> in the same file.
Also, this should be split up into a patch series, the first moving
things around, and the rest of the patches each adding a single feature.
As it is, this patch is almost impossible to review.
thanks,
greg k-h
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-04-30 8:51 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 6:52 [PATCH v1 1/1] binder: transaction latency tracking for user build Frankie Chang
2020-02-05 9:36 ` Greg Kroah-Hartman
2020-02-05 15:49 ` Joel Fernandes
2020-02-07 3:10 ` Frankie Chang
2020-02-07 3:17 ` Joel Fernandes
2020-02-07 6:28 ` Frankie Chang
2020-02-07 13:26 ` Joel Fernandes
2020-04-13 6:24 ` Frankie Chang
2020-04-15 5:37 ` [PATCH v2] " Frankie Chang
2020-04-15 5:37 ` [PATCH v2 1/1] " Frankie Chang
2020-04-15 22:25 ` Todd Kjos
2020-04-29 8:32 ` Frankie Chang
2020-04-30 8:13 ` Frankie Chang
2020-04-30 8:13 ` [PATCH v3 1/1] " Frankie Chang
2020-04-30 8:50 ` Greg Kroah-Hartman
2020-04-30 8:51 ` Greg Kroah-Hartman [this message]
2020-05-07 8:10 ` Frankie Chang
2020-05-07 8:10 ` [PATCH v4 1/3] binder: move structs from core file to header file Frankie Chang
2020-05-07 8:10 ` [PATCH v4 2/3] binder: add trace at free transaction Frankie Chang
2020-05-07 8:10 ` [PATCH v4 3/3] binder: add transaction latency tracer Frankie Chang
2020-05-07 8:55 ` Greg Kroah-Hartman
2020-05-11 12:32 ` Frankie Chang
2020-06-10 12:23 ` [PATCH v5] binder: transaction latency tracking for user build Frankie Chang
2020-06-10 12:23 ` [PATCH v5 1/3] binder: move structs from core file to header file Frankie Chang
2020-06-10 12:23 ` [PATCH v5 2/3] binder: add trace at free transaction Frankie Chang
2020-07-20 18:23 ` Todd Kjos
2020-07-23 2:47 ` Frankie Chang
2020-06-10 12:23 ` [PATCH v5 3/3] binder: add transaction latency tracer Frankie Chang
2020-07-20 18:56 ` Todd Kjos
2020-07-23 3:01 ` Frankie Chang
2020-07-02 13:25 ` [PATCH v5] binder: transaction latency tracking for user build Frankie Chang
2020-07-20 13:40 ` Frankie Chang
2020-07-28 3:19 ` [PATCH v6] " Frankie Chang
2020-07-28 3:19 ` [PATCH v6 1/3] binder: move structs from core file to header file Frankie Chang
2020-07-28 3:20 ` [PATCH v6 2/3] binder: add trace at free transaction Frankie Chang
2020-07-31 18:50 ` Todd Kjos
2020-08-03 3:11 ` Frankie Chang
2020-08-03 15:12 ` Todd Kjos
2020-08-04 2:45 ` Frankie Chang
2020-08-04 13:59 ` [PATCH v7] binder: transaction latency tracking for user build Frankie Chang
2020-08-04 13:59 ` [PATCH v7 1/3] binder: move structs from core file to header file Frankie Chang
2020-08-04 15:24 ` Todd Kjos
2020-08-04 13:59 ` [PATCH v7 2/3] binder: add trace at free transaction Frankie Chang
2020-08-04 15:26 ` Todd Kjos
2020-08-04 13:59 ` [PATCH v7 3/3] binder: add transaction latency tracer Frankie Chang
2020-08-04 15:28 ` Todd Kjos
2020-09-07 14:41 ` peter enderborg
2020-09-03 16:21 ` [PATCH v7] binder: transaction latency tracking for user build Greg Kroah-Hartman
2020-09-07 6:49 ` Frankie Chang
2020-09-07 7:00 ` Greg Kroah-Hartman
2020-09-07 12:00 ` [PATCH v8] " Frankie Chang
2020-09-07 12:00 ` [PATCH v8 1/3] binder: move structs from core file to header file Frankie Chang
2020-09-07 12:00 ` [PATCH v8 2/3] binder: add trace at free transaction Frankie Chang
2020-09-07 12:00 ` [PATCH v8 3/3] binder: add transaction latency tracer Frankie Chang
2020-09-07 12:25 ` Greg Kroah-Hartman
2020-09-07 13:51 ` Frankie Chang
2020-09-07 14:09 ` Greg Kroah-Hartman
2020-09-08 5:38 ` Frankie Chang
2020-09-08 14:06 ` [PATCH v9] binder: transaction latency tracking for user build Frankie Chang
2020-09-08 14:06 ` [PATCH v9 1/3] binder: move structs from core file to header file Frankie Chang
2020-09-08 14:06 ` [PATCH v9 2/3] binder: add trace at free transaction Frankie Chang
2020-09-08 14:06 ` [PATCH v9 3/3] binder: add transaction latency tracer Frankie Chang
2020-09-16 17:38 ` Greg Kroah-Hartman
2020-10-15 17:02 ` [PATCH v10 " Frankie Chang
2020-10-15 17:02 ` [PATCH v10 1/3] binder: move structs from core file to header file Frankie Chang
2020-10-15 17:02 ` [PATCH v10 2/3] binder: add trace at free transaction Frankie Chang
2020-10-15 17:02 ` [PATCH v10 3/3] binder: add transaction latency tracer Frankie Chang
2020-09-16 15:29 ` [PATCH v9] binder: transaction latency tracking for user build Greg Kroah-Hartman
2020-09-07 12:24 ` [PATCH v8] " Greg Kroah-Hartman
2020-07-28 3:20 ` [PATCH v6 3/3] binder: add transaction latency tracer Frankie Chang
2020-05-07 18:21 ` [PATCH v4 " Todd Kjos
2020-05-11 12:35 ` Frankie Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430085105.GF2496467@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Frankie.Chang@mediatek.com \
--cc=Jian-Min.Liu@mediatek.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maco@android.com \
--cc=tkjos@android.com \
--cc=tkjos@google.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).