Linux-mediatek Archive on
 help / color / Atom feed
* [PATCH] usb: gadget: udc: gr_udc: fix memleak on error handling path in gr_ep_init()
@ 2020-06-26 13:17 Evgeny Novikov
  0 siblings, 0 replies; only message in thread
From: Evgeny Novikov @ 2020-06-26 13:17 UTC (permalink / raw)
  To: Felipe Balbi
  Cc: ldv-project, Jason Yan, Evgeny Novikov, Greg Kroah-Hartman,
	linux-usb, YueHaibing, linux-kernel, Stephen Boyd, Chunfeng Yun,
	Jia-Ju Bai, linux-mediatek, Matthias Brugger, linux-arm-kernel

gr_ep_init() does not assign the allocated request anywhere if allocation
of memory for the buffer fails. This is a memory leak fixed by the given

Found by Linux Driver Verification project (

Signed-off-by: Evgeny Novikov <>
 drivers/usb/gadget/udc/gr_udc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c
index 7164ad9800f1..7419889ebe9a 100644
--- a/drivers/usb/gadget/udc/gr_udc.c
+++ b/drivers/usb/gadget/udc/gr_udc.c
@@ -1980,9 +1980,12 @@ static int gr_ep_init(struct gr_udc *dev, int num, int is_in, u32 maxplimit)
 	if (num == 0) {
 		_req = gr_alloc_request(&ep->ep, GFP_ATOMIC);
+		if (!_req)
+			return -ENOMEM;
 		buf = devm_kzalloc(dev->dev, PAGE_SIZE, GFP_DMA | GFP_ATOMIC);
-		if (!_req || !buf) {
-			/* possible _req freed by gr_probe via gr_remove */
+		if (!buf) {
+			gr_free_request(&ep->ep, _req);
 			return -ENOMEM;

Linux-mediatek mailing list

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-26 13:17 [PATCH] usb: gadget: udc: gr_udc: fix memleak on error handling path in gr_ep_init() Evgeny Novikov

Linux-mediatek Archive on

Archives are clonable:
	git clone --mirror linux-mediatek/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mediatek linux-mediatek/ \
	public-inbox-index linux-mediatek

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone