* [PATCH 05/15] mmc: host: mtk-sd: Demote msdc_recheck_sdio_irq() function header
[not found] <20200701124702.908713-1-lee.jones@linaro.org>
@ 2020-07-01 12:46 ` Lee Jones
2020-07-01 13:09 ` Matthias Brugger
0 siblings, 1 reply; 2+ messages in thread
From: Lee Jones @ 2020-07-01 12:46 UTC (permalink / raw)
To: ulf.hansson
Cc: linux-kernel, linux-mediatek, linux-arm-kernel, Matthias Brugger,
Lee Jones, Chaotian Jing
No other function in the file is documented using kerneldoc and no
effort to document the function arguments have been made. It's a
bit of an oddity to say the least. Let's downgrade it from
kerneldoc to a standard comment block instead.
Fixes the following W=1 kernel build warning:
drivers/mmc/host/mtk-sd.c:1030: warning: Function parameter or member 'host' not described in 'msdc_recheck_sdio_irq'
Cc: Chaotian Jing <chaotian.jing@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-mediatek@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mmc/host/mtk-sd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 39e7fc54c438f..49ac802ebbfeb 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -1018,13 +1018,12 @@ static int msdc_auto_cmd_done(struct msdc_host *host, int events,
return cmd->error;
}
-/**
+/*
* msdc_recheck_sdio_irq - recheck whether the SDIO irq is lost
*
* Host controller may lost interrupt in some special case.
* Add SDIO irq recheck mechanism to make sure all interrupts
* can be processed immediately
- *
*/
static void msdc_recheck_sdio_irq(struct msdc_host *host)
{
--
2.25.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 05/15] mmc: host: mtk-sd: Demote msdc_recheck_sdio_irq() function header
2020-07-01 12:46 ` [PATCH 05/15] mmc: host: mtk-sd: Demote msdc_recheck_sdio_irq() function header Lee Jones
@ 2020-07-01 13:09 ` Matthias Brugger
0 siblings, 0 replies; 2+ messages in thread
From: Matthias Brugger @ 2020-07-01 13:09 UTC (permalink / raw)
To: Lee Jones, ulf.hansson
Cc: linux-mediatek, Chaotian Jing, linux-kernel, linux-arm-kernel
On 01/07/2020 14:46, Lee Jones wrote:
> No other function in the file is documented using kerneldoc and no
> effort to document the function arguments have been made. It's a
> bit of an oddity to say the least. Let's downgrade it from
> kerneldoc to a standard comment block instead.
>
> Fixes the following W=1 kernel build warning:
>
> drivers/mmc/host/mtk-sd.c:1030: warning: Function parameter or member 'host' not described in 'msdc_recheck_sdio_irq'
>
> Cc: Chaotian Jing <chaotian.jing@mediatek.com>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: linux-mediatek@lists.infradead.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/mmc/host/mtk-sd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 39e7fc54c438f..49ac802ebbfeb 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1018,13 +1018,12 @@ static int msdc_auto_cmd_done(struct msdc_host *host, int events,
> return cmd->error;
> }
>
> -/**
> +/*
> * msdc_recheck_sdio_irq - recheck whether the SDIO irq is lost
> *
> * Host controller may lost interrupt in some special case.
> * Add SDIO irq recheck mechanism to make sure all interrupts
> * can be processed immediately
> - *
> */
> static void msdc_recheck_sdio_irq(struct msdc_host *host)
> {
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-01 13:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200701124702.908713-1-lee.jones@linaro.org>
2020-07-01 12:46 ` [PATCH 05/15] mmc: host: mtk-sd: Demote msdc_recheck_sdio_irq() function header Lee Jones
2020-07-01 13:09 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).