From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dongchun Zhu <dongchun.zhu@mediatek.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
drinkcat@chromium.org, srv_heupstream@mediatek.com,
shengnan.wang@mediatek.com, tfiga@chromium.org,
louis.kuo@mediatek.com, sj.huang@mediatek.com,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
sakari.ailus@linux.intel.com, matthias.bgg@gmail.com,
bingbu.cao@intel.com, mchehab@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v15 2/2] media: i2c: Add OV02A10 image sensor driver
Date: Thu, 19 Nov 2020 15:57:00 +0200 [thread overview]
Message-ID: <20201119135700.GG4077@smile.fi.intel.com> (raw)
In-Reply-To: <1605791201.4733.114.camel@mhfsdcap03>
On Thu, Nov 19, 2020 at 09:06:41PM +0800, Dongchun Zhu wrote:
> On Fri, 2020-10-23 at 17:31 +0300, Andy Shevchenko wrote:
> > On Tue, Oct 13, 2020 at 09:05:03PM +0800, Dongchun Zhu wrote:
> > > Add a V4L2 sub-device driver for OmniVision OV02A10 image sensor.
...
> > > +#define OV02A10_ID_MASK 0xffff
> >
> > GENMASK()
> >
> > (And include bits.h for that)
> >
>
> It seems could build pass without including bits.h, as DW9768 once used.
The rule of thumb is to include all headers you have direct users for.
Exceptions when you have indirect inclusion that guarantees to provide
others (like bitmap.h implies bits.h, etc).
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
prev parent reply other threads:[~2020-11-19 13:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 13:05 [PATCH v15 0/2] media: i2c: Add support for OV02A10 sensor Dongchun Zhu
2020-10-13 13:05 ` [PATCH v15 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings Dongchun Zhu
2020-10-13 16:19 ` Sakari Ailus
2020-10-14 2:10 ` Dongchun Zhu
2020-10-14 8:31 ` Sakari Ailus
2020-10-14 11:48 ` Tomasz Figa
2020-10-16 17:21 ` Rob Herring
2020-10-19 8:27 ` Sakari Ailus
2020-10-19 19:20 ` Tomasz Figa
2020-10-26 22:25 ` Tomasz Figa
2020-10-30 16:27 ` Sakari Ailus
2020-11-19 12:58 ` Dongchun Zhu
2020-10-16 17:21 ` Rob Herring
2020-10-13 13:05 ` [PATCH v15 2/2] media: i2c: Add OV02A10 image sensor driver Dongchun Zhu
2020-10-23 14:31 ` Andy Shevchenko
2020-11-19 13:06 ` Dongchun Zhu
2020-11-19 13:57 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119135700.GG4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dongchun.zhu@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shengnan.wang@mediatek.com \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).