* [PATCH net] net: phy: mediatek: add the missing suspend/resume callbacks
@ 2021-08-23 4:44 DENG Qingfang
2021-08-23 13:00 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: DENG Qingfang @ 2021-08-23 4:44 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Jakub Kicinski, Matthias Brugger, open list:ETHERNET PHY LIBRARY,
open list, moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
Without suspend/resume callbacks, the PHY cannot be powered down/up
administratively.
Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
---
drivers/net/phy/mediatek-ge.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c
index 11ff335d6228..b7a5ae20edd5 100644
--- a/drivers/net/phy/mediatek-ge.c
+++ b/drivers/net/phy/mediatek-ge.c
@@ -81,6 +81,8 @@ static struct phy_driver mtk_gephy_driver[] = {
*/
.config_intr = genphy_no_config_intr,
.handle_interrupt = genphy_handle_interrupt_no_ack,
+ .suspend = genphy_suspend,
+ .resume = genphy_resume,
.read_page = mtk_gephy_read_page,
.write_page = mtk_gephy_write_page,
},
@@ -93,6 +95,8 @@ static struct phy_driver mtk_gephy_driver[] = {
*/
.config_intr = genphy_no_config_intr,
.handle_interrupt = genphy_handle_interrupt_no_ack,
+ .suspend = genphy_suspend,
+ .resume = genphy_resume,
.read_page = mtk_gephy_read_page,
.write_page = mtk_gephy_write_page,
},
--
2.25.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: mediatek: add the missing suspend/resume callbacks
2021-08-23 4:44 [PATCH net] net: phy: mediatek: add the missing suspend/resume callbacks DENG Qingfang
@ 2021-08-23 13:00 ` Andrew Lunn
2021-08-24 23:53 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2021-08-23 13:00 UTC (permalink / raw)
To: DENG Qingfang
Cc: Heiner Kallweit, Russell King, David S. Miller, Jakub Kicinski,
Matthias Brugger, open list:ETHERNET PHY LIBRARY, open list,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
On Mon, Aug 23, 2021 at 12:44:21PM +0800, DENG Qingfang wrote:
> Without suspend/resume callbacks, the PHY cannot be powered down/up
> administratively.
>
> Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: mediatek: add the missing suspend/resume callbacks
2021-08-23 13:00 ` Andrew Lunn
@ 2021-08-24 23:53 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-08-24 23:53 UTC (permalink / raw)
To: Andrew Lunn, DENG Qingfang
Cc: Heiner Kallweit, Russell King, David S. Miller, Matthias Brugger,
open list:ETHERNET PHY LIBRARY, open list,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
On Mon, 23 Aug 2021 15:00:08 +0200 Andrew Lunn wrote:
> On Mon, Aug 23, 2021 at 12:44:21PM +0800, DENG Qingfang wrote:
> > Without suspend/resume callbacks, the PHY cannot be powered down/up
> > administratively.
> >
> > Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
> > Signed-off-by: DENG Qingfang <dqfext@gmail.com>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks!
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-24 23:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 4:44 [PATCH net] net: phy: mediatek: add the missing suspend/resume callbacks DENG Qingfang
2021-08-23 13:00 ` Andrew Lunn
2021-08-24 23:53 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).