* [PATCH v3] dt-bindings: dsp: mediatek: add mt8195 dsp document
@ 2022-01-03 4:32 YC Hung
2022-01-05 15:53 ` Daniel Baluta
0 siblings, 1 reply; 3+ messages in thread
From: YC Hung @ 2022-01-03 4:32 UTC (permalink / raw)
To: broonie, tiwai, robh+dt, matthias.bgg
Cc: yc.hung, alsa-devel, linux-mediatek, linux-arm-kernel,
linux-kernel, devicetree, daniel.baluta, trevor.wu,
allen-kh.cheng, cezary.rojewski
From: "YC Hung" <yc.hung@mediatek.com>
This patch adds mt8195 dsp document. The dsp is used for Sound Open
Firmware driver node. It includes registers, clocks, memory regions,
and mailbox for dsp.
Signed-off-by: yc.hung <yc.hung@mediatek.com>
---
Changes since v2:
Remove useless watchdog interrupt.
Add commit message more detail description.
Changes since v1:
Rename yaml file name as mediatek,mt8195-dsp.yaml
Refine descriptions for mailbox, memory-region and drop unused labels
in examples.
---
---
.../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
index bde763191d86..779daa786739 100644
--- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
+++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
@@ -27,14 +27,6 @@ properties:
- const: cfg
- const: sram
- interrupts:
- items:
- - description: watchdog interrupt
-
- interrupt-names:
- items:
- - const: wdt
-
clocks:
items:
- description: mux for audio dsp clock
@@ -75,8 +67,6 @@ required:
- compatible
- reg
- reg-names
- - interrupts
- - interrupt-names
- clocks
- clock-names
- memory-region
@@ -95,8 +85,6 @@ examples:
reg = <0x10803000 0x1000>,
<0x10840000 0x40000>;
reg-names = "cfg", "sram";
- interrupts = <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH 0>;
- interrupt-names = "wdt";
clocks = <&topckgen 10>, //CLK_TOP_ADSP
<&clk26m>,
<&topckgen 107>, //CLK_TOP_AUDIO_LOCAL_BUS
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: dsp: mediatek: add mt8195 dsp document
2022-01-03 4:32 [PATCH v3] dt-bindings: dsp: mediatek: add mt8195 dsp document YC Hung
@ 2022-01-05 15:53 ` Daniel Baluta
2022-01-06 7:10 ` YC Hung
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Baluta @ 2022-01-05 15:53 UTC (permalink / raw)
To: YC Hung
Cc: Mark Brown, Takashi Iwai, Rob Herring, matthias.bgg, Linux-ALSA,
linux-mediatek, linux-arm-kernel, Linux Kernel Mailing List,
Devicetree List, Daniel Baluta, trevor.wu, allen-kh.cheng,
Cezary Rojewski
On Mon, Jan 3, 2022 at 1:00 PM YC Hung <yc.hung@mediatek.com> wrote:
>
> From: "YC Hung" <yc.hung@mediatek.com>
>
> This patch adds mt8195 dsp document. The dsp is used for Sound Open
> Firmware driver node. It includes registers, clocks, memory regions,
> and mailbox for dsp.
>
> Signed-off-by: yc.hung <yc.hung@mediatek.com>
The code patch should be created against original source code from
Rob's tree. Here it seems the patch is against v2.
This isn't going to work! Because when Rob will try to apply the patch
it will fail since he doesn't have (and doesnt need to have)
your previous versions.
So, please keep the changes history (that's a good thing!) but always
rebase your patch on maintainer's tree.
> ---
> Changes since v2:
> Remove useless watchdog interrupt.
> Add commit message more detail description.
>
> Changes since v1:
> Rename yaml file name as mediatek,mt8195-dsp.yaml
> Refine descriptions for mailbox, memory-region and drop unused labels
> in examples.
> ---
> ---
> .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> index bde763191d86..779daa786739 100644
> --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> @@ -27,14 +27,6 @@ properties:
> - const: cfg
> - const: sram
>
> - interrupts:
> - items:
> - - description: watchdog interrupt
> -
> - interrupt-names:
> - items:
> - - const: wdt
> -
> clocks:
> items:
> - description: mux for audio dsp clock
> @@ -75,8 +67,6 @@ required:
> - compatible
> - reg
> - reg-names
> - - interrupts
> - - interrupt-names
> - clocks
> - clock-names
> - memory-region
> @@ -95,8 +85,6 @@ examples:
> reg = <0x10803000 0x1000>,
> <0x10840000 0x40000>;
> reg-names = "cfg", "sram";
> - interrupts = <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH 0>;
> - interrupt-names = "wdt";
> clocks = <&topckgen 10>, //CLK_TOP_ADSP
> <&clk26m>,
> <&topckgen 107>, //CLK_TOP_AUDIO_LOCAL_BUS
> --
> 2.18.0
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: dsp: mediatek: add mt8195 dsp document
2022-01-05 15:53 ` Daniel Baluta
@ 2022-01-06 7:10 ` YC Hung
0 siblings, 0 replies; 3+ messages in thread
From: YC Hung @ 2022-01-06 7:10 UTC (permalink / raw)
To: Daniel Baluta
Cc: Mark Brown, Takashi Iwai, Rob Herring, matthias.bgg, Linux-ALSA,
linux-mediatek, linux-arm-kernel, Linux Kernel Mailing List,
Devicetree List, Daniel Baluta, trevor.wu, allen-kh.cheng,
Cezary Rojewski
Hi Daniel,
My mistake. Thanks for review and comments. I have updated v4 to fix
it. Thanks
On Wed, 2022-01-05 at 17:53 +0200, Daniel Baluta wrote:
> On Mon, Jan 3, 2022 at 1:00 PM YC Hung <yc.hung@mediatek.com> wrote:
> >
> > From: "YC Hung" <yc.hung@mediatek.com>
> >
> > This patch adds mt8195 dsp document. The dsp is used for Sound Open
> > Firmware driver node. It includes registers, clocks, memory
> > regions,
> > and mailbox for dsp.
> >
> > Signed-off-by: yc.hung <yc.hung@mediatek.com>
>
> The code patch should be created against original source code from
> Rob's tree. Here it seems the patch is against v2.
>
> This isn't going to work! Because when Rob will try to apply the
> patch
> it will fail since he doesn't have (and doesnt need to have)
> your previous versions.
>
> So, please keep the changes history (that's a good thing!) but always
> rebase your patch on maintainer's tree.
>
>
> > ---
> > Changes since v2:
> > Remove useless watchdog interrupt.
> > Add commit message more detail description.
> >
> > Changes since v1:
> > Rename yaml file name as mediatek,mt8195-dsp.yaml
> > Refine descriptions for mailbox, memory-region and drop unused
> > labels
> > in examples.
> > ---
> > ---
> > .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 12 --------
> > ----
> > 1 file changed, 12 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-
> > dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-
> > dsp.yaml
> > index bde763191d86..779daa786739 100644
> > --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-
> > dsp.yaml
> > +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-
> > dsp.yaml
> > @@ -27,14 +27,6 @@ properties:
> > - const: cfg
> > - const: sram
> >
> > - interrupts:
> > - items:
> > - - description: watchdog interrupt
> > -
> > - interrupt-names:
> > - items:
> > - - const: wdt
> > -
> > clocks:
> > items:
> > - description: mux for audio dsp clock
> > @@ -75,8 +67,6 @@ required:
> > - compatible
> > - reg
> > - reg-names
> > - - interrupts
> > - - interrupt-names
> > - clocks
> > - clock-names
> > - memory-region
> > @@ -95,8 +85,6 @@ examples:
> > reg = <0x10803000 0x1000>,
> > <0x10840000 0x40000>;
> > reg-names = "cfg", "sram";
> > - interrupts = <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH 0>;
> > - interrupt-names = "wdt";
> > clocks = <&topckgen 10>, //CLK_TOP_ADSP
> > <&clk26m>,
> > <&topckgen 107>, //CLK_TOP_AUDIO_LOCAL_BUS
> > --
> > 2.18.0
> >
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-06 7:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-03 4:32 [PATCH v3] dt-bindings: dsp: mediatek: add mt8195 dsp document YC Hung
2022-01-05 15:53 ` Daniel Baluta
2022-01-06 7:10 ` YC Hung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).