From: <guangming.cao@mediatek.com>
To: <christian.koenig@amd.com>
Cc: <Brian.Starkey@arm.com>, <benjamin.gaignard@linaro.org>,
<bo.song@mediatek.com>, <dri-devel@lists.freedesktop.org>,
<guangming.cao@mediatek.com>, <jianjiao.zeng@mediatek.com>,
<john.stultz@linaro.org>, <labbott@redhat.com>,
<libo.kang@mediatek.com>, <linaro-mm-sig@lists.linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <lmark@codeaurora.org>,
<matthias.bgg@gmail.com>, <mingyuan.ma@mediatek.com>,
<sumit.semwal@linaro.org>, <wsd_upstream@mediatek.com>,
<yf.wang@mediatek.com>
Subject: Re: [PATCH v2] dma-buf: dma-heap: Add a size check for allocation
Date: Wed, 5 Jan 2022 14:36:43 +0800 [thread overview]
Message-ID: <20220105063643.119874-1-guangming.cao@mediatek.com> (raw)
In-Reply-To: <c05749d0-4c24-8763-a459-27257b2524ed@amd.com>
From: Guangming.Cao <guangming.cao@mediatek.com>
On Tue, 2022-01-04 at 08:47 +0100, Christian K鰊ig wrote:
> Am 03.01.22 um 19:57 schrieb John Stultz:
> > On Mon, Dec 27, 2021 at 1:52 AM <guangming.cao@mediatek.com> wrote:
> > > From: Guangming <Guangming.Cao@mediatek.com>
> > >
> >
> > Thanks for submitting this!
> >
> > > Add a size check for allcation since the allocation size is
> >
> > nit: "allocation" above.
> >
> > > always less than the total DRAM size.
> >
> > In general, it might be good to add more context to the commit
> > message
> > to better answer *why* this change is needed rather than what the
> > change is doing. ie: What negative thing happens without this
> > change?
> > And so how does this change avoid or improve things?
>
> Completely agree, just one little addition: Could you also add this
> why
> as comment to the code?
>
> When we stumble over this five years from now it is absolutely not
> obvious why we do this.
>
> Thanks,
> Christian.
>
Thanks for your reply!
I will update the related reason in the patch later.
The reason for adding this check is that we met a case that the user
sent an invalid size(It seems it's a negative value, MSB is 0xff, it's
larger than DRAM size after convert it to size_t) to dma-heap to alloc
memory, and this allocation was running on a process(such as "gralloc"
on Android device) can't be killed by OOM flow, and we also couldn't
find the related dmabuf in "dma_buf_debug_show" because the related
dmabuf was not exported yet since the allocation is still on going.
Since this invalid argument case can be prevented at dma-heap side, so,
I added this size check, and moreover, to let debug it easily, I also
added logs when size is bigger than a threshold we set in mtk system
heap.
If you think that print logs in dma-heap framework is better, I will
update it in next version.
If you have better solution(such as dump the size under allocating
in "dma_buf_debug_show", which maybe need add global variable to record
it), please kindly let me know.
Thanks :)
Guangming
> >
> >
> > > Signed-off-by: Guangming <Guangming.Cao@mediatek.com>
> > > Signed-off-by: jianjiao zeng <jianjiao.zeng@mediatek.com>
> > > ---
> > > v2: 1. update size limitation as total_dram page size.
> > > 2. update commit message
> > > ---
> > > drivers/dma-buf/dma-heap.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-
> > > heap.c
> > > index 56bf5ad01ad5..e39d2be98d69 100644
> > > --- a/drivers/dma-buf/dma-heap.c
> > > +++ b/drivers/dma-buf/dma-heap.c
> > > @@ -55,6 +55,8 @@ static int dma_heap_buffer_alloc(struct
> > > dma_heap *heap, size_t len,
> > > struct dma_buf *dmabuf;
> > > int fd;
> > >
> > > + if (len / PAGE_SIZE > totalram_pages())
> > > + return -EINVAL;
> >
> > This seems sane. I know ION used to have some 1/2 of memory cap to
> > avoid unnecessary memory pressure on crazy allocations.
> >
> > Could you send again with an improved commit message?
> >
> > thanks
> > -john
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2022-01-05 7:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 9:41 [PATCH] dma-buf: dma-heap: Add a size limitation for allocation guangming.cao
2021-12-27 9:51 ` [PATCH v2] dma-buf: dma-heap: Add a size check " guangming.cao
2022-01-03 18:57 ` John Stultz
2022-01-04 7:47 ` Christian König
2022-01-04 8:44 ` Guangming.Cao
2022-01-05 6:36 ` guangming.cao [this message]
2022-01-13 10:50 ` Sumit Semwal
2022-01-13 12:34 ` [PATCH v3] " guangming.cao
2022-01-13 12:57 ` Ruhl, Michael J
2022-01-13 13:00 ` Ruhl, Michael J
2022-01-13 13:05 ` Christian König
2022-01-13 23:26 ` John Stultz
2022-01-14 7:16 ` Christian König
2022-01-14 12:05 ` Guangming.Cao
2022-01-15 1:17 ` John Stultz
2022-01-19 9:59 ` Guangming.Cao
2022-01-19 20:37 ` John Stultz
2022-01-20 3:34 ` [PATCH v4] dma-buf: system_heap: " guangming.cao
2022-01-20 3:48 ` John Stultz
2022-01-20 7:08 ` [PATCH v5] " guangming.cao
2022-01-20 8:27 ` Christian König
2022-01-20 8:52 ` [PATCH v6] " guangming.cao
2022-01-20 10:00 ` [PATCH v6 RESEND] " guangming.cao
2022-01-20 10:22 ` Christian König
2021-12-27 9:47 [PATCH v2] dma-buf: dma-heap: " guangming.cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105063643.119874-1-guangming.cao@mediatek.com \
--to=guangming.cao@mediatek.com \
--cc=Brian.Starkey@arm.com \
--cc=benjamin.gaignard@linaro.org \
--cc=bo.song@mediatek.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jianjiao.zeng@mediatek.com \
--cc=john.stultz@linaro.org \
--cc=labbott@redhat.com \
--cc=libo.kang@mediatek.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lmark@codeaurora.org \
--cc=matthias.bgg@gmail.com \
--cc=mingyuan.ma@mediatek.com \
--cc=sumit.semwal@linaro.org \
--cc=wsd_upstream@mediatek.com \
--cc=yf.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).