[PATCH v2] clk: mediatek: gate: Export mtk_clk_register_gates_with_dev

[PATCH v2] clk: mediatek: gate: Export mtk_clk_register_gates_with_dev

[Yassine Oudjana]

From: Yassine Oudjana <y.oudjana@protonmail.com>

This allows it to be used in drivers built as modules.

Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
This patch was originally part of a series, and is sent alone now since
it doesn't depend on the rest of it and can be applied directly:
https://lore.kernel.org/linux-clk/20220519134728.456643-1-y.oudjana@protonmail.com/

 drivers/clk/mediatek/clk-gate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/mediatek/clk-gate.c b/drivers/clk/mediatek/clk-gate.c
index 421806236228..0c867136e49d 100644
--- a/drivers/clk/mediatek/clk-gate.c
+++ b/drivers/clk/mediatek/clk-gate.c
@@ -261,6 +261,7 @@ int mtk_clk_register_gates_with_dev(struct device_node *node,
 
 	return PTR_ERR(hw);
 }
+EXPORT_SYMBOL_GPL(mtk_clk_register_gates_with_dev);
 
 int mtk_clk_register_gates(struct device_node *node,
 			   const struct mtk_gate *clks, int num,
-- 
2.37.1

Re: [PATCH v2] clk: mediatek: gate: Export mtk_clk_register_gates_with_dev

[Markus Schneider-Pargmann]

Hi Yassine,

On Sat, Aug 13, 2022 at 09:32:49AM +0100, Yassine Oudjana wrote:
> From: Yassine Oudjana <y.oudjana@protonmail.com>
> 
> This allows it to be used in drivers built as modules.
> 
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

This change overlaps with my patch [1], I added export symbol for more
functions as it was necessary to build the mt8365 clock driver as a
module. I will rebase after this one was applied.

You already have two reviewed-bys, but if you need one more, here you go
;)

Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>

Best,
Markus

[1] https://lore.kernel.org/linux-mediatek/20220811084433.2598575-4-msp@baylibre.com/

> ---
> This patch was originally part of a series, and is sent alone now since
> it doesn't depend on the rest of it and can be applied directly:
> https://lore.kernel.org/linux-clk/20220519134728.456643-1-y.oudjana@protonmail.com/
> 
>  drivers/clk/mediatek/clk-gate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/mediatek/clk-gate.c b/drivers/clk/mediatek/clk-gate.c
> index 421806236228..0c867136e49d 100644
> --- a/drivers/clk/mediatek/clk-gate.c
> +++ b/drivers/clk/mediatek/clk-gate.c
> @@ -261,6 +261,7 @@ int mtk_clk_register_gates_with_dev(struct device_node *node,
>  
>  	return PTR_ERR(hw);
>  }
> +EXPORT_SYMBOL_GPL(mtk_clk_register_gates_with_dev);
>  
>  int mtk_clk_register_gates(struct device_node *node,
>  			   const struct mtk_gate *clks, int num,
> -- 
> 2.37.1
> 
> 

Re: [PATCH v2] clk: mediatek: gate: Export mtk_clk_register_gates_with_dev

[Chen-Yu Tsai]

On Mon, Aug 15, 2022 at 8:19 PM Markus Schneider-Pargmann
<msp@baylibre.com> wrote:
>
> Hi Yassine,
>
> On Sat, Aug 13, 2022 at 09:32:49AM +0100, Yassine Oudjana wrote:
> > From: Yassine Oudjana <y.oudjana@protonmail.com>
> >
> > This allows it to be used in drivers built as modules.
> >
> > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> > Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> This change overlaps with my patch [1], I added export symbol for more
> functions as it was necessary to build the mt8365 clock driver as a
> module. I will rebase after this one was applied.
>
> You already have two reviewed-bys, but if you need one more, here you go
> ;)
>
> Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>

I've queued this patch up here [1] and will send a pull request to
the clock maintainer later this week.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/wens/linux.git/log/?h=clk-mtk-for-6.1