* [PATCH 0/2] soc: mediatek: svs: add support for mt8188
@ 2022-08-23 9:13 jia-wei.chang
2022-08-23 9:13 ` [PATCH 1/2] dt-bindings: soc: mediatek: add mt8188 svs dt-bindings jia-wei.chang
2022-08-23 9:13 ` [PATCH 2/2] soc: mediatek: svs: add support for mt8188 jia-wei.chang
0 siblings, 2 replies; 4+ messages in thread
From: jia-wei.chang @ 2022-08-23 9:13 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Philipp Zabel, Roger Lu, Kevin Hilman, Jia-Wei Chang
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group, hsinyi,
AngeloGioacchino Del Regno
From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
This series supports MT8188 Smart Voltage Scaling (SVS) hardware which
used as optimization of opp voltage table for gpu dvfs driver.
This series is base on the series [1]:
[1]: Message ID: 20220823071708.30927-1-jia-wei.chang@mediatek.com
Jia-Wei Chang (2):
dt-bindings: soc: mediatek: add mt8188 svs dt-bindings
soc: mediatek: svs: add support for mt8188
.../bindings/soc/mediatek/mtk-svs.yaml | 1 +
drivers/soc/mediatek/mtk-svs.c | 164 ++++++++++++++++++
2 files changed, 165 insertions(+)
--
2.18.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] dt-bindings: soc: mediatek: add mt8188 svs dt-bindings
2022-08-23 9:13 [PATCH 0/2] soc: mediatek: svs: add support for mt8188 jia-wei.chang
@ 2022-08-23 9:13 ` jia-wei.chang
2022-08-23 11:17 ` Krzysztof Kozlowski
2022-08-23 9:13 ` [PATCH 2/2] soc: mediatek: svs: add support for mt8188 jia-wei.chang
1 sibling, 1 reply; 4+ messages in thread
From: jia-wei.chang @ 2022-08-23 9:13 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Philipp Zabel, Roger Lu, Kevin Hilman, Jia-Wei Chang
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group, hsinyi,
AngeloGioacchino Del Regno
From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
Add mt8188 svs compatible in dt-bindings.
Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
---
Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml b/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml
index 4bf26a333373..f9b47a761b1b 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml
@@ -24,6 +24,7 @@ properties:
enum:
- mediatek,mt8183-svs
- mediatek,mt8186-svs
+ - mediatek,mt8188-svs
- mediatek,mt8192-svs
- mediatek,mt8195-svs
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] soc: mediatek: svs: add support for mt8188
2022-08-23 9:13 [PATCH 0/2] soc: mediatek: svs: add support for mt8188 jia-wei.chang
2022-08-23 9:13 ` [PATCH 1/2] dt-bindings: soc: mediatek: add mt8188 svs dt-bindings jia-wei.chang
@ 2022-08-23 9:13 ` jia-wei.chang
1 sibling, 0 replies; 4+ messages in thread
From: jia-wei.chang @ 2022-08-23 9:13 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Philipp Zabel, Roger Lu, Kevin Hilman, Jia-Wei Chang
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group, hsinyi,
AngeloGioacchino Del Regno
From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
MT8188 svs gpu uses 2-line high bank and low bank to optimize the
voltage of opp table for higher and lower frequency respectively.
Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
---
drivers/soc/mediatek/mtk-svs.c | 164 +++++++++++++++++++++++++++++++++
1 file changed, 164 insertions(+)
diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index dd32a7315490..e82a5c62170f 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -897,6 +897,29 @@ static void svs_get_bank_volts_v3(struct svs_platform *svsp)
svsb->volt[i] -= svsb->dvt_fixed;
svsb->volt[i] += svsb->volt_od;
}
+
+ /* For voltage bin support */
+ if (svsb->opp_dfreq[0] > svsb->freq_base) {
+ svsb->volt[0] = svs_opp_volt_to_bank_volt(svsb->opp_dvolt[0],
+ svsb->volt_step,
+ svsb->volt_base);
+
+ /* Find voltage bin turn point */
+ for (i = 0; i < svsb->opp_count; i++) {
+ if (svsb->opp_dfreq[i] <= svsb->freq_base) {
+ svsb->vbin_turn_pt = i;
+ break;
+ }
+ }
+
+ /* Override svs bank voltages */
+ for (i = 1; i < svsb->vbin_turn_pt; i++)
+ svsb->volt[i] = interpolate(svsb->freq_pct[0],
+ svsb->freq_pct[svsb->vbin_turn_pt],
+ svsb->volt[0],
+ svsb->volt[svsb->vbin_turn_pt],
+ svsb->freq_pct[i]);
+ }
}
static void svs_set_bank_freq_pct_v3(struct svs_platform *svsp)
@@ -1846,6 +1869,80 @@ static bool svs_mt8192_efuse_parsing(struct svs_platform *svsp)
return true;
}
+static bool svs_mt8188_efuse_parsing(struct svs_platform *svsp)
+{
+ struct svs_bank *svsb;
+ struct nvmem_cell *cell;
+ u32 idx, i, golden_temp;
+
+ for (i = 0; i < svsp->efuse_max; i++)
+ if (svsp->efuse[i])
+ dev_info(svsp->dev, "M_HW_RES%d: 0x%08x\n",
+ i, svsp->efuse[i]);
+
+ if (!svsp->efuse[5]) {
+ dev_notice(svsp->dev, "svs_efuse[5] = 0x0?\n");
+ return false;
+ }
+
+ /* Svs efuse parsing */
+ for (idx = 0; idx < svsp->bank_max; idx++) {
+ svsb = &svsp->banks[idx];
+
+ if (svsb->type == SVSB_LOW) {
+ svsb->mtdes = svsp->efuse[5] & GENMASK(7, 0);
+ svsb->bdes = (svsp->efuse[5] >> 16) & GENMASK(7, 0);
+ svsb->mdes = (svsp->efuse[5] >> 24) & GENMASK(7, 0);
+ svsb->dcbdet = (svsp->efuse[15] >> 16) & GENMASK(7, 0);
+ svsb->dcmdet = (svsp->efuse[15] >> 24) & GENMASK(7, 0);
+ } else if (svsb->type == SVSB_HIGH) {
+ svsb->mtdes = svsp->efuse[4] & GENMASK(7, 0);
+ svsb->bdes = (svsp->efuse[4] >> 16) & GENMASK(7, 0);
+ svsb->mdes = (svsp->efuse[4] >> 24) & GENMASK(7, 0);
+ svsb->dcbdet = svsp->efuse[14] & GENMASK(7, 0);
+ svsb->dcmdet = (svsp->efuse[14] >> 8) & GENMASK(7, 0);
+ }
+
+ svsb->vmax += svsb->dvt_fixed;
+ }
+
+ /* Thermal efuse parsing */
+ cell = nvmem_cell_get(svsp->dev, "t-calibration-data");
+ if (IS_ERR_OR_NULL(cell)) {
+ dev_err(svsp->dev, "no \"t-calibration-data\"? %ld\n",
+ PTR_ERR(cell));
+ return false;
+ }
+
+ svsp->tefuse = nvmem_cell_read(cell, &svsp->tefuse_max);
+ if (IS_ERR(svsp->tefuse)) {
+ dev_err(svsp->dev, "cannot read thermal efuse: %ld\n",
+ PTR_ERR(svsp->tefuse));
+ nvmem_cell_put(cell);
+ return false;
+ }
+
+ svsp->tefuse_max /= sizeof(u32);
+ nvmem_cell_put(cell);
+
+ for (i = 0; i < svsp->tefuse_max; i++)
+ if (svsp->tefuse[i] != 0)
+ break;
+
+ if (i == svsp->tefuse_max)
+ golden_temp = 50; /* All thermal efuse data are 0 */
+ else
+ golden_temp = (svsp->tefuse[0] & GENMASK(31, 24)) >> 24;
+
+ for (idx = 0; idx < svsp->bank_max; idx++) {
+ svsb = &svsp->banks[idx];
+ svsb->mts = 500;
+ svsb->bts = (((500 * golden_temp + 250460) / 1000) - 25) * 4;
+ }
+
+ return true;
+}
+
static bool svs_mt8186_efuse_parsing(struct svs_platform *svsp)
{
struct svs_bank *svsb;
@@ -2454,6 +2551,61 @@ static struct svs_bank svs_mt8192_banks[] = {
},
};
+static struct svs_bank svs_mt8188_banks[] = {
+ {
+ .sw_id = SVSB_GPU,
+ .type = SVSB_LOW,
+ .set_freq_pct = svs_set_bank_freq_pct_v3,
+ .get_volts = svs_get_bank_volts_v3,
+ .volt_flags = SVSB_REMOVE_DVTFIXED_VOLT,
+ .mode_support = SVSB_MODE_INIT02,
+ .opp_count = MAX_OPP_ENTRIES,
+ .freq_base = 640000000,
+ .turn_freq_base = 640000000,
+ .volt_step = 6250,
+ .volt_base = 400000,
+ .vmax = 0x38,
+ .vmin = 0x1c,
+ .age_config = 0x555555,
+ .dc_config = 0x555555,
+ .dvt_fixed = 0x1,
+ .vco = 0x10,
+ .chk_shift = 0x87,
+ .core_sel = 0x0fff0000,
+ .int_st = BIT(0),
+ .ctl0 = 0x00100003,
+ },
+ {
+ .sw_id = SVSB_GPU,
+ .type = SVSB_HIGH,
+ .set_freq_pct = svs_set_bank_freq_pct_v3,
+ .get_volts = svs_get_bank_volts_v3,
+ .tzone_name = "gpu1",
+ .volt_flags = SVSB_REMOVE_DVTFIXED_VOLT |
+ SVSB_MON_VOLT_IGNORE,
+ .mode_support = SVSB_MODE_INIT02 | SVSB_MODE_MON,
+ .opp_count = MAX_OPP_ENTRIES,
+ .freq_base = 880000000,
+ .turn_freq_base = 640000000,
+ .volt_step = 6250,
+ .volt_base = 400000,
+ .vmax = 0x38,
+ .vmin = 0x1c,
+ .age_config = 0x555555,
+ .dc_config = 0x555555,
+ .dvt_fixed = 0x4,
+ .vco = 0x10,
+ .chk_shift = 0x87,
+ .core_sel = 0x0fff0001,
+ .int_st = BIT(1),
+ .ctl0 = 0x00100003,
+ .tzone_htemp = 85000,
+ .tzone_htemp_voffset = 0,
+ .tzone_ltemp = 25000,
+ .tzone_ltemp_voffset = 7,
+ },
+};
+
static struct svs_bank svs_mt8186_banks[] = {
{
.sw_id = SVSB_CPU_BIG,
@@ -2720,6 +2872,15 @@ static const struct svs_platform_data svs_mt8192_platform_data = {
.bank_max = ARRAY_SIZE(svs_mt8192_banks),
};
+static const struct svs_platform_data svs_mt8188_platform_data = {
+ .name = "mt8188-svs",
+ .banks = svs_mt8188_banks,
+ .efuse_parsing = svs_mt8188_efuse_parsing,
+ .probe = svs_mt8192_platform_probe,
+ .regs = svs_regs_v2,
+ .bank_max = ARRAY_SIZE(svs_mt8188_banks),
+};
+
static const struct svs_platform_data svs_mt8186_platform_data = {
.name = "mt8186-svs",
.banks = svs_mt8186_banks,
@@ -2746,6 +2907,9 @@ static const struct of_device_id svs_of_match[] = {
}, {
.compatible = "mediatek,mt8192-svs",
.data = &svs_mt8192_platform_data,
+ }, {
+ .compatible = "mediatek,mt8188-svs",
+ .data = &svs_mt8188_platform_data,
}, {
.compatible = "mediatek,mt8186-svs",
.data = &svs_mt8186_platform_data,
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: soc: mediatek: add mt8188 svs dt-bindings
2022-08-23 9:13 ` [PATCH 1/2] dt-bindings: soc: mediatek: add mt8188 svs dt-bindings jia-wei.chang
@ 2022-08-23 11:17 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-23 11:17 UTC (permalink / raw)
To: jia-wei.chang, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger, Philipp Zabel, Roger Lu, Kevin Hilman
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group, hsinyi,
AngeloGioacchino Del Regno
On 23/08/2022 12:13, jia-wei.chang wrote:
> From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
>
> Add mt8188 svs compatible in dt-bindings.
>
> Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-23 11:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-23 9:13 [PATCH 0/2] soc: mediatek: svs: add support for mt8188 jia-wei.chang
2022-08-23 9:13 ` [PATCH 1/2] dt-bindings: soc: mediatek: add mt8188 svs dt-bindings jia-wei.chang
2022-08-23 11:17 ` Krzysztof Kozlowski
2022-08-23 9:13 ` [PATCH 2/2] soc: mediatek: svs: add support for mt8188 jia-wei.chang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).