From: Rob Herring <robh@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Johnson Wang <johnson.wang@mediatek.com>,
krzysztof.kozlowski+dt@linaro.org, sboyd@kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
kuan-hsin.lee@mediatek.com, yu-chang.wang@mediatek.com,
Edward-JW Yang <edward-jw.yang@mediatek.com>
Subject: Re: [PATCH v3 2/4] dt-bindings: arm: mediatek: Add new bindings of MediaTek frequency hopping
Date: Fri, 30 Sep 2022 14:07:03 -0500 [thread overview]
Message-ID: <20220930190703.GA657929-robh@kernel.org> (raw)
In-Reply-To: <ed723cb2-ba79-55d7-7869-abf153e4af0a@collabora.com>
On Thu, Sep 29, 2022 at 03:07:49PM +0200, AngeloGioacchino Del Regno wrote:
> Il 29/09/22 13:46, Johnson Wang ha scritto:
> > Add the new binding documentation for MediaTek frequency hopping
> > and spread spectrum clocking control.
> >
> > Co-developed-by: Edward-JW Yang <edward-jw.yang@mediatek.com>
> > Signed-off-by: Edward-JW Yang <edward-jw.yang@mediatek.com>
> > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> > ---
> > .../arm/mediatek/mediatek,mt8186-fhctl.yaml | 53 +++++++++++++++++++
> > 1 file changed, 53 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-fhctl.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-fhctl.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-fhctl.yaml
> > new file mode 100644
> > index 000000000000..258dff7ce6bc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-fhctl.yaml
> > @@ -0,0 +1,53 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/mediatek/mediatek,mt8186-fhctl.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek frequency hopping and spread spectrum clocking control
> > +
> > +maintainers:
> > + - Edward-JW Yang <edward-jw.yang@mediatek.com>
> > +
> > +description: |
> > + Frequency hopping control (FHCTL) is a piece of hardware that control
> > + some PLLs to adopt "hopping" mechanism to adjust their frequency.
> > + Spread spectrum clocking (SSC) is another function provided by this hardware.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt8186-fhctl
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + description: Phandles of the PLL with FHCTL hardware capability.
> > + minItems: 1
> > + maxItems: 30
> > +
> > + mediatek,hopping-ssc-percent:
> > + description: The percentage of spread spectrum clocking for one PLL.
> > + minItems: 1
> > + maxItems: 30
> > + items:
> > + default: 0
> > + minimum: 0
> > + maximum: 8
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/mt8186-clk.h>
> > + fhctl: fhctl@1000ce00 {
> > + compatible = "mediatek,mt8186-fhctl";
> > + reg = <0x1000c000 0xe00>;
> > + clocks = <&apmixedsys CLK_APMIXED_MSDCPLL>;
> > + mediatek,hopping-ssc-percent = <3>;
> > + };
>
>
> .... a more realistic example:
One or 2 cells is really outside the scope of the binding as either is
valid. If the parent bus only has 32-bits of address space, there's
little reason to use 2 cells.
>
> #include <dt-bindings/clock/mt8186-clk.h>
>
> soc {
> #address-cells = <2>;
> #size-cells = <2>;
>
> fhctl: fhctl@1000ce00 {
> compatible = "mediatek,mt8186-fhctl";
> reg = <0 0x1000c000 0 0xe00>;
> clocks = <&apmixedsys CLK_APMIXED_MSDCPLL>;
> mediatek,hopping-ssc-percent = <3>;
> };
> };
>
> After which...
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
next prev parent reply other threads:[~2022-09-30 19:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 11:46 [PATCH v3 0/4] Introduce MediaTek frequency hopping driver Johnson Wang
2022-09-29 11:46 ` [PATCH v3 1/4] clk: mediatek: Export PLL operations symbols Johnson Wang
2022-09-29 13:07 ` AngeloGioacchino Del Regno
2022-10-06 11:24 ` Johnson Wang (王聖鑫)
2022-09-29 11:46 ` [PATCH v3 2/4] dt-bindings: arm: mediatek: Add new bindings of MediaTek frequency hopping Johnson Wang
2022-09-29 13:07 ` AngeloGioacchino Del Regno
2022-09-30 19:07 ` Rob Herring [this message]
2022-10-06 11:23 ` Johnson Wang (王聖鑫)
2022-10-06 12:33 ` AngeloGioacchino Del Regno
2022-10-11 6:55 ` Johnson Wang (王聖鑫)
2022-09-30 19:07 ` Rob Herring
2022-09-29 11:46 ` [PATCH v3 3/4] clk: mediatek: Add new clock driver to handle FHCTL hardware Johnson Wang
2022-09-29 11:46 ` [PATCH v3 4/4] clk: mediatek: Change PLL register API for MT8186 Johnson Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220930190703.GA657929-robh@kernel.org \
--to=robh@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=edward-jw.yang@mediatek.com \
--cc=johnson.wang@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuan-hsin.lee@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=sboyd@kernel.org \
--cc=yu-chang.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).