* [PATCH] media: Fix resource leaks in for_each_child_of_node() loops
@ 2023-05-30 9:45 Lu Hongfei
2023-07-19 7:41 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Lu Hongfei @ 2023-05-30 9:45 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Matthias Brugger,
AngeloGioacchino Del Regno, Hans Verkuil, Moudy Ho, Ping-Hsun Wu,
Arnd Bergmann, Lu Hongfei, Sun Ke,
open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
open list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
Cc: opensource.kernel
for_each_child_of_node should have of_node_put() avoid resource leaks.
Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c | 3 +++
1 file changed, 3 insertions(+)
mode change 100644 => 100755 drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
index 19a4a085f73a..5a6a61d68cba
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
@@ -1128,6 +1128,7 @@ int mdp_comp_config(struct mdp_dev *mdp)
comp = mdp_comp_create(mdp, node, id);
if (IS_ERR(comp)) {
ret = PTR_ERR(comp);
+ of_node_put(node);
goto err_init_comps;
}
@@ -1137,6 +1138,8 @@ int mdp_comp_config(struct mdp_dev *mdp)
pm_runtime_enable(comp->comp_dev);
}
+ of_node_put(node);
+
ret = mdp_comp_sub_create(mdp);
if (ret)
goto err_init_comps;
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: Fix resource leaks in for_each_child_of_node() loops
2023-05-30 9:45 [PATCH] media: Fix resource leaks in for_each_child_of_node() loops Lu Hongfei
@ 2023-07-19 7:41 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2023-07-19 7:41 UTC (permalink / raw)
To: Lu Hongfei, Mauro Carvalho Chehab, Matthias Brugger,
AngeloGioacchino Del Regno, Moudy Ho, Ping-Hsun Wu,
Arnd Bergmann, Sun Ke,
open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
open list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
Cc: opensource.kernel
Hi Lu Hongfei,
Please add the driver name to the subject line: 'media: mdp3:'!
On 30/05/2023 11:45, Lu Hongfei wrote:
> for_each_child_of_node should have of_node_put() avoid resource leaks.
>
> Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
> ---
> drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c | 3 +++
> 1 file changed, 3 insertions(+)
> mode change 100644 => 100755 drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
>
> diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
> index 19a4a085f73a..5a6a61d68cba
> --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
> +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
> @@ -1128,6 +1128,7 @@ int mdp_comp_config(struct mdp_dev *mdp)
> comp = mdp_comp_create(mdp, node, id);
> if (IS_ERR(comp)) {
> ret = PTR_ERR(comp);
> + of_node_put(node);
This is needed,
> goto err_init_comps;
> }
>
> @@ -1137,6 +1138,8 @@ int mdp_comp_config(struct mdp_dev *mdp)
> pm_runtime_enable(comp->comp_dev);
> }
>
> + of_node_put(node);
> +
but not this one. The for_each_child_of_node loop ended, so node == NULL and
there is nothing to put.
Regards,
Hans
> ret = mdp_comp_sub_create(mdp);
> if (ret)
> goto err_init_comps;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-19 7:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-30 9:45 [PATCH] media: Fix resource leaks in for_each_child_of_node() loops Lu Hongfei
2023-07-19 7:41 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).