* [PATCH] media: platform: mtk-mdp3: remove unused VIDEO_MEDIATEK_VPU config
@ 2022-10-04 2:37 Moudy Ho
2022-10-04 9:49 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 2+ messages in thread
From: Moudy Ho @ 2022-10-04 2:37 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Matthias Brugger, Hans Verkuil
Cc: Chun-Kuang Hu, linux-media, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group, Moudy Ho
Since remoteproc completely replaces the VPU in MDP3, unused config
should be removed to avoid compilation warnings reported on i386 or x86_64.
Warning messages:
WARNING: unmet direct dependencies detected for VIDEO_MEDIATEK_VPU
Depends on [n]: MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y]
&& MEDIA_PLATFORM_DRIVERS [=y] && V4L_MEM2MEM_DRIVERS [=n] &&
VIDEO_DEV [=y] && (ARCH_MEDIATEK || COMPILE_TEST [=y])
Selected by [y]:
- VIDEO_MEDIATEK_MDP3 [=y] && MEDIA_SUPPORT [=y] &&
MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] &&
(MTK_IOMMU [=n] || COMPILE_TEST [=y]) && VIDEO_DEV [=y] &&
(ARCH_MEDIATEK || COMPILE_TEST [=y]) && HAS_DMA [=y] && REMOTEPROC
[=y]
Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
---
drivers/media/platform/mediatek/mdp3/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/mediatek/mdp3/Kconfig b/drivers/media/platform/mediatek/mdp3/Kconfig
index 50ae07b75b5f..846e759a8f6a 100644
--- a/drivers/media/platform/mediatek/mdp3/Kconfig
+++ b/drivers/media/platform/mediatek/mdp3/Kconfig
@@ -9,7 +9,6 @@ config VIDEO_MEDIATEK_MDP3
select VIDEOBUF2_DMA_CONTIG
select V4L2_MEM2MEM_DEV
select MTK_MMSYS
- select VIDEO_MEDIATEK_VPU
select MTK_CMDQ
select MTK_SCP
default n
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: platform: mtk-mdp3: remove unused VIDEO_MEDIATEK_VPU config
2022-10-04 2:37 [PATCH] media: platform: mtk-mdp3: remove unused VIDEO_MEDIATEK_VPU config Moudy Ho
@ 2022-10-04 9:49 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 2+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-04 9:49 UTC (permalink / raw)
To: Moudy Ho, Mauro Carvalho Chehab, Matthias Brugger, Hans Verkuil
Cc: Chun-Kuang Hu, linux-media, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group
Il 04/10/22 04:37, Moudy Ho ha scritto:
> Since remoteproc completely replaces the VPU in MDP3, unused config
> should be removed to avoid compilation warnings reported on i386 or x86_64.
>
MTK_SCP replaces VIDEO_MEDIATEK_VPU... but your description is not wrong, anyway.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Warning messages:
> WARNING: unmet direct dependencies detected for VIDEO_MEDIATEK_VPU
> Depends on [n]: MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y]
> && MEDIA_PLATFORM_DRIVERS [=y] && V4L_MEM2MEM_DRIVERS [=n] &&
> VIDEO_DEV [=y] && (ARCH_MEDIATEK || COMPILE_TEST [=y])
> Selected by [y]:
> - VIDEO_MEDIATEK_MDP3 [=y] && MEDIA_SUPPORT [=y] &&
> MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] &&
> (MTK_IOMMU [=n] || COMPILE_TEST [=y]) && VIDEO_DEV [=y] &&
> (ARCH_MEDIATEK || COMPILE_TEST [=y]) && HAS_DMA [=y] && REMOTEPROC
> [=y]
>
> Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
> ---
> drivers/media/platform/mediatek/mdp3/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/mediatek/mdp3/Kconfig b/drivers/media/platform/mediatek/mdp3/Kconfig
> index 50ae07b75b5f..846e759a8f6a 100644
> --- a/drivers/media/platform/mediatek/mdp3/Kconfig
> +++ b/drivers/media/platform/mediatek/mdp3/Kconfig
> @@ -9,7 +9,6 @@ config VIDEO_MEDIATEK_MDP3
> select VIDEOBUF2_DMA_CONTIG
> select V4L2_MEM2MEM_DEV
> select MTK_MMSYS
> - select VIDEO_MEDIATEK_VPU
> select MTK_CMDQ
> select MTK_SCP
> default n
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-04 9:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 2:37 [PATCH] media: platform: mtk-mdp3: remove unused VIDEO_MEDIATEK_VPU config Moudy Ho
2022-10-04 9:49 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).