[PATCH v2] soc: mediatek: add SMC fid table for SIP interface

[PATCH v2] soc: mediatek: add SMC fid table for SIP interface

[Eason Yen]

soc: mediatek: add SMC fid table for SIP interface

1. Add a header file to provide SIP interface to ATF
   for clients, please define MTK_SIP_XXX  with specific ID

2. Add AUDIO SMC fid
   mtk sip call example:
   arm_smccc_smc(MTK_SIP_AUDIO_CONTROL,
                 MTK_AUDIO_SMC_OP_DRAM_REQUEST,
                 0, 0, 0, 0, 0, 0, &res)


Eason Yen (1):
  soc: mediatek: add SMC fid table for SIP interface

 include/linux/soc/mediatek/mtk_sip_svc.h |   28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 include/linux/soc/mediatek/mtk_sip_svc.h
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

[PATCH v2 1/1] soc: mediatek: add SMC fid table for SIP interface

[Eason Yen]

1. Add a header file to provide SIP interface to ATF
for clients, please define MTK_SIP_XXX  with specific ID

2. Add AUDIO SMC fid
mtk sip call example:
arm_smccc_smc(MTK_SIP_AUDIO_CONTROL,
              MTK_AUDIO_SMC_OP_DRAM_REQUEST,
              0, 0, 0, 0, 0, 0, &res)

Signed-off-by: Eason Yen <eason.yen@mediatek.com>
---
 include/linux/soc/mediatek/mtk_sip_svc.h |   28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 include/linux/soc/mediatek/mtk_sip_svc.h

diff --git a/include/linux/soc/mediatek/mtk_sip_svc.h b/include/linux/soc/mediatek/mtk_sip_svc.h
new file mode 100644
index 0000000..00ee0f4
--- /dev/null
+++ b/include/linux/soc/mediatek/mtk_sip_svc.h
@@ -0,0 +1,28 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2019 MediaTek Inc.
+ */
+
+#ifndef __MTK_SIP_SVC_H__
+#define __MTK_SIP_SVC_H__
+
+#include <linux/kernel.h>
+
+/* Error Code */
+#define SIP_SVC_E_SUCCESS               0
+#define SIP_SVC_E_NOT_SUPPORTED         -1
+#define SIP_SVC_E_INVALID_PARAMS        -2
+#define SIP_SVC_E_INVALID_Range         -3
+#define SIP_SVC_E_PERMISSION_DENY       -4
+
+#ifdef CONFIG_ARM64
+#define MTK_SIP_SMC_AARCH_BIT			0x40000000
+#else
+#define MTK_SIP_SMC_AARCH_BIT			0x00000000
+#endif
+
+/* AUDIO related SMC call */
+#define MTK_SIP_AUDIO_CONTROL \
+	(0x82000517 | MTK_SIP_SMC_AARCH_BIT)
+#endif
+/* __MTK_SIP_SVC_H__ */
-- 
1.7.9.5
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

Re: [PATCH v2] soc: mediatek: add SMC fid table for SIP interface

[Matthias Brugger]

On 11/11/2019 03:30, Eason Yen wrote:
> soc: mediatek: add SMC fid table for SIP interface
> 
> 1. Add a header file to provide SIP interface to ATF
>    for clients, please define MTK_SIP_XXX  with specific ID
> 
> 2. Add AUDIO SMC fid
>    mtk sip call example:
>    arm_smccc_smc(MTK_SIP_AUDIO_CONTROL,
>                  MTK_AUDIO_SMC_OP_DRAM_REQUEST,
>                  0, 0, 0, 0, 0, 0, &res)

Are you planning to upstream a driver consuming this interface?
If so, I propose to add this patch to the submission of the driver. Sounds good?

Regards,
Matthias

> 
> 
> Eason Yen (1):
>   soc: mediatek: add SMC fid table for SIP interface
> 
>  include/linux/soc/mediatek/mtk_sip_svc.h |   28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 include/linux/soc/mediatek/mtk_sip_svc.h
> 

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

Re: [PATCH v2] soc: mediatek: add SMC fid table for SIP interface

[Eason Yen]

Hi Matthias,


I will upstream mt6779 sound card driver on Mark's ASoC repo:
http://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

But it is still under internal reviewing and not yet upstream.
So, I think that this patch could be upstream first.

Maybe, other mtk sip clients can use this header and add their's
specific MTSK_SIP_* ID.

Regards,
Eason


On Mon, 2019-11-11 at 16:17 +0100, Matthias Brugger wrote:
> 
> On 11/11/2019 03:30, Eason Yen wrote:
> > soc: mediatek: add SMC fid table for SIP interface
> > 
> > 1. Add a header file to provide SIP interface to ATF
> >    for clients, please define MTK_SIP_XXX  with specific ID
> > 
> > 2. Add AUDIO SMC fid
> >    mtk sip call example:
> >    arm_smccc_smc(MTK_SIP_AUDIO_CONTROL,
> >                  MTK_AUDIO_SMC_OP_DRAM_REQUEST,
> >                  0, 0, 0, 0, 0, 0, &res)
> 
> Are you planning to upstream a driver consuming this interface?
> If so, I propose to add this patch to the submission of the driver. Sounds good?
> 
> Regards,
> Matthias
> 
> > 
> > 
> > Eason Yen (1):
> >   soc: mediatek: add SMC fid table for SIP interface
> > 
> >  include/linux/soc/mediatek/mtk_sip_svc.h |   28 ++++++++++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> >  create mode 100644 include/linux/soc/mediatek/mtk_sip_svc.h
> > 

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

Re: [PATCH v2] soc: mediatek: add SMC fid table for SIP interface

[Matthias Brugger]

On 12/11/2019 09:00, Eason Yen wrote:
> Hi Matthias,
> 
> 
> I will upstream mt6779 sound card driver on Mark's ASoC repo:
> http://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
> 
> But it is still under internal reviewing and not yet upstream.

Got it, thanks for the explanation. Then please add this patch to the series you
are working on for the sound card driver. Two reasons to do so. First this way
we make sure no not-used files will land in the kernel. Second, Mark will need
to apply this patch to his local tree if he tries to do some compile testing. If
it's not part of the series he will have to search for it in my repo or the
mailinglist.

Regards,
Matthias

> So, I think that this patch could be upstream first.
> 
> Maybe, other mtk sip clients can use this header and add their's
> specific MTSK_SIP_* ID.
> 
> Regards,
> Eason
> 
> 
> On Mon, 2019-11-11 at 16:17 +0100, Matthias Brugger wrote:
>>
>> On 11/11/2019 03:30, Eason Yen wrote:
>>> soc: mediatek: add SMC fid table for SIP interface
>>>
>>> 1. Add a header file to provide SIP interface to ATF
>>>    for clients, please define MTK_SIP_XXX  with specific ID
>>>
>>> 2. Add AUDIO SMC fid
>>>    mtk sip call example:
>>>    arm_smccc_smc(MTK_SIP_AUDIO_CONTROL,
>>>                  MTK_AUDIO_SMC_OP_DRAM_REQUEST,
>>>                  0, 0, 0, 0, 0, 0, &res)
>>
>> Are you planning to upstream a driver consuming this interface?
>> If so, I propose to add this patch to the submission of the driver. Sounds good?
>>
>> Regards,
>> Matthias
>>
>>>
>>>
>>> Eason Yen (1):
>>>   soc: mediatek: add SMC fid table for SIP interface
>>>
>>>  include/linux/soc/mediatek/mtk_sip_svc.h |   28 ++++++++++++++++++++++++++++
>>>  1 file changed, 28 insertions(+)
>>>  create mode 100644 include/linux/soc/mediatek/mtk_sip_svc.h
>>>
> 

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek