* [PATCH] soc: mediatek: mtk-svs: Explicitly include bitfield header
@ 2022-08-29 20:44 Nícolas F. R. A. Prado
2022-08-30 7:20 ` AngeloGioacchino Del Regno
2022-08-30 7:37 ` Matthias Brugger
0 siblings, 2 replies; 5+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-08-29 20:44 UTC (permalink / raw)
To: Matthias Brugger
Cc: AngeloGioacchino Del Regno, kernel, Nícolas F. R. A. Prado,
linux-arm-kernel, linux-kernel, linux-mediatek
Commit a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros
where possible") introduced the use of FIELD_GET and FIELD_PREP macros,
which are defined in the bitfield header. Add an explicit include for it
so we're sure to have the symbols defined independently of the config.
Fixes: a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros where possible")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
drivers/soc/mediatek/mtk-svs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index 64dba9f830f3..f67f3e971653 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -3,6 +3,7 @@
* Copyright (C) 2022 MediaTek Inc.
*/
+#include <linux/bitfield.h>
#include <linux/bits.h>
#include <linux/clk.h>
#include <linux/completion.h>
--
2.37.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] soc: mediatek: mtk-svs: Explicitly include bitfield header
2022-08-29 20:44 [PATCH] soc: mediatek: mtk-svs: Explicitly include bitfield header Nícolas F. R. A. Prado
@ 2022-08-30 7:20 ` AngeloGioacchino Del Regno
2022-08-30 7:37 ` Matthias Brugger
1 sibling, 0 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-08-30 7:20 UTC (permalink / raw)
To: Nícolas F. R. A. Prado, Matthias Brugger
Cc: kernel, linux-arm-kernel, linux-kernel, linux-mediatek
Il 29/08/22 22:44, Nícolas F. R. A. Prado ha scritto:
> Commit a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros
> where possible") introduced the use of FIELD_GET and FIELD_PREP macros,
> which are defined in the bitfield header. Add an explicit include for it
> so we're sure to have the symbols defined independently of the config.
>
> Fixes: a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros where possible")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] soc: mediatek: mtk-svs: Explicitly include bitfield header
2022-08-29 20:44 [PATCH] soc: mediatek: mtk-svs: Explicitly include bitfield header Nícolas F. R. A. Prado
2022-08-30 7:20 ` AngeloGioacchino Del Regno
@ 2022-08-30 7:37 ` Matthias Brugger
2022-08-30 8:06 ` AngeloGioacchino Del Regno
1 sibling, 1 reply; 5+ messages in thread
From: Matthias Brugger @ 2022-08-30 7:37 UTC (permalink / raw)
To: Nícolas F. R. A. Prado
Cc: AngeloGioacchino Del Regno, kernel, linux-arm-kernel,
linux-kernel, linux-mediatek
On 29/08/2022 22:44, Nícolas F. R. A. Prado wrote:
> Commit a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros
> where possible") introduced the use of FIELD_GET and FIELD_PREP macros,
> which are defined in the bitfield header. Add an explicit include for it
> so we're sure to have the symbols defined independently of the config.
>
> Fixes: a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros where possible")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
>
> drivers/soc/mediatek/mtk-svs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index 64dba9f830f3..f67f3e971653 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -3,6 +3,7 @@
> * Copyright (C) 2022 MediaTek Inc.
> */
>
> +#include <linux/bitfield.h>
> #include <linux/bits.h>
What do we need the bits.h for?
Regards,
Matthias
> #include <linux/clk.h>
> #include <linux/completion.h>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] soc: mediatek: mtk-svs: Explicitly include bitfield header
2022-08-30 7:37 ` Matthias Brugger
@ 2022-08-30 8:06 ` AngeloGioacchino Del Regno
2022-08-30 8:56 ` Matthias Brugger
0 siblings, 1 reply; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-08-30 8:06 UTC (permalink / raw)
To: Matthias Brugger, Nícolas F. R. A. Prado
Cc: kernel, linux-arm-kernel, linux-kernel, linux-mediatek
Il 30/08/22 09:37, Matthias Brugger ha scritto:
>
>
> On 29/08/2022 22:44, Nícolas F. R. A. Prado wrote:
>> Commit a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros
>> where possible") introduced the use of FIELD_GET and FIELD_PREP macros,
>> which are defined in the bitfield header. Add an explicit include for it
>> so we're sure to have the symbols defined independently of the config.
>>
>> Fixes: a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros where
>> possible")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>>
>> ---
>>
>> drivers/soc/mediatek/mtk-svs.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
>> index 64dba9f830f3..f67f3e971653 100644
>> --- a/drivers/soc/mediatek/mtk-svs.c
>> +++ b/drivers/soc/mediatek/mtk-svs.c
>> @@ -3,6 +3,7 @@
>> * Copyright (C) 2022 MediaTek Inc.
>> */
>> +#include <linux/bitfield.h>
>> #include <linux/bits.h>
>
> What do we need the bits.h for?
>
bits.h has the definition for GENMASK(h, l), used in this file :-)
Cheers,
Angelo
> Regards,
> Matthias
>
>> #include <linux/clk.h>
>> #include <linux/completion.h>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] soc: mediatek: mtk-svs: Explicitly include bitfield header
2022-08-30 8:06 ` AngeloGioacchino Del Regno
@ 2022-08-30 8:56 ` Matthias Brugger
0 siblings, 0 replies; 5+ messages in thread
From: Matthias Brugger @ 2022-08-30 8:56 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, Nícolas F. R. A. Prado
Cc: kernel, linux-arm-kernel, linux-kernel, linux-mediatek
On 30/08/2022 10:06, AngeloGioacchino Del Regno wrote:
> Il 30/08/22 09:37, Matthias Brugger ha scritto:
>>
>>
>> On 29/08/2022 22:44, Nícolas F. R. A. Prado wrote:
>>> Commit a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros
>>> where possible") introduced the use of FIELD_GET and FIELD_PREP macros,
>>> which are defined in the bitfield header. Add an explicit include for it
>>> so we're sure to have the symbols defined independently of the config.
>>>
>>> Fixes: a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros
>>> where possible")
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>>>
>>> ---
>>>
>>> drivers/soc/mediatek/mtk-svs.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
>>> index 64dba9f830f3..f67f3e971653 100644
>>> --- a/drivers/soc/mediatek/mtk-svs.c
>>> +++ b/drivers/soc/mediatek/mtk-svs.c
>>> @@ -3,6 +3,7 @@
>>> * Copyright (C) 2022 MediaTek Inc.
>>> */
>>> +#include <linux/bitfield.h>
>>> #include <linux/bits.h>
>>
>> What do we need the bits.h for?
>>
>
> bits.h has the definition for GENMASK(h, l), used in this file :-)
>
Right, seems that some other include includes bits.h as well, as compilation
does not break. But we probably don't want to rely on that for the future.
Applied thanks.
> Cheers,
> Angelo
>
>> Regards,
>> Matthias
>>
>>> #include <linux/clk.h>
>>> #include <linux/completion.h>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-30 8:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29 20:44 [PATCH] soc: mediatek: mtk-svs: Explicitly include bitfield header Nícolas F. R. A. Prado
2022-08-30 7:20 ` AngeloGioacchino Del Regno
2022-08-30 7:37 ` Matthias Brugger
2022-08-30 8:06 ` AngeloGioacchino Del Regno
2022-08-30 8:56 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).