From: Marc Zyngier <maz@kernel.org>
To: Markus Schneider-Pargmann <msp@baylibre.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] irqchip: mtk-sysirq: Skip setting irq-wake
Date: Thu, 08 Jul 2021 09:16:21 +0100 [thread overview]
Message-ID: <87h7h52pbe.wl-maz@kernel.org> (raw)
In-Reply-To: <20210707124932.szw7zud63fl7xn6i@blmsp>
On Wed, 07 Jul 2021 13:49:32 +0100,
Markus Schneider-Pargmann <msp@baylibre.com> wrote:
>
> Hi Marc,
>
> On Wed, Jul 07, 2021 at 11:19:19AM +0100, Marc Zyngier wrote:
> > Hi Markus,
> >
> > On Wed, 07 Jul 2021 07:20:04 +0100,
> > Markus Schneider-Pargmann <msp@baylibre.com> wrote:
> > >
> > > mtk-sysirq doesn't require specific logic to work with wakeup IRQs. To
> > > allow registered IRQs to be used as a wakeup-source, add the flag
> > > IRQCHIP_SKIP_SET_WAKE.
> > >
> > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> > > ---
> > > drivers/irqchip/irq-mtk-sysirq.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c
> > > index 6ff98b87e5c0..586e52d5442b 100644
> > > --- a/drivers/irqchip/irq-mtk-sysirq.c
> > > +++ b/drivers/irqchip/irq-mtk-sysirq.c
> > > @@ -65,6 +65,7 @@ static struct irq_chip mtk_sysirq_chip = {
> > > .irq_set_type = mtk_sysirq_set_type,
> > > .irq_retrigger = irq_chip_retrigger_hierarchy,
> > > .irq_set_affinity = irq_chip_set_affinity_parent,
> > > + .flags = IRQCHIP_SKIP_SET_WAKE,
> > > };
> > >
> > > static int mtk_sysirq_domain_translate(struct irq_domain *d,
> >
> > Is this a fix? If so, please provide a Fixes: tag matching the commit
> > it addresses. Add a Cc stable if this requires backporting.
>
> At least from my point of view I would like to prepare the mtk-sysirq
> for powermanagement stuff, so not a fix. There may be some components
> trying to use this already but I would consider this more of a feature
> as it has probably never worked before.
Fair enough. I'll keep that for 5.15 then.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
prev parent reply other threads:[~2021-07-08 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 6:20 [PATCH] irqchip: mtk-sysirq: Skip setting irq-wake Markus Schneider-Pargmann
2021-07-07 10:19 ` Marc Zyngier
2021-07-07 12:49 ` Markus Schneider-Pargmann
2021-07-08 8:16 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7h52pbe.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=msp@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).