Re: [PATCH] irqchip: mtk-sysirq: Skip setting irq-wake

From: Marc Zyngier <maz@kernel.org>
To: Markus Schneider-Pargmann <msp@baylibre.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] irqchip: mtk-sysirq: Skip setting irq-wake
Date: Wed, 07 Jul 2021 11:19:19 +0100	[thread overview]
Message-ID: <87sg0q77fc.wl-maz@kernel.org> (raw)
In-Reply-To: <20210707062004.782787-1-msp@baylibre.com>

Hi Markus,

On Wed, 07 Jul 2021 07:20:04 +0100,
Markus Schneider-Pargmann <msp@baylibre.com> wrote:
> 
> mtk-sysirq doesn't require specific logic to work with wakeup IRQs. To
> allow registered IRQs to be used as a wakeup-source, add the flag
> IRQCHIP_SKIP_SET_WAKE.
> 
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> ---
>  drivers/irqchip/irq-mtk-sysirq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c
> index 6ff98b87e5c0..586e52d5442b 100644
> --- a/drivers/irqchip/irq-mtk-sysirq.c
> +++ b/drivers/irqchip/irq-mtk-sysirq.c
> @@ -65,6 +65,7 @@ static struct irq_chip mtk_sysirq_chip = {
>  	.irq_set_type		= mtk_sysirq_set_type,
>  	.irq_retrigger		= irq_chip_retrigger_hierarchy,
>  	.irq_set_affinity	= irq_chip_set_affinity_parent,
> +	.flags			= IRQCHIP_SKIP_SET_WAKE,
>  };
>  
>  static int mtk_sysirq_domain_translate(struct irq_domain *d,

Is this a fix? If so, please provide a Fixes: tag matching the commit
it addresses. Add a Cc stable if this requires backporting.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek