* [PATCH -next] soc: mediatek: Missing platform_device_unregister() on error in mtk_mmsys_probe()
@ 2020-05-06 14:13 Wei Yongjun
2020-05-06 17:24 ` Enric Balletbo i Serra
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2020-05-06 14:13 UTC (permalink / raw)
To: Matthias Brugger, Enric Balletbo i Serra
Cc: linux-mediatek, kernel-janitors, Wei Yongjun, linux-kernel,
linux-arm-kernel
Add the missing platform_device_unregister() before return
from mtk_mmsys_probe() in the error handling case.
Fixes: 667c769246b0 ("soc / drm: mediatek: Fix mediatek-drm device probing")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/soc/mediatek/mtk-mmsys.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
index 05e322c9c301..05ce4cb464b0 100644
--- a/drivers/soc/mediatek/mtk-mmsys.c
+++ b/drivers/soc/mediatek/mtk-mmsys.c
@@ -312,8 +312,10 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
drm = platform_device_register_data(&pdev->dev, "mediatek-drm",
PLATFORM_DEVID_AUTO, NULL, 0);
- if (IS_ERR(drm))
+ if (IS_ERR(drm)) {
+ platform_device_unregister(clks);
return PTR_ERR(drm);
+ }
return 0;
}
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] soc: mediatek: Missing platform_device_unregister() on error in mtk_mmsys_probe()
2020-05-06 14:13 [PATCH -next] soc: mediatek: Missing platform_device_unregister() on error in mtk_mmsys_probe() Wei Yongjun
@ 2020-05-06 17:24 ` Enric Balletbo i Serra
2020-05-15 14:52 ` Matthias Brugger
0 siblings, 1 reply; 3+ messages in thread
From: Enric Balletbo i Serra @ 2020-05-06 17:24 UTC (permalink / raw)
To: Wei Yongjun, Matthias Brugger
Cc: kernel-janitors, linux-mediatek, linux-kernel, linux-arm-kernel
Hi Wei,
Thank you for your patch.
On 6/5/20 16:13, Wei Yongjun wrote:
> Add the missing platform_device_unregister() before return
> from mtk_mmsys_probe() in the error handling case.
>
> Fixes: 667c769246b0 ("soc / drm: mediatek: Fix mediatek-drm device probing")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> drivers/soc/mediatek/mtk-mmsys.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index 05e322c9c301..05ce4cb464b0 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -312,8 +312,10 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
>
> drm = platform_device_register_data(&pdev->dev, "mediatek-drm",
> PLATFORM_DEVID_AUTO, NULL, 0);
> - if (IS_ERR(drm))
> + if (IS_ERR(drm)) {
> + platform_device_unregister(clks);
> return PTR_ERR(drm);
> + }
>
> return 0;
> }
>
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] soc: mediatek: Missing platform_device_unregister() on error in mtk_mmsys_probe()
2020-05-06 17:24 ` Enric Balletbo i Serra
@ 2020-05-15 14:52 ` Matthias Brugger
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2020-05-15 14:52 UTC (permalink / raw)
To: Enric Balletbo i Serra, Wei Yongjun
Cc: kernel-janitors, linux-mediatek, linux-kernel, linux-arm-kernel
On 06/05/2020 19:24, Enric Balletbo i Serra wrote:
> Hi Wei,
>
> Thank you for your patch.
>
> On 6/5/20 16:13, Wei Yongjun wrote:
>> Add the missing platform_device_unregister() before return
>> from mtk_mmsys_probe() in the error handling case.
>>
>> Fixes: 667c769246b0 ("soc / drm: mediatek: Fix mediatek-drm device probing")
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>
applied to v5.7-next/soc
Thanks!
>> ---
>> drivers/soc/mediatek/mtk-mmsys.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
>> index 05e322c9c301..05ce4cb464b0 100644
>> --- a/drivers/soc/mediatek/mtk-mmsys.c
>> +++ b/drivers/soc/mediatek/mtk-mmsys.c
>> @@ -312,8 +312,10 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
>>
>> drm = platform_device_register_data(&pdev->dev, "mediatek-drm",
>> PLATFORM_DEVID_AUTO, NULL, 0);
>> - if (IS_ERR(drm))
>> + if (IS_ERR(drm)) {
>> + platform_device_unregister(clks);
>> return PTR_ERR(drm);
>> + }
>>
>> return 0;
>> }
>>
>>
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-15 14:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06 14:13 [PATCH -next] soc: mediatek: Missing platform_device_unregister() on error in mtk_mmsys_probe() Wei Yongjun
2020-05-06 17:24 ` Enric Balletbo i Serra
2020-05-15 14:52 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).