* [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path
@ 2023-09-14 13:10 Jani Nikula
2023-09-14 13:38 ` Guillaume Ranquet
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Jani Nikula @ 2023-09-14 13:10 UTC (permalink / raw)
To: dri-devel
Cc: jani.nikula, Markus Schneider-Pargmann, Guillaume Ranquet,
Bo-Chen Chen, CK Hu, AngeloGioacchino Del Regno, Dmitry Osipenko,
Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, linux-mediatek,
linux-kernel, linux-arm-kernel, stable
Setting new_edid to NULL leaks the buffer.
Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver")
Cc: Markus Schneider-Pargmann <msp@baylibre.com>
Cc: Guillaume Ranquet <granquet@baylibre.com>
Cc: Bo-Chen Chen <rex-bc.chen@mediatek.com>
Cc: CK Hu <ck.hu@mediatek.com>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: <stable@vger.kernel.org> # v6.1+
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
UNTESTED
---
drivers/gpu/drm/mediatek/mtk_dp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c
index 2cb47f663756..8fc6eff68e30 100644
--- a/drivers/gpu/drm/mediatek/mtk_dp.c
+++ b/drivers/gpu/drm/mediatek/mtk_dp.c
@@ -2049,6 +2049,7 @@ static struct edid *mtk_dp_get_edid(struct drm_bridge *bridge,
*/
if (mtk_dp_parse_capabilities(mtk_dp)) {
drm_err(mtk_dp->drm_dev, "Can't parse capabilities\n");
+ kfree(new_edid);
new_edid = NULL;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path
2023-09-14 13:10 [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path Jani Nikula
@ 2023-09-14 13:38 ` Guillaume Ranquet
2023-09-14 15:53 ` [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection Jani Nikula
2023-09-24 14:40 ` [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path Chun-Kuang Hu
2 siblings, 0 replies; 9+ messages in thread
From: Guillaume Ranquet @ 2023-09-14 13:38 UTC (permalink / raw)
To: Jani Nikula, dri-devel
Cc: Markus Schneider-Pargmann, Guillaume Ranquet, Bo-Chen Chen,
CK Hu, AngeloGioacchino Del Regno, Dmitry Osipenko,
Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, linux-mediatek,
linux-kernel, linux-arm-kernel, stable
On Thu, 14 Sep 2023 15:10, Jani Nikula <jani.nikula@intel.com> wrote:
>Setting new_edid to NULL leaks the buffer.
>
>Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver")
>Cc: Markus Schneider-Pargmann <msp@baylibre.com>
>Cc: Guillaume Ranquet <granquet@baylibre.com>
>Cc: Bo-Chen Chen <rex-bc.chen@mediatek.com>
>Cc: CK Hu <ck.hu@mediatek.com>
>Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>Cc: Philipp Zabel <p.zabel@pengutronix.de>
>Cc: Matthias Brugger <matthias.bgg@gmail.com>
>Cc: dri-devel@lists.freedesktop.org
>Cc: linux-mediatek@lists.infradead.org
>Cc: linux-kernel@vger.kernel.org
>Cc: linux-arm-kernel@lists.infradead.org
>Cc: <stable@vger.kernel.org> # v6.1+
>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
Reviewed-by: Guillaume Ranquet <granquet@baylibre.com>
>---
>
>UNTESTED
>---
> drivers/gpu/drm/mediatek/mtk_dp.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c
>index 2cb47f663756..8fc6eff68e30 100644
>--- a/drivers/gpu/drm/mediatek/mtk_dp.c
>+++ b/drivers/gpu/drm/mediatek/mtk_dp.c
>@@ -2049,6 +2049,7 @@ static struct edid *mtk_dp_get_edid(struct drm_bridge *bridge,
> */
> if (mtk_dp_parse_capabilities(mtk_dp)) {
> drm_err(mtk_dp->drm_dev, "Can't parse capabilities\n");
>+ kfree(new_edid);
> new_edid = NULL;
> }
>
>--
>2.39.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection
2023-09-14 13:10 [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path Jani Nikula
2023-09-14 13:38 ` Guillaume Ranquet
@ 2023-09-14 15:53 ` Jani Nikula
2023-09-15 5:28 ` Chen-Yu Tsai
2023-09-24 14:40 ` [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path Chun-Kuang Hu
2 siblings, 1 reply; 9+ messages in thread
From: Jani Nikula @ 2023-09-14 15:53 UTC (permalink / raw)
To: Jani Nikula, dri-devel
Cc: Chun-Kuang Hu, Guillaume Ranquet, linux-kernel, stable,
Markus Schneider-Pargmann, Matthias Brugger, Dmitry Osipenko,
Bo-Chen Chen, linux-mediatek, linux-arm-kernel,
AngeloGioacchino Del Regno, Philipp Zabel
The sads returned by drm_edid_to_sad() needs to be freed.
Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195")
Cc: Guillaume Ranquet <granquet@baylibre.com>
Cc: Bo-Chen Chen <rex-bc.chen@mediatek.com>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: <stable@vger.kernel.org> # v6.1+
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
Found another one. UNTESTED.
---
drivers/gpu/drm/mediatek/mtk_dp.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c
index 8fc6eff68e30..0e285df6577e 100644
--- a/drivers/gpu/drm/mediatek/mtk_dp.c
+++ b/drivers/gpu/drm/mediatek/mtk_dp.c
@@ -2034,7 +2034,6 @@ static struct edid *mtk_dp_get_edid(struct drm_bridge *bridge,
bool enabled = mtk_dp->enabled;
struct edid *new_edid = NULL;
struct mtk_dp_audio_cfg *audio_caps = &mtk_dp->info.audio_cur_cfg;
- struct cea_sad *sads;
if (!enabled) {
drm_atomic_bridge_chain_pre_enable(bridge, connector->state->state);
@@ -2054,7 +2053,11 @@ static struct edid *mtk_dp_get_edid(struct drm_bridge *bridge,
}
if (new_edid) {
+ struct cea_sad *sads;
+
audio_caps->sad_count = drm_edid_to_sad(new_edid, &sads);
+ kfree(sads);
+
audio_caps->detect_monitor = drm_detect_monitor_audio(new_edid);
}
--
2.39.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection
2023-09-14 15:53 ` [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection Jani Nikula
@ 2023-09-15 5:28 ` Chen-Yu Tsai
2023-09-19 11:02 ` Jani Nikula
0 siblings, 1 reply; 9+ messages in thread
From: Chen-Yu Tsai @ 2023-09-15 5:28 UTC (permalink / raw)
To: Jani Nikula
Cc: dri-devel, Chun-Kuang Hu, Guillaume Ranquet, linux-kernel,
stable, Markus Schneider-Pargmann, Bo-Chen Chen, linux-mediatek,
Dmitry Osipenko, Matthias Brugger, linux-arm-kernel,
AngeloGioacchino Del Regno
On Thu, Sep 14, 2023 at 11:53 PM Jani Nikula <jani.nikula@intel.com> wrote:
>
> The sads returned by drm_edid_to_sad() needs to be freed.
>
> Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195")
> Cc: Guillaume Ranquet <granquet@baylibre.com>
> Cc: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-mediatek@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: <stable@vger.kernel.org> # v6.1+
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Looks correct to me.
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection
2023-09-15 5:28 ` Chen-Yu Tsai
@ 2023-09-19 11:02 ` Jani Nikula
2023-09-19 11:04 ` Chen-Yu Tsai
0 siblings, 1 reply; 9+ messages in thread
From: Jani Nikula @ 2023-09-19 11:02 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: dri-devel, Chun-Kuang Hu, Guillaume Ranquet, linux-kernel,
stable, Markus Schneider-Pargmann, Bo-Chen Chen, linux-mediatek,
Dmitry Osipenko, Matthias Brugger, linux-arm-kernel,
AngeloGioacchino Del Regno
On Fri, 15 Sep 2023, Chen-Yu Tsai <wenst@chromium.org> wrote:
> On Thu, Sep 14, 2023 at 11:53 PM Jani Nikula <jani.nikula@intel.com> wrote:
>>
>> The sads returned by drm_edid_to_sad() needs to be freed.
>>
>> Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195")
>> Cc: Guillaume Ranquet <granquet@baylibre.com>
>> Cc: Bo-Chen Chen <rex-bc.chen@mediatek.com>
>> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>> Cc: Philipp Zabel <p.zabel@pengutronix.de>
>> Cc: Matthias Brugger <matthias.bgg@gmail.com>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-mediatek@lists.infradead.org
>> Cc: linux-kernel@vger.kernel.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: <stable@vger.kernel.org> # v6.1+
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Looks correct to me.
>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Thanks for the reviews Chen-Yu and Guillaume. Will you push this to
drm-misc-next or shall I?
BR,
Jani.
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection
2023-09-19 11:02 ` Jani Nikula
@ 2023-09-19 11:04 ` Chen-Yu Tsai
2023-09-22 9:44 ` Jani Nikula
0 siblings, 1 reply; 9+ messages in thread
From: Chen-Yu Tsai @ 2023-09-19 11:04 UTC (permalink / raw)
To: Jani Nikula
Cc: dri-devel, Chun-Kuang Hu, Guillaume Ranquet, linux-kernel,
stable, Markus Schneider-Pargmann, Bo-Chen Chen, linux-mediatek,
Dmitry Osipenko, Matthias Brugger, linux-arm-kernel,
AngeloGioacchino Del Regno
On Tue, Sep 19, 2023 at 7:02 PM Jani Nikula <jani.nikula@intel.com> wrote:
>
> On Fri, 15 Sep 2023, Chen-Yu Tsai <wenst@chromium.org> wrote:
> > On Thu, Sep 14, 2023 at 11:53 PM Jani Nikula <jani.nikula@intel.com> wrote:
> >>
> >> The sads returned by drm_edid_to_sad() needs to be freed.
> >>
> >> Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195")
> >> Cc: Guillaume Ranquet <granquet@baylibre.com>
> >> Cc: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> >> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> >> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> >> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> >> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> >> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> >> Cc: dri-devel@lists.freedesktop.org
> >> Cc: linux-mediatek@lists.infradead.org
> >> Cc: linux-kernel@vger.kernel.org
> >> Cc: linux-arm-kernel@lists.infradead.org
> >> Cc: <stable@vger.kernel.org> # v6.1+
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >
> > Looks correct to me.
> >
> > Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
>
> Thanks for the reviews Chen-Yu and Guillaume. Will you push this to
> drm-misc-next or shall I?
Patches for the MediaTek drm driver go through their own separate tree,
maintained by CK (Chun-Kuang).
ChenYu
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection
2023-09-19 11:04 ` Chen-Yu Tsai
@ 2023-09-22 9:44 ` Jani Nikula
2023-09-24 14:27 ` Chun-Kuang Hu
0 siblings, 1 reply; 9+ messages in thread
From: Jani Nikula @ 2023-09-22 9:44 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: dri-devel, Chun-Kuang Hu, Guillaume Ranquet, linux-kernel,
stable, Markus Schneider-Pargmann, Bo-Chen Chen, linux-mediatek,
Dmitry Osipenko, Matthias Brugger, linux-arm-kernel,
AngeloGioacchino Del Regno
On Tue, 19 Sep 2023, Chen-Yu Tsai <wenst@chromium.org> wrote:
> On Tue, Sep 19, 2023 at 7:02 PM Jani Nikula <jani.nikula@intel.com> wrote:
>>
>> On Fri, 15 Sep 2023, Chen-Yu Tsai <wenst@chromium.org> wrote:
>> > On Thu, Sep 14, 2023 at 11:53 PM Jani Nikula <jani.nikula@intel.com> wrote:
>> >>
>> >> The sads returned by drm_edid_to_sad() needs to be freed.
>> >>
>> >> Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195")
>> >> Cc: Guillaume Ranquet <granquet@baylibre.com>
>> >> Cc: Bo-Chen Chen <rex-bc.chen@mediatek.com>
>> >> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> >> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> >> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>> >> Cc: Philipp Zabel <p.zabel@pengutronix.de>
>> >> Cc: Matthias Brugger <matthias.bgg@gmail.com>
>> >> Cc: dri-devel@lists.freedesktop.org
>> >> Cc: linux-mediatek@lists.infradead.org
>> >> Cc: linux-kernel@vger.kernel.org
>> >> Cc: linux-arm-kernel@lists.infradead.org
>> >> Cc: <stable@vger.kernel.org> # v6.1+
>> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> >
>> > Looks correct to me.
>> >
>> > Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
>>
>> Thanks for the reviews Chen-Yu and Guillaume. Will you push this to
>> drm-misc-next or shall I?
>
> Patches for the MediaTek drm driver go through their own separate tree,
> maintained by CK (Chun-Kuang).
Chun-Kuang, can you confirm picking up these two patches, please?
MAINTAINERS does not list a separate git repository for MediaTek drm
drivers, so I don't know where that would be. It should probably be
added to MAINTAINERS.
Thanks,
Jani.
>
> ChenYu
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection
2023-09-22 9:44 ` Jani Nikula
@ 2023-09-24 14:27 ` Chun-Kuang Hu
0 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2023-09-24 14:27 UTC (permalink / raw)
To: Jani Nikula
Cc: Chen-Yu Tsai, dri-devel, Chun-Kuang Hu, Guillaume Ranquet,
linux-kernel, stable, Markus Schneider-Pargmann, Bo-Chen Chen,
linux-mediatek, Dmitry Osipenko, Matthias Brugger,
linux-arm-kernel, AngeloGioacchino Del Regno
Hi, Jani:
Jani Nikula <jani.nikula@intel.com> 於 2023年9月22日 週五 下午5:44寫道:
>
> On Tue, 19 Sep 2023, Chen-Yu Tsai <wenst@chromium.org> wrote:
> > On Tue, Sep 19, 2023 at 7:02 PM Jani Nikula <jani.nikula@intel.com> wrote:
> >>
> >> On Fri, 15 Sep 2023, Chen-Yu Tsai <wenst@chromium.org> wrote:
> >> > On Thu, Sep 14, 2023 at 11:53 PM Jani Nikula <jani.nikula@intel.com> wrote:
> >> >>
> >> >> The sads returned by drm_edid_to_sad() needs to be freed.
> >> >>
> >> >> Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195")
> >> >> Cc: Guillaume Ranquet <granquet@baylibre.com>
> >> >> Cc: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> >> >> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> >> >> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> >> >> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> >> >> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> >> >> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> >> >> Cc: dri-devel@lists.freedesktop.org
> >> >> Cc: linux-mediatek@lists.infradead.org
> >> >> Cc: linux-kernel@vger.kernel.org
> >> >> Cc: linux-arm-kernel@lists.infradead.org
> >> >> Cc: <stable@vger.kernel.org> # v6.1+
> >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >> >
> >> > Looks correct to me.
> >> >
> >> > Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> >>
> >> Thanks for the reviews Chen-Yu and Guillaume. Will you push this to
> >> drm-misc-next or shall I?
> >
> > Patches for the MediaTek drm driver go through their own separate tree,
> > maintained by CK (Chun-Kuang).
>
> Chun-Kuang, can you confirm picking up these two patches, please?
>
> MAINTAINERS does not list a separate git repository for MediaTek drm
> drivers, so I don't know where that would be. It should probably be
> added to MAINTAINERS.
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
Chun-Kuang.
>
> Thanks,
> Jani.
>
> >
> > ChenYu
>
> --
> Jani Nikula, Intel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path
2023-09-14 13:10 [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path Jani Nikula
2023-09-14 13:38 ` Guillaume Ranquet
2023-09-14 15:53 ` [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection Jani Nikula
@ 2023-09-24 14:40 ` Chun-Kuang Hu
2 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2023-09-24 14:40 UTC (permalink / raw)
To: Jani Nikula
Cc: dri-devel, Markus Schneider-Pargmann, Guillaume Ranquet,
Bo-Chen Chen, CK Hu, AngeloGioacchino Del Regno, Dmitry Osipenko,
Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, linux-mediatek,
linux-kernel, linux-arm-kernel, stable
Hi, Jani:
Jani Nikula <jani.nikula@intel.com> 於 2023年9月14日 週四 下午9:13寫道:
>
> Setting new_edid to NULL leaks the buffer.
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
Chun-Kuang.
>
> Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver")
> Cc: Markus Schneider-Pargmann <msp@baylibre.com>
> Cc: Guillaume Ranquet <granquet@baylibre.com>
> Cc: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> Cc: CK Hu <ck.hu@mediatek.com>
> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-mediatek@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: <stable@vger.kernel.org> # v6.1+
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> ---
>
> UNTESTED
> ---
> drivers/gpu/drm/mediatek/mtk_dp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c
> index 2cb47f663756..8fc6eff68e30 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dp.c
> @@ -2049,6 +2049,7 @@ static struct edid *mtk_dp_get_edid(struct drm_bridge *bridge,
> */
> if (mtk_dp_parse_capabilities(mtk_dp)) {
> drm_err(mtk_dp->drm_dev, "Can't parse capabilities\n");
> + kfree(new_edid);
> new_edid = NULL;
> }
>
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-09-24 14:40 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-14 13:10 [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path Jani Nikula
2023-09-14 13:38 ` Guillaume Ranquet
2023-09-14 15:53 ` [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection Jani Nikula
2023-09-15 5:28 ` Chen-Yu Tsai
2023-09-19 11:02 ` Jani Nikula
2023-09-19 11:04 ` Chen-Yu Tsai
2023-09-22 9:44 ` Jani Nikula
2023-09-24 14:27 ` Chun-Kuang Hu
2023-09-24 14:40 ` [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path Chun-Kuang Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).