* [PATCH] ASoC: mediatek: mt8195: force COMMON_CLK dependency
@ 2021-09-20 10:01 Arnd Bergmann
2021-09-20 10:05 ` Geert Uytterhoeven
2021-09-20 12:35 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-09-20 10:01 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Matthias Brugger, Trevor Wu, Geert Uytterhoeven
Cc: Arnd Bergmann, Jiaxin Yu, Tzung-Bi Shih, alsa-devel,
linux-kernel, linux-arm-kernel, linux-mediatek
From: Arnd Bergmann <arnd@arndb.de>
Without CONFIG_COMMON_CLK, this driver fails to link:
ERROR: modpost: "clk_unregister_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
ERROR: modpost: "clk_register_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
Add the proper Kconfig dependency for compile testing.
Fixes: 6746cc858259 ("ASoC: mediatek: mt8195: add platform driver")
Fixes: 940ffa194547 ("ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/mediatek/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
index 5a2f4667d50b..268c1f74aa3e 100644
--- a/sound/soc/mediatek/Kconfig
+++ b/sound/soc/mediatek/Kconfig
@@ -187,7 +187,7 @@ config SND_SOC_MT8192_MT6359_RT1015_RT5682
config SND_SOC_MT8195
tristate "ASoC support for Mediatek MT8195 chip"
- depends on ARCH_MEDIATEK || COMPILE_TEST
+ depends on ARCH_MEDIATEK || (COMPILE_TEST && COMMON_CLK)
select SND_SOC_MEDIATEK
help
This adds ASoC platform driver support for Mediatek MT8195 chip
--
2.29.2
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: mediatek: mt8195: force COMMON_CLK dependency
2021-09-20 10:01 [PATCH] ASoC: mediatek: mt8195: force COMMON_CLK dependency Arnd Bergmann
@ 2021-09-20 10:05 ` Geert Uytterhoeven
2021-09-20 12:35 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-09-20 10:05 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Matthias Brugger, Trevor Wu, Geert Uytterhoeven, Arnd Bergmann,
Jiaxin Yu, Tzung-Bi Shih, ALSA Development Mailing List,
Linux Kernel Mailing List, Linux ARM, linux-mediatek
Hi Arnd,
Thanks for your patch!
On Mon, Sep 20, 2021 at 12:02 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without CONFIG_COMMON_CLK, this driver fails to link:
>
> ERROR: modpost: "clk_unregister_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
> ERROR: modpost: "clk_register_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
>
> Add the proper Kconfig dependency for compile testing.
>
> Fixes: 6746cc858259 ("ASoC: mediatek: mt8195: add platform driver")
> Fixes: 940ffa194547 ("ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK")
I don't think the second Fixes tag is appropriate, as that commit did not
relax the dependencies.
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> sound/soc/mediatek/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
> index 5a2f4667d50b..268c1f74aa3e 100644
> --- a/sound/soc/mediatek/Kconfig
> +++ b/sound/soc/mediatek/Kconfig
> @@ -187,7 +187,7 @@ config SND_SOC_MT8192_MT6359_RT1015_RT5682
>
> config SND_SOC_MT8195
> tristate "ASoC support for Mediatek MT8195 chip"
> - depends on ARCH_MEDIATEK || COMPILE_TEST
> + depends on ARCH_MEDIATEK || (COMPILE_TEST && COMMON_CLK)
Why not add a second line
depends on COMMON_CLK
to make a clear distinction between hard and soft dependencies?
> select SND_SOC_MEDIATEK
> help
> This adds ASoC platform driver support for Mediatek MT8195 chip
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: mediatek: mt8195: force COMMON_CLK dependency
2021-09-20 10:01 [PATCH] ASoC: mediatek: mt8195: force COMMON_CLK dependency Arnd Bergmann
2021-09-20 10:05 ` Geert Uytterhoeven
@ 2021-09-20 12:35 ` Mark Brown
2021-09-20 12:53 ` Arnd Bergmann
1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2021-09-20 12:35 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Matthias Brugger,
Trevor Wu, Geert Uytterhoeven, Arnd Bergmann, Jiaxin Yu,
Tzung-Bi Shih, alsa-devel, linux-kernel, linux-arm-kernel,
linux-mediatek
[-- Attachment #1.1: Type: text/plain, Size: 439 bytes --]
On Mon, Sep 20, 2021 at 12:01:58PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without CONFIG_COMMON_CLK, this driver fails to link:
>
> ERROR: modpost: "clk_unregister_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
> ERROR: modpost: "clk_register_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
This doesn't apply against current code, please check and resend.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: mediatek: mt8195: force COMMON_CLK dependency
2021-09-20 12:35 ` Mark Brown
@ 2021-09-20 12:53 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-09-20 12:53 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Matthias Brugger,
Trevor Wu, Geert Uytterhoeven, Arnd Bergmann, Jiaxin Yu,
Tzung-Bi Shih, ALSA Development Mailing List,
Linux Kernel Mailing List, Linux ARM,
moderated list:ARM/Mediatek SoC...
On Mon, Sep 20, 2021 at 2:35 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Mon, Sep 20, 2021 at 12:01:58PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Without CONFIG_COMMON_CLK, this driver fails to link:
> >
> > ERROR: modpost: "clk_unregister_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
> > ERROR: modpost: "clk_register_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
>
> This doesn't apply against current code, please check and resend.
It's already fixed the way that Geert suggested in your asoc/for-5.15,
sorry for the dup.
Arnd
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-20 12:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-20 10:01 [PATCH] ASoC: mediatek: mt8195: force COMMON_CLK dependency Arnd Bergmann
2021-09-20 10:05 ` Geert Uytterhoeven
2021-09-20 12:35 ` Mark Brown
2021-09-20 12:53 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).