* [PATCH] mmc: mediatek: depend on COMMON_CLK to fix compile tests
@ 2020-11-22 12:00 Krzysztof Kozlowski
2020-11-24 14:25 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-22 12:00 UTC (permalink / raw)
To: Ulf Hansson, Matthias Brugger, Baolin Wang, linux-mmc,
linux-kernel, linux-arm-kernel, linux-mediatek
Cc: kernel test robot, Krzysztof Kozlowski
The MFD_OMAP_USB_HOST uses Common Clock Framework thus it cannot be
built on platforms without it (e.g. compile test on MIPS with LANTIQ):
mips-linux-ld: drivers/mmc/host/mtk-sd.o: in function `msdc_ops_set_ios':
mtk-sd.c:(.text+0x2bbc): undefined reference to `clk_get_parent'
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/mmc/host/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 310e546e5898..bfe912ec8955 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -1023,6 +1023,7 @@ config MMC_BCM2835
config MMC_MTK
tristate "MediaTek SD/MMC Card Interface support"
depends on HAS_DMA
+ depends on COMMON_CLK
select REGULATOR
select MMC_CQHCI
help
--
2.25.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: mediatek: depend on COMMON_CLK to fix compile tests
2020-11-22 12:00 [PATCH] mmc: mediatek: depend on COMMON_CLK to fix compile tests Krzysztof Kozlowski
@ 2020-11-24 14:25 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2020-11-24 14:25 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: kernel test robot, Baolin Wang, linux-mmc,
Linux Kernel Mailing List,
moderated list:ARM/Mediatek SoC support, Matthias Brugger,
Linux ARM
On Sun, 22 Nov 2020 at 13:01, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The MFD_OMAP_USB_HOST uses Common Clock Framework thus it cannot be
> built on platforms without it (e.g. compile test on MIPS with LANTIQ):
>
> mips-linux-ld: drivers/mmc/host/mtk-sd.o: in function `msdc_ops_set_ios':
> mtk-sd.c:(.text+0x2bbc): undefined reference to `clk_get_parent'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 310e546e5898..bfe912ec8955 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1023,6 +1023,7 @@ config MMC_BCM2835
> config MMC_MTK
> tristate "MediaTek SD/MMC Card Interface support"
> depends on HAS_DMA
> + depends on COMMON_CLK
> select REGULATOR
> select MMC_CQHCI
> help
> --
> 2.25.1
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-24 14:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-22 12:00 [PATCH] mmc: mediatek: depend on COMMON_CLK to fix compile tests Krzysztof Kozlowski
2020-11-24 14:25 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).