Re: [PATCH 1/2] Bluetooth: btusb: Support public address configuration for MediaTek Chip.

From: Marcel Holtmann <marcel@holtmann.org>
To: "\"Mark-YW Chen (陳揚文)\"" <Mark-YW.Chen@mediatek.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
	sean.wang@mediatek.com, linux-bluetooth@vger.kernel.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	michaelfsun@google.com, mcchou@chromium.org
Subject: Re: [PATCH 1/2] Bluetooth: btusb: Support public address configuration for MediaTek Chip.
Date: Mon, 30 Aug 2021 17:03:59 +0200	[thread overview]
Message-ID: <CF258C9C-BB3C-4C10-88B0-F6F3A03303D5@holtmann.org> (raw)
In-Reply-To: <20210824154430.27689-1-mark-yw.chen@mediatek.com>

Hi Mark,

> The MediaTek chip support vendor specific HCI command(0xfc1a) to
> change the public address. Add hdev->set_bdaddr handler for MediaTek
> Chip.
> 
> Signed-off-by: mark-yw.chen <mark-yw.chen@mediatek.com>
> ---
> drivers/bluetooth/btusb.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 60d2fce59a71..41e7c9f28d82 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -2200,6 +2200,23 @@ struct btmtk_section_map {
> 	};
> } __packed;
> 
> +static int btusb_set_bdaddr_mtk(struct hci_dev *hdev, const bdaddr_t *bdaddr)
> +{
> +	struct sk_buff *skb;
> +	long ret;
> +
> +	skb = __hci_cmd_sync(hdev, 0xfc1a, sizeof(bdaddr), bdaddr, HCI_INIT_TIMEOUT);
> +	if (IS_ERR(skb)) {
> +		ret = PTR_ERR(skb);
> +		bt_dev_err(hdev, "changing Mediatek device address failed (%ld)",
> +			   ret);
> +		return ret;
> +	}
> +	kfree_skb(skb);
> +
> +	return 0;
> +}
> +

this is not a permanent change, correct? Meaning a power cycle will bring back the original BD_ADDR?

Regards

Marcel

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek