* [PATCH] mt76: replace consume_skb with dev_kfree_skb
@ 2020-04-07 20:25 sean.wang
2020-04-13 6:48 ` Arend Van Spriel
0 siblings, 1 reply; 2+ messages in thread
From: sean.wang @ 2020-04-07 20:25 UTC (permalink / raw)
To: nbd, lorenzo.bianconi
Cc: linux-mediatek, sean.wang, linux-wireless, ryder.lee
From: Sean Wang <sean.wang@mediatek.com>
consume_skb is identical to dev_kfree_skb, so that replace consume_skb with
dev_kfree_skb just to make consistent in whole mt76 driver.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c
index a30bb536fc8a..28567e2e4a65 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c
@@ -111,7 +111,7 @@ __mt76x02u_mcu_send_msg(struct mt76_dev *dev, struct sk_buff *skb,
if (wait_resp)
ret = mt76x02u_mcu_wait_resp(dev, seq);
- consume_skb(skb);
+ dev_kfree_skb(skb);
return ret;
}
--
2.25.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mt76: replace consume_skb with dev_kfree_skb
2020-04-07 20:25 [PATCH] mt76: replace consume_skb with dev_kfree_skb sean.wang
@ 2020-04-13 6:48 ` Arend Van Spriel
0 siblings, 0 replies; 2+ messages in thread
From: Arend Van Spriel @ 2020-04-13 6:48 UTC (permalink / raw)
To: sean.wang, nbd, lorenzo.bianconi
Cc: linux-mediatek, ryder.lee, linux-wireless
On 4/7/2020 10:25 PM, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> consume_skb is identical to dev_kfree_skb, so that replace consume_skb with
> dev_kfree_skb just to make consistent in whole mt76 driver.
Given that dev_kfree_skb is a define that maps it to consume_skb I would
say the use of consume_skb() is preferred. So maybe better to get
consistency in the driver by replacing dev_kfree_skb with consume_skb.
Regards,
Arend
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-13 6:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-07 20:25 [PATCH] mt76: replace consume_skb with dev_kfree_skb sean.wang
2020-04-13 6:48 ` Arend Van Spriel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).