From: Cezary Rojewski <cezary.rojewski@intel.com>
To: YC Hung <yc.hung@mediatek.com>, <broonie@kernel.org>,
<tiwai@suse.com>, <robh+dt@kernel.org>, <matthias.bgg@gmail.com>
Cc: <alsa-devel@alsa-project.org>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<daniel.baluta@nxp.com>, <trevor.wu@mediatek.com>,
<allen-kh.cheng@mediatek.com>
Subject: Re: [PATCH v2] dt-bindings: dsp: mediatek: add mt8195 dsp document
Date: Fri, 17 Dec 2021 12:05:03 +0100 [thread overview]
Message-ID: <cfb2d2f7-06fc-5930-4d24-b51e8b69c9bd@intel.com> (raw)
In-Reply-To: <20211217070835.31709-1-yc.hung@mediatek.com>
On 2021-12-17 8:08 AM, YC Hung wrote:
> From: "yc.hung" <yc.hung@mediatek.com>
>
> This patch adds mt8195 dsp document.
Hello,
While above statement is correct, the commit message would probably
benefit if expanded a bit. Don't get me wrong, I also find describing
rather obvious changes problematic.
Here, stating what 'mt8195 dsp' is and what's use, even in a single
sentence, would probably do the job.
Regards,
Czarek
> Signed-off-by: yc.hung <yc.hung@mediatek.com>
> ---
> Changes since v1:
> Rename yaml file name as mediatek,mt8195-dsp.yaml
> Refine descriptions for mailbox, memory-region and drop unused labels
> in examples.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-12-17 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 7:08 [PATCH v2] dt-bindings: dsp: mediatek: add mt8195 dsp document YC Hung
2021-12-17 11:05 ` Cezary Rojewski [this message]
2021-12-22 17:18 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfb2d2f7-06fc-5930-4d24-b51e8b69c9bd@intel.com \
--to=cezary.rojewski@intel.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
--cc=yc.hung@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).