* [PATCH v2] dt-bindings: dsp: mediatek: add mt8195 dsp document
@ 2021-12-17 7:08 YC Hung
2021-12-17 11:05 ` Cezary Rojewski
2021-12-22 17:18 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: YC Hung @ 2021-12-17 7:08 UTC (permalink / raw)
To: broonie, tiwai, robh+dt, matthias.bgg
Cc: yc.hung, alsa-devel, linux-mediatek, linux-arm-kernel,
linux-kernel, devicetree, daniel.baluta, trevor.wu,
allen-kh.cheng
From: "yc.hung" <yc.hung@mediatek.com>
This patch adds mt8195 dsp document.
Signed-off-by: yc.hung <yc.hung@mediatek.com>
---
Changes since v1:
Rename yaml file name as mediatek,mt8195-dsp.yaml
Refine descriptions for mailbox, memory-region and drop unused labels
in examples.
---
.../bindings/dsp/mediatek,mt8195-dsp.yaml | 117 ++++++++++++++++++
1 file changed, 117 insertions(+)
create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
new file mode 100644
index 000000000000..bde763191d86
--- /dev/null
+++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
@@ -0,0 +1,117 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/dsp/mediatek,mt8195-dsp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek mt8195 DSP core
+
+maintainers:
+ - YC Hung <yc.hung@mediatek.com>
+
+description: |
+ Some boards from mt8195 contain a DSP core used for
+ advanced pre- and post- audio processing.
+
+properties:
+ compatible:
+ const: mediatek,mt8195-dsp
+
+ reg:
+ items:
+ - description: Address and size of the DSP Cfg registers
+ - description: Address and size of the DSP SRAM
+
+ reg-names:
+ items:
+ - const: cfg
+ - const: sram
+
+ interrupts:
+ items:
+ - description: watchdog interrupt
+
+ interrupt-names:
+ items:
+ - const: wdt
+
+ clocks:
+ items:
+ - description: mux for audio dsp clock
+ - description: 26M clock
+ - description: mux for audio dsp local bus
+ - description: default audio dsp local bus clock source
+ - description: clock gate for audio dsp clock
+ - description: mux for audio dsp access external bus
+
+ clock-names:
+ items:
+ - const: adsp_sel
+ - const: clk26m_ck
+ - const: audio_local_bus
+ - const: mainpll_d7_d2
+ - const: scp_adsp_audiodsp
+ - const: audio_h
+
+ power-domains:
+ maxItems: 1
+
+ mboxes:
+ items:
+ - description: ipc reply between host and audio DSP.
+ - description: ipc reuqest between host and audio DSP.
+
+ mbox-names:
+ items:
+ - const: mbox0
+ - const: mbox1
+
+ memory-region:
+ items:
+ - description: dma buffer between host and DSP.
+ - description: DSP system memory.
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - interrupts
+ - interrupt-names
+ - clocks
+ - clock-names
+ - memory-region
+ - power-domains
+ - mbox-names
+ - mboxes
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ dsp@10803000 {
+ compatible = "mediatek,mt8195-dsp";
+ reg = <0x10803000 0x1000>,
+ <0x10840000 0x40000>;
+ reg-names = "cfg", "sram";
+ interrupts = <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH 0>;
+ interrupt-names = "wdt";
+ clocks = <&topckgen 10>, //CLK_TOP_ADSP
+ <&clk26m>,
+ <&topckgen 107>, //CLK_TOP_AUDIO_LOCAL_BUS
+ <&topckgen 136>, //CLK_TOP_MAINPLL_D7_D2
+ <&scp_adsp 0>, //CLK_SCP_ADSP_AUDIODSP
+ <&topckgen 34>; //CLK_TOP_AUDIO_H
+ clock-names = "adsp_sel",
+ "clk26m_ck",
+ "audio_local_bus",
+ "mainpll_d7_d2",
+ "scp_adsp_audiodsp",
+ "audio_h";
+ memory-region = <&adsp_dma_mem_reserved>,
+ <&adsp_mem_reserved>;
+ power-domains = <&spm 6>; //MT8195_POWER_DOMAIN_ADSP
+ mbox-names = "mbox0", "mbox1";
+ mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
+ };
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: dsp: mediatek: add mt8195 dsp document
2021-12-17 7:08 [PATCH v2] dt-bindings: dsp: mediatek: add mt8195 dsp document YC Hung
@ 2021-12-17 11:05 ` Cezary Rojewski
2021-12-22 17:18 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Cezary Rojewski @ 2021-12-17 11:05 UTC (permalink / raw)
To: YC Hung, broonie, tiwai, robh+dt, matthias.bgg
Cc: alsa-devel, linux-mediatek, linux-arm-kernel, linux-kernel,
devicetree, daniel.baluta, trevor.wu, allen-kh.cheng
On 2021-12-17 8:08 AM, YC Hung wrote:
> From: "yc.hung" <yc.hung@mediatek.com>
>
> This patch adds mt8195 dsp document.
Hello,
While above statement is correct, the commit message would probably
benefit if expanded a bit. Don't get me wrong, I also find describing
rather obvious changes problematic.
Here, stating what 'mt8195 dsp' is and what's use, even in a single
sentence, would probably do the job.
Regards,
Czarek
> Signed-off-by: yc.hung <yc.hung@mediatek.com>
> ---
> Changes since v1:
> Rename yaml file name as mediatek,mt8195-dsp.yaml
> Refine descriptions for mailbox, memory-region and drop unused labels
> in examples.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: dsp: mediatek: add mt8195 dsp document
2021-12-17 7:08 [PATCH v2] dt-bindings: dsp: mediatek: add mt8195 dsp document YC Hung
2021-12-17 11:05 ` Cezary Rojewski
@ 2021-12-22 17:18 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-12-22 17:18 UTC (permalink / raw)
To: YC Hung
Cc: broonie, tiwai, matthias.bgg, alsa-devel, linux-mediatek,
linux-arm-kernel, linux-kernel, devicetree, daniel.baluta,
trevor.wu, allen-kh.cheng
On Fri, Dec 17, 2021 at 03:08:36PM +0800, YC Hung wrote:
> From: "yc.hung" <yc.hung@mediatek.com>
Should be 'YC Hung'?
>
> This patch adds mt8195 dsp document.
>
> Signed-off-by: yc.hung <yc.hung@mediatek.com>
> ---
> Changes since v1:
> Rename yaml file name as mediatek,mt8195-dsp.yaml
> Refine descriptions for mailbox, memory-region and drop unused labels
> in examples.
> ---
> .../bindings/dsp/mediatek,mt8195-dsp.yaml | 117 ++++++++++++++++++
> 1 file changed, 117 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
>
> diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> new file mode 100644
> index 000000000000..bde763191d86
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> @@ -0,0 +1,117 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dsp/mediatek,mt8195-dsp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek mt8195 DSP core
> +
> +maintainers:
> + - YC Hung <yc.hung@mediatek.com>
> +
> +description: |
> + Some boards from mt8195 contain a DSP core used for
> + advanced pre- and post- audio processing.
> +
> +properties:
> + compatible:
> + const: mediatek,mt8195-dsp
> +
> + reg:
> + items:
> + - description: Address and size of the DSP Cfg registers
> + - description: Address and size of the DSP SRAM
> +
> + reg-names:
> + items:
> + - const: cfg
> + - const: sram
> +
> + interrupts:
> + items:
> + - description: watchdog interrupt
> +
> + interrupt-names:
> + items:
> + - const: wdt
> +
> + clocks:
> + items:
> + - description: mux for audio dsp clock
> + - description: 26M clock
> + - description: mux for audio dsp local bus
> + - description: default audio dsp local bus clock source
> + - description: clock gate for audio dsp clock
> + - description: mux for audio dsp access external bus
> +
> + clock-names:
> + items:
> + - const: adsp_sel
> + - const: clk26m_ck
> + - const: audio_local_bus
> + - const: mainpll_d7_d2
> + - const: scp_adsp_audiodsp
> + - const: audio_h
> +
> + power-domains:
> + maxItems: 1
> +
> + mboxes:
> + items:
> + - description: ipc reply between host and audio DSP.
> + - description: ipc reuqest between host and audio DSP.
> +
> + mbox-names:
> + items:
> + - const: mbox0
> + - const: mbox1
> +
> + memory-region:
> + items:
> + - description: dma buffer between host and DSP.
> + - description: DSP system memory.
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - interrupts
> + - interrupt-names
> + - clocks
> + - clock-names
> + - memory-region
> + - power-domains
> + - mbox-names
> + - mboxes
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + dsp@10803000 {
> + compatible = "mediatek,mt8195-dsp";
> + reg = <0x10803000 0x1000>,
> + <0x10840000 0x40000>;
> + reg-names = "cfg", "sram";
> + interrupts = <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH 0>;
> + interrupt-names = "wdt";
> + clocks = <&topckgen 10>, //CLK_TOP_ADSP
> + <&clk26m>,
> + <&topckgen 107>, //CLK_TOP_AUDIO_LOCAL_BUS
> + <&topckgen 136>, //CLK_TOP_MAINPLL_D7_D2
> + <&scp_adsp 0>, //CLK_SCP_ADSP_AUDIODSP
> + <&topckgen 34>; //CLK_TOP_AUDIO_H
> + clock-names = "adsp_sel",
> + "clk26m_ck",
> + "audio_local_bus",
> + "mainpll_d7_d2",
> + "scp_adsp_audiodsp",
> + "audio_h";
> + memory-region = <&adsp_dma_mem_reserved>,
> + <&adsp_mem_reserved>;
> + power-domains = <&spm 6>; //MT8195_POWER_DOMAIN_ADSP
> + mbox-names = "mbox0", "mbox1";
> + mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
> + };
> --
> 2.18.0
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-22 17:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-17 7:08 [PATCH v2] dt-bindings: dsp: mediatek: add mt8195 dsp document YC Hung
2021-12-17 11:05 ` Cezary Rojewski
2021-12-22 17:18 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).