archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <>
To: Chuhong Yuan <>,,,
Cc: Johan Hedberg <>,
	Marcel Holtmann <>,
	Sean Wang <>,,,
	Matthias Brugger <>
Subject: Re: [PATCH] Bluetooth: btmtkuart: Improve exception handling in btmtuart_probe()
Date: Thu, 28 May 2020 19:09:17 +0200	[thread overview]
Message-ID: <> (raw)

> btmtuart_probe() misses several function calls in its error paths,
> including hci_free_dev() and clk_disable_unprepare().
> Refactor the code and call correct undo functions to fix the error
> paths.

How do you think about a wording variant like the following?

   Change description:
   Calls of the functions “clk_disable_unprepare” and “hci_free_dev”
   were missing for the exception handling.
   Thus add the missed function calls together with corresponding
   jump targets.

Would you like to add the tag “Fixes” to the commit message?


Linux-mediatek mailing list

                 reply	other threads:[~2020-05-29 16:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).