linux-mediatek.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] Bluetooth: btmtkuart: Improve exception handling in btmtuart_probe()
@ 2020-05-28 17:09 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-05-28 17:09 UTC (permalink / raw)
  To: Chuhong Yuan, linux-arm-kernel, linux-bluetooth, linux-mediatek
  Cc: Johan Hedberg, Marcel Holtmann, Sean Wang, kernel-janitors,
	linux-kernel, Matthias Brugger

> btmtuart_probe() misses several function calls in its error paths,
> including hci_free_dev() and clk_disable_unprepare().
> Refactor the code and call correct undo functions to fix the error
> paths.

How do you think about a wording variant like the following?

   Change description:
   Calls of the functions “clk_disable_unprepare” and “hci_free_dev”
   were missing for the exception handling.
   Thus add the missed function calls together with corresponding
   jump targets.


Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-29 16:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 17:09 [PATCH] Bluetooth: btmtkuart: Improve exception handling in btmtuart_probe() Markus Elfring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).