From: "Langer, Thomas" <thomas.langer@intel.com>
To: Seb <sebtx452@gmail.com>, Hauke Mehrtens <hauke@hauke-m.de>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Subject: RE: [PATCH] mtd: maps: lantiq-flash: Check if the EBU endianness swap is enabled
Date: Wed, 25 Jan 2017 16:58:44 +0000 [thread overview]
Message-ID: <0DAF21CFE1B20740AE23D6AF6E54843F1E6F607C@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <CA+hF=GdKLEN2ue=Q7KpBp+W+bTnj5O_OAoPjuDOScga2efnjPA@mail.gmail.com>
> Hello,
Hi Sebastian
>
>
> > I would prefer to use a device tree option to activate this check and
> > only access LTQ_EBU_BUSCON0 when this property is set.
>
> If I understand correctly, I have to make something like this :
>
> ---
>
> bool mtd_addr_swap=true;
>
> if (!of_machine_is_compatible("lantiq,falcon") &&
> of_find_property(pdev->dev.of_node,
> "lantiq,ebu_swap_check", NULL))
> if (ltq_ebu_r32(LTQ_EBU_BUSCON0) & EBU_FLASH_ENDIAN_SWAP)
> mtd_addr_swap = false;
>
No, please avoid "of_machine_is_compatible" in drivers.
> ---
>
> And then set this property directly on my device-specific dts file ?
We should introduce specific compatible strings for this driver, which trigger this,
e.g. "lantiq,nor-vr9" or "lantiq,nor-ar10" (or better using family names "xrx200" and "xrx300")
Regards,
Thomas
next prev parent reply other threads:[~2017-01-25 16:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 9:33 [PATCH] mtd: maps: lantiq-flash: Check if the EBU endianness swap is enabled Sebastien Decourriere
2017-01-24 17:03 ` Ralf Baechle
2017-01-24 21:32 ` Hauke Mehrtens
2017-01-25 9:04 ` Seb
2017-01-25 16:58 ` Langer, Thomas [this message]
2017-01-26 11:02 ` Seb
2017-01-26 16:01 ` Langer, Thomas
-- strict thread matches above, loose matches on Subject: below --
2017-01-19 10:06 Sebastien Decourriere
2017-01-19 23:50 ` Langer, Thomas
2017-01-18 12:10 Sebastien Decourriere
2017-01-18 12:38 ` John Crispin
2017-01-18 13:48 ` Seb
2017-01-18 13:51 ` John Crispin
2017-01-18 17:12 ` Seb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0DAF21CFE1B20740AE23D6AF6E54843F1E6F607C@IRSMSX101.ger.corp.intel.com \
--to=thomas.langer@intel.com \
--cc=hauke@hauke-m.de \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=sebtx452@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).