linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Crispin <john@phrozen.org>
To: Seb <sebtx452@gmail.com>
Cc: linux-mtd@lists.infradead.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] mtd: maps: lantiq-flash: Check if the EBU endianness swap is enabled
Date: Wed, 18 Jan 2017 14:51:25 +0100	[thread overview]
Message-ID: <845374ff-62b0-983b-b399-4965421a9066@phrozen.org> (raw)
In-Reply-To: <CA+hF=GeD0dhBUkR+wR_35pSXgSnU0kW6EfYWa9h2QrGOTReMnA@mail.gmail.com>



On 18/01/2017 14:48, Seb wrote:
> Hi John,
> 
> 
>>>
>>>       ltq_mtd->map->map_priv_1 = LTQ_NOR_PROBING;
>>
>> this line should be dropped
> 
> Yes, I noticed this mistake. I fixed it but forgotten to add thix fix
> to my commit -_-
> 
>>> +     /* We swap the addresses only if the EBU endianness swap is disabled */
>>> +     if (ltq_ebu_r32(LTQ_EBU_BUSCON0) & BIT(30))
>>
>> add a define for BIT(30) please and we should really check if this a
>> v1.2 or newer. if my memory is correct this was a silicon bug inside
>> v1.0 and v1.1
> 
> In my kernel (OpenWrt) boot log I have :
> 
> [    0.000000] Linux version 4.4.14 (qa@serveurQA) (gcc version 5.3.0
> (OpenWrt GCC 5.3.0 50020) ) #150 SMP Tue Jan 17 09:18:24 UTC 2017
> [    0.000000] SoC: xRX200 rev 1.2
> [    0.000000] bootconsole [early0] enabled
> [    0.000000] CPU0 revision is: 00019556 (MIPS 34Kc)
> 
> It would be better to ensure that the SoC version is >= 1.2 (as this
> bug was fixed in this version).

the bug is also fixed on the 300 and 500 series chips, so we would want
to check for that aswell.

	John




> You can get more informations in my OpenWrt pull request :
> 
> https://github.com/openwrt/openwrt/pull/321
> 
> 
> Regards,
> 
> Sebastien.
> 

  reply	other threads:[~2017-01-18 13:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18 12:10 Sebastien Decourriere
2017-01-18 12:38 ` John Crispin
2017-01-18 13:48   ` Seb
2017-01-18 13:51     ` John Crispin [this message]
2017-01-18 17:12       ` Seb
2017-01-19 10:06 Sebastien Decourriere
2017-01-19 23:50 ` Langer, Thomas
2017-01-20  9:33 Sebastien Decourriere
2017-01-24 17:03 ` Ralf Baechle
2017-01-24 21:32 ` Hauke Mehrtens
2017-01-25  9:04   ` Seb
2017-01-25 16:58     ` Langer, Thomas
2017-01-26 11:02       ` Seb
2017-01-26 16:01         ` Langer, Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=845374ff-62b0-983b-b399-4965421a9066@phrozen.org \
    --to=john@phrozen.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=sebtx452@gmail.com \
    --subject='Re: [PATCH] mtd: maps: lantiq-flash: Check if the EBU endianness swap is enabled' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).