From: Paul Cercueil <paul@crapouillou.net>
To: Paul Burton <paul.burton@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Vinod Koul <vkoul@kernel.org>, Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Lee Jones <lee.jones@linaro.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Sebastian Reichel <sre@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
od@zcrc.me, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-pm@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
alsa-devel@alsa-project.org, Artur Rojek <contact@artur-rojek.eu>
Subject: Re: [PATCH 02/11] MIPS: qi_lb60: Migrate to devicetree
Date: Thu, 25 Jul 2019 20:09:41 -0400 [thread overview]
Message-ID: <1564099781.1699.0@crapouillou.net> (raw)
In-Reply-To: <20190725234735.h7qmtt26qpkjw3n6@pburton-laptop>
Le jeu. 25 juil. 2019 à 19:47, Paul Burton <paul.burton@mips.com> a
écrit :
> Hi Paul,
>
> On Thu, Jul 25, 2019 at 06:02:06PM -0400, Paul Cercueil wrote:
>> Move all the platform data to devicetree.
>
> Nice! :)
>
>> The only bit dropped is the PWM beeper, which requires the PWM
>> driver
>> to be updated. I figured it's okay to remove it here since it's
>> really
>> a non-critical device, and it'll be re-introduced soon enough.
>
> OK, I can see that being a price worth paying. Though it's possible to
> include the binding at least for that in this series I'd be even
> happier. Actually I see we already have
>
> Documentation/devicetree/bindings/pwm/ingenic,jz47xx-pwm.txt
>
> in mainline - what needs to change with it?
The PWM driver will be updated to use the TCU clocks and the regmap
provided
by the TCU driver. The PWM node will be a sub-node of the TCU one.
Additionally, there is this[1] ongoing discussion about PWM which makes
me uneasy about how to write the binding. So I'd rather not rush it,
because once the devicetree is written, it's ABI.
[1]: https://lkml.org/lkml/2019/5/22/607
>> + spi {
>> + compatible = "spi-gpio";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + sck-gpios = <&gpc 23 GPIO_ACTIVE_HIGH>;
>> + mosi-gpios = <&gpc 22 GPIO_ACTIVE_HIGH>;
>> + cs-gpios = <&gpc 21 GPIO_ACTIVE_LOW>;
>> + num-chipselects = <1>;
>> +
>> + spi@0 {
>> + compatible = "ili8960";
>
> Should this be "ilitek,ili8960"?
>
> Is there a binding & driver for this submitted somewhere? If not then
> do
> we need this at all? It doesn't look like the existing platform data
> would actually lead to a driver being loaded so I'm wondering if we
> can
> just drop this until such a driver (or at least a documented DT
> binding)
> exists.
I can drop it. There is no driver for it, and I'm not even sure the LB60
has a ILI8960 in the first place.
> Thanks,
> Paul
next prev parent reply other threads:[~2019-07-26 0:10 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 22:02 [PATCH 00/11] JZ4740 SoC cleanup Paul Cercueil
2019-07-25 22:02 ` [PATCH 01/11] MIPS: DTS: jz4740: Add missing nodes Paul Cercueil
2019-07-30 17:43 ` Paul Burton
2019-07-25 22:02 ` [PATCH 02/11] MIPS: qi_lb60: Migrate to devicetree Paul Cercueil
2019-07-25 23:47 ` Paul Burton
2019-07-26 0:09 ` Paul Cercueil [this message]
2019-07-30 17:43 ` Paul Burton
2019-07-25 22:02 ` [PATCH 03/11] MIPS: configs: LB60: update defconfig Paul Cercueil
2019-07-30 17:43 ` Paul Burton
2019-07-25 22:02 ` [PATCH 04/11] ASoC: jz4740: Drop lb60 board code Paul Cercueil
2019-07-26 11:33 ` Mark Brown
2019-07-30 17:43 ` Paul Burton
2019-07-25 22:02 ` [PATCH 05/11] video/fbdev: Drop JZ4740 driver Paul Cercueil
2019-07-26 18:45 ` Sam Ravnborg
2019-07-30 17:43 ` Paul Burton
2019-07-25 22:02 ` [PATCH 06/11] dma: " Paul Cercueil
2019-07-29 6:44 ` Vinod Koul
2019-07-30 17:44 ` Paul Burton
2019-07-25 22:02 ` [PATCH 07/11] mtd: rawnand: Drop obsolete JZ4740 NAND driver Paul Cercueil
2019-07-26 18:57 ` Miquel Raynal
2019-07-30 17:44 ` Paul Burton
2019-07-25 22:02 ` [PATCH 08/11] power/supply: Drop obsolete JZ4740 driver Paul Cercueil
2019-07-29 11:03 ` Sebastian Reichel
2019-07-30 17:44 ` Paul Burton
2019-07-25 22:02 ` [PATCH 09/11] hwmon: " Paul Cercueil
2019-07-25 22:16 ` Guenter Roeck
2019-07-30 17:44 ` Paul Burton
2019-07-25 22:02 ` [PATCH 10/11] mfd: " Paul Cercueil
2019-08-12 8:16 ` Lee Jones
2019-08-13 8:44 ` Philippe Mathieu-Daudé
2019-08-13 10:01 ` Paul Cercueil
2019-08-13 10:30 ` Lee Jones
2019-07-25 22:02 ` [PATCH 11/11] MIPS: jz4740: Drop dead code Paul Cercueil
2019-07-30 17:44 ` Paul Burton
2019-07-26 18:46 ` [PATCH 00/11] JZ4740 SoC cleanup Sam Ravnborg
2019-07-27 3:19 ` Paul Cercueil
2019-07-29 11:23 ` Richard Weinberger
2019-07-29 17:05 ` Paul Cercueil
2019-07-29 18:08 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564099781.1699.0@crapouillou.net \
--to=paul@crapouillou.net \
--cc=alsa-devel@alsa-project.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=contact@artur-rojek.eu \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jdelvare@suse.com \
--cc=jhogan@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=od@zcrc.me \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).