linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Huacai Chen <chenhc@lemote.com>
To: Paul Burton <paul.burton@mips.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	James Hogan <jhogan@kernel.org>
Cc: linux-mips@linux-mips.org, linux-mips@vger.kernel.org,
	Fuxin Zhang <zhangfx@lemote.com>,
	Zhangjin Wu <wuzhangjin@gmail.com>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Huacai Chen <chenhuacai@gmail.com>,
	Huacai Chen <chenhc@lemote.com>
Subject: [PATCH] MIPS: Make sure ebase address is in KSEG0
Date: Thu, 21 Nov 2019 19:30:20 +0800	[thread overview]
Message-ID: <1574335820-15188-1-git-send-email-chenhc@lemote.com> (raw)

Dynamically allocated ebase address above 0x20000000 can be triggered
by some special physical memory layout, or just by a "big kernel + big
initrd + big swiotlb" configuration.

For MIPS32, ebase address above 0x20000000 is unusable, for MIPS64 it
is usable but this case is warned. However, this warning is useless
because it is unfixable in a specific system configuration. So we just
use CKSEG0 as a fallback.

Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
 arch/mips/kernel/traps.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
index 9d9b2a4..7393f33 100644
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -2306,10 +2306,15 @@ void __init trap_init(void)
 		 * EVA is special though as it allows segments to be rearranged
 		 * and to become uncached during cache error handling.
 		 */
-		if (!IS_ENABLED(CONFIG_EVA) && !WARN_ON(ebase_pa >= 0x20000000))
+		if (ebase_pa < 0x20000000)
 			ebase = CKSEG0ADDR(ebase_pa);
-		else
+		else if (IS_ENABLED(CONFIG_EVA))
 			ebase = (unsigned long)phys_to_virt(ebase_pa);
+		else {
+			memblock_free(ebase_pa, vec_size);
+			ebase = CKSEG0;
+			memblock_reserve(virt_to_phys((void *)ebase), vec_size);
+		}
 	}
 
 	if (cpu_has_mmips) {
-- 
2.7.0


             reply	other threads:[~2019-11-21 11:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-21 11:30 Huacai Chen [this message]
2019-11-22 18:47 ` Paul Burton
2019-11-23  5:08   ` Jiaxun Yang
2019-11-23  6:11     ` Jiaxun Yang
2019-11-24  4:00       ` Huacai Chen
2019-11-25 23:42         ` Paul Burton
2019-11-26  1:55           ` Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1574335820-15188-1-git-send-email-chenhc@lemote.com \
    --to=chenhc@lemote.com \
    --cc=chenhuacai@gmail.com \
    --cc=jhogan@kernel.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=paul.burton@mips.com \
    --cc=ralf@linux-mips.org \
    --cc=wuzhangjin@gmail.com \
    --cc=zhangfx@lemote.com \
    --subject='Re: [PATCH] MIPS: Make sure ebase address is in KSEG0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).