* [PATCH] MIPS: KVM: Fix build error caused by 'kvm_run' cleanup
@ 2020-07-19 10:23 Huacai Chen
2020-07-19 10:44 ` Jiaxun Yang
2020-07-27 13:53 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Huacai Chen @ 2020-07-19 10:23 UTC (permalink / raw)
To: Paolo Bonzini, Thomas Bogendoerfer, Aleksandar Markovic
Cc: kvm, linux-mips, Fuxin Zhang, Huacai Chen, Jiaxun Yang,
Huacai Chen, Tianjia Zhang
Commit c34b26b98caca48ec9ee9 ("KVM: MIPS: clean up redundant 'kvm_run'
parameters") remove the 'kvm_run' parameter in kvm_mips_complete_mmio_
load(), but forget to update all callers.
Fixes: c34b26b98caca48ec9ee9 ("KVM: MIPS: clean up redundant 'kvm_run' parameters")
Reported-by: kernel test robot <lkp@intel.com>
Cc: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
I have reviewed Tianjia's patch but hadn't found the bug, I'm very very
sorry for that.
arch/mips/kvm/emulate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
index d242300c..3b3f7b11 100644
--- a/arch/mips/kvm/emulate.c
+++ b/arch/mips/kvm/emulate.c
@@ -2128,7 +2128,7 @@ enum emulation_result kvm_mips_emulate_load(union mips_instruction inst,
run->mmio.phys_addr, run->mmio.len, run->mmio.data);
if (!r) {
- kvm_mips_complete_mmio_load(vcpu, run);
+ kvm_mips_complete_mmio_load(vcpu);
vcpu->mmio_needed = 0;
return EMULATE_DONE;
}
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] MIPS: KVM: Fix build error caused by 'kvm_run' cleanup
2020-07-19 10:23 [PATCH] MIPS: KVM: Fix build error caused by 'kvm_run' cleanup Huacai Chen
@ 2020-07-19 10:44 ` Jiaxun Yang
2020-07-27 13:53 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Jiaxun Yang @ 2020-07-19 10:44 UTC (permalink / raw)
To: Huacai Chen, Paolo Bonzini, Thomas Bogendoerfer, Aleksandar Markovic
Cc: kvm, linux-mips, Fuxin Zhang, Huacai Chen, Tianjia Zhang
在 2020/7/19 下午6:23, Huacai Chen 写道:
> Commit c34b26b98caca48ec9ee9 ("KVM: MIPS: clean up redundant 'kvm_run'
> parameters") remove the 'kvm_run' parameter in kvm_mips_complete_mmio_
> load(), but forget to update all callers.
>
> Fixes: c34b26b98caca48ec9ee9 ("KVM: MIPS: clean up redundant 'kvm_run' parameters")
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
> I have reviewed Tianjia's patch but hadn't found the bug, I'm very very
> sorry for that.
Oops, I suspected it as my local merge conflict at my initial test.
Sorry for the inconvinence.
- Jiaxun
>
> arch/mips/kvm/emulate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
> index d242300c..3b3f7b11 100644
> --- a/arch/mips/kvm/emulate.c
> +++ b/arch/mips/kvm/emulate.c
> @@ -2128,7 +2128,7 @@ enum emulation_result kvm_mips_emulate_load(union mips_instruction inst,
> run->mmio.phys_addr, run->mmio.len, run->mmio.data);
>
> if (!r) {
> - kvm_mips_complete_mmio_load(vcpu, run);
> + kvm_mips_complete_mmio_load(vcpu);
> vcpu->mmio_needed = 0;
> return EMULATE_DONE;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] MIPS: KVM: Fix build error caused by 'kvm_run' cleanup
2020-07-19 10:23 [PATCH] MIPS: KVM: Fix build error caused by 'kvm_run' cleanup Huacai Chen
2020-07-19 10:44 ` Jiaxun Yang
@ 2020-07-27 13:53 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2020-07-27 13:53 UTC (permalink / raw)
To: Huacai Chen, Thomas Bogendoerfer, Aleksandar Markovic
Cc: kvm, linux-mips, Fuxin Zhang, Huacai Chen, Jiaxun Yang, Tianjia Zhang
On 19/07/20 12:23, Huacai Chen wrote:
> Commit c34b26b98caca48ec9ee9 ("KVM: MIPS: clean up redundant 'kvm_run'
> parameters") remove the 'kvm_run' parameter in kvm_mips_complete_mmio_
> load(), but forget to update all callers.
>
> Fixes: c34b26b98caca48ec9ee9 ("KVM: MIPS: clean up redundant 'kvm_run' parameters")
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
> I have reviewed Tianjia's patch but hadn't found the bug, I'm very very
> sorry for that.
>
> arch/mips/kvm/emulate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
> index d242300c..3b3f7b11 100644
> --- a/arch/mips/kvm/emulate.c
> +++ b/arch/mips/kvm/emulate.c
> @@ -2128,7 +2128,7 @@ enum emulation_result kvm_mips_emulate_load(union mips_instruction inst,
> run->mmio.phys_addr, run->mmio.len, run->mmio.data);
>
> if (!r) {
> - kvm_mips_complete_mmio_load(vcpu, run);
> + kvm_mips_complete_mmio_load(vcpu);
> vcpu->mmio_needed = 0;
> return EMULATE_DONE;
> }
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-27 13:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-19 10:23 [PATCH] MIPS: KVM: Fix build error caused by 'kvm_run' cleanup Huacai Chen
2020-07-19 10:44 ` Jiaxun Yang
2020-07-27 13:53 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).