From: Paul Burton <paul.burton@imgtec.com>
To: Manuel Lauss <manuel.lauss@gmail.com>
Cc: Linux-MIPS <linux-mips@linux-mips.org>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: fix build with multiple PLATFORM strings
Date: Tue, 25 Oct 2016 15:29:12 +0100 [thread overview]
Message-ID: <1949974.ncqLyGp0zq@np-p-burton> (raw)
In-Reply-To: <20161025141205.244177-1-manuel.lauss@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]
On Tuesday, 25 October 2016 16:12:05 BST Manuel Lauss wrote:
> Commit cf2a5e0bb (MIPS: Support generating Flattened Image Trees (.itb))
> broke my alchemy devboard build, because it uses more than one entry
> in the PLATFORM variable:
>
> make -f kernel/linux/scripts/Makefile.build obj=arch/mips/boot/compressed \
> VMLINUX_LOAD_ADDRESS=[..] PLATFORM=alchemy/common/
> alchemy/devboards/ [..] vmlinuz make[2]: *** No rule to make target
> 'alchemy/devboards/'. Stop.
> make[1]: *** [arch/mips/Makefile:371: vmlinuz] Error 2
>
> Fix this by wrapping the platform-y expansion in quotes.
Hi Manuel,
This same fix was already submitted 8 days ago:
https://patchwork.linux-mips.org/patch/14405/
Thanks,
Paul
>
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> ---
> arch/mips/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index fbf40d3..1a6bac7 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -263,7 +263,7 @@ KBUILD_CPPFLAGS += -DDATAOFFSET=$(if
> $(dataoffset-y),$(dataoffset-y),0)
>
> bootvars-y = VMLINUX_LOAD_ADDRESS=$(load-y) \
> VMLINUX_ENTRY_ADDRESS=$(entry-y) \
> - PLATFORM=$(platform-y)
> + PLATFORM="$(platform-y)"
> ifdef CONFIG_32BIT
> bootvars-y += ADDR_BITS=32
> endif
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2016-10-25 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 14:12 [PATCH] MIPS: fix build with multiple PLATFORM strings Manuel Lauss
2016-10-25 14:29 ` Paul Burton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1949974.ncqLyGp0zq@np-p-burton \
--to=paul.burton@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@gmail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).