* [PATCH] MIPS: fix build with multiple PLATFORM strings
@ 2016-10-25 14:12 Manuel Lauss
2016-10-25 14:29 ` Paul Burton
0 siblings, 1 reply; 2+ messages in thread
From: Manuel Lauss @ 2016-10-25 14:12 UTC (permalink / raw)
To: Linux-MIPS; +Cc: Paul Burton, Ralf Baechle, Manuel Lauss
Commit cf2a5e0bb (MIPS: Support generating Flattened Image Trees (.itb))
broke my alchemy devboard build, because it uses more than one entry
in the PLATFORM variable:
make -f kernel/linux/scripts/Makefile.build obj=arch/mips/boot/compressed \
VMLINUX_LOAD_ADDRESS=[..] PLATFORM=alchemy/common/ alchemy/devboards/ [..] vmlinuz
make[2]: *** No rule to make target 'alchemy/devboards/'. Stop.
make[1]: *** [arch/mips/Makefile:371: vmlinuz] Error 2
Fix this by wrapping the platform-y expansion in quotes.
Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
---
arch/mips/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index fbf40d3..1a6bac7 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -263,7 +263,7 @@ KBUILD_CPPFLAGS += -DDATAOFFSET=$(if $(dataoffset-y),$(dataoffset-y),0)
bootvars-y = VMLINUX_LOAD_ADDRESS=$(load-y) \
VMLINUX_ENTRY_ADDRESS=$(entry-y) \
- PLATFORM=$(platform-y)
+ PLATFORM="$(platform-y)"
ifdef CONFIG_32BIT
bootvars-y += ADDR_BITS=32
endif
--
2.10.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: fix build with multiple PLATFORM strings
2016-10-25 14:12 [PATCH] MIPS: fix build with multiple PLATFORM strings Manuel Lauss
@ 2016-10-25 14:29 ` Paul Burton
0 siblings, 0 replies; 2+ messages in thread
From: Paul Burton @ 2016-10-25 14:29 UTC (permalink / raw)
To: Manuel Lauss; +Cc: Linux-MIPS, Ralf Baechle
[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]
On Tuesday, 25 October 2016 16:12:05 BST Manuel Lauss wrote:
> Commit cf2a5e0bb (MIPS: Support generating Flattened Image Trees (.itb))
> broke my alchemy devboard build, because it uses more than one entry
> in the PLATFORM variable:
>
> make -f kernel/linux/scripts/Makefile.build obj=arch/mips/boot/compressed \
> VMLINUX_LOAD_ADDRESS=[..] PLATFORM=alchemy/common/
> alchemy/devboards/ [..] vmlinuz make[2]: *** No rule to make target
> 'alchemy/devboards/'. Stop.
> make[1]: *** [arch/mips/Makefile:371: vmlinuz] Error 2
>
> Fix this by wrapping the platform-y expansion in quotes.
Hi Manuel,
This same fix was already submitted 8 days ago:
https://patchwork.linux-mips.org/patch/14405/
Thanks,
Paul
>
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> ---
> arch/mips/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index fbf40d3..1a6bac7 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -263,7 +263,7 @@ KBUILD_CPPFLAGS += -DDATAOFFSET=$(if
> $(dataoffset-y),$(dataoffset-y),0)
>
> bootvars-y = VMLINUX_LOAD_ADDRESS=$(load-y) \
> VMLINUX_ENTRY_ADDRESS=$(entry-y) \
> - PLATFORM=$(platform-y)
> + PLATFORM="$(platform-y)"
> ifdef CONFIG_32BIT
> bootvars-y += ADDR_BITS=32
> endif
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-25 14:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-25 14:12 [PATCH] MIPS: fix build with multiple PLATFORM strings Manuel Lauss
2016-10-25 14:29 ` Paul Burton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).