From: Paul Burton <paul.burton@imgtec.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 09/14] MIPS: Malta: Probe RTC via DT
Date: Tue, 20 Sep 2016 11:34:39 +0100 [thread overview]
Message-ID: <762c9f70-911c-0e48-ef8e-8f8b9e006592@imgtec.com> (raw)
Message-ID: <20160920103439.Va4fjojLdQYg1ba6Jc_fa3Tiv8ZDF6laQPLiHG8SkKw@z> (raw)
In-Reply-To: <55c977d1-21dd-4cf8-d0f9-10d96b452573@cogentembedded.com>
On 20/09/16 11:21, Sergei Shtylyov wrote:
> Hello.
>
> On 9/20/2016 12:21 AM, Paul Burton wrote:
>
>> Add the DT node required to probe the RTC, and remove the platform code
>> that was previously doing it.
>>
>> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
>>
>> ---
>>
>> Changes in v2:
>> - Remove rtc DT node label
>
> Haven't you also renamed the node?
Hi Sergei,
Yes, strictly speaking I could have been more verbose & elaborated in
the changelog on every aspect of the simple change from "rtc:
mc146818@70" to "rtc@70". I didn't, but as it's obviously clear to you
what changed and it has no effect on either the code or the commit that
would end up in git I don't really see the point of your bringing it up.
Thanks,
Paul
>> arch/mips/boot/dts/mti/malta.dts | 15 +++++++++++++++
>> arch/mips/mti-malta/malta-platform.c | 21 ---------------------
>> 2 files changed, 15 insertions(+), 21 deletions(-)
>>
>> diff --git a/arch/mips/boot/dts/mti/malta.dts
>> b/arch/mips/boot/dts/mti/malta.dts
>> index af765af..fecbca8 100644
>> --- a/arch/mips/boot/dts/mti/malta.dts
>> +++ b/arch/mips/boot/dts/mti/malta.dts
>> @@ -49,4 +49,19 @@
>> interrupt-parent = <&gic>;
>> interrupts = <GIC_SHARED 3 IRQ_TYPE_LEVEL_HIGH>;
>> };
>> +
>> + isa {
>> + compatible = "isa";
>> + #address-cells = <2>;
>> + #size-cells = <1>;
>> + ranges = <1 0 0 0x1000>;
>> +
>> + rtc@70 {
>> + compatible = "motorola,mc146818";
>> + reg = <1 0x70 0x8>;
>> +
>> + interrupt-parent = <&i8259>;
>> + interrupts = <8>;
>> + };
>> + };
>> };
> [...]
>
> MBR, Sergei
>
next prev parent reply other threads:[~2016-09-20 10:34 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 21:21 [PATCH v2 00/14] Partial MIPS Malta DT conversion Paul Burton
2016-09-19 21:21 ` Paul Burton
2016-09-19 21:21 ` [PATCH v2 01/14] irqchip: i8259: Add domain before mapping parent irq Paul Burton
2016-09-19 21:21 ` Paul Burton
2016-09-30 14:40 ` Paul Burton
2016-09-30 14:40 ` Paul Burton
2016-09-30 18:41 ` Thomas Gleixner
2016-09-19 21:21 ` [PATCH v2 02/14] irqchip: i8259: Allow platforms to override poll function Paul Burton
2016-09-19 21:21 ` Paul Burton
2016-09-19 21:21 ` [PATCH v2 03/14] irqchip: i8259: Remove unused i8259A_irq_pending Paul Burton
2016-09-19 21:21 ` Paul Burton
2016-09-19 21:21 ` [PATCH v2 04/14] MIPS: Malta: Allow PCI devices DMA to lower 2GB physical Paul Burton
2016-09-19 21:21 ` Paul Burton
2016-09-19 21:21 ` [PATCH v2 05/14] MIPS: Malta: Use all available DDR by default Paul Burton
2016-09-19 21:21 ` Paul Burton
2016-09-19 21:21 ` [PATCH v2 06/14] MIPS: Malta: Probe interrupt controllers via DT Paul Burton
2016-09-19 21:21 ` Paul Burton
2016-09-19 21:21 ` [PATCH v2 07/14] of/platform: Probe "isa" busses by default Paul Burton
2016-09-19 21:21 ` Paul Burton
2016-09-23 12:42 ` Rob Herring
2016-09-19 21:21 ` [PATCH v2 08/14] MIPS: Malta: Remove custom DT match table Paul Burton
2016-09-19 21:21 ` Paul Burton
2016-09-19 21:21 ` [PATCH v2 09/14] MIPS: Malta: Probe RTC via DT Paul Burton
2016-09-19 21:21 ` Paul Burton
2016-09-20 10:21 ` Sergei Shtylyov
2016-09-20 10:34 ` Paul Burton [this message]
2016-09-20 10:34 ` Paul Burton
2016-09-20 10:55 ` Sergei Shtylyov
2016-09-19 21:21 ` [PATCH v2 10/14] MIPS: Malta: Probe pflash " Paul Burton
2016-09-19 21:21 ` Paul Burton
2016-09-19 21:21 ` [PATCH v2 11/14] MIPS: Malta: Use syscon-reboot driver to reboot Paul Burton
2016-09-19 21:21 ` Paul Burton
2016-10-22 9:08 ` Maciej W. Rozycki
2016-10-22 9:08 ` Maciej W. Rozycki
2016-10-24 13:42 ` Paul Burton
2016-10-24 13:42 ` Paul Burton
2016-10-25 10:55 ` Maciej W. Rozycki
2016-10-25 10:55 ` Maciej W. Rozycki
2016-09-19 21:21 ` [PATCH v2 12/14] MIPS: Malta: Remove custom halt implementation Paul Burton
2016-09-19 21:21 ` Paul Burton
2016-09-19 21:21 ` [PATCH v2 13/14] power: reset: Add Intel PIIX4 poweroff driver Paul Burton
2016-09-19 21:21 ` Paul Burton
2016-09-19 23:42 ` Sebastian Reichel
2016-09-28 15:30 ` [PATCH v3 " Paul Burton
2016-09-28 15:30 ` Paul Burton
2016-10-19 2:52 ` Sebastian Reichel
2016-09-19 21:21 ` [PATCH v2 14/14] MIPS: Malta: Use PIIX4 poweroff driver to power down Paul Burton
2016-09-19 21:21 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=762c9f70-911c-0e48-ef8e-8f8b9e006592@imgtec.com \
--to=paul.burton@imgtec.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).