From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
Marc Zyngier <marc.zyngier@arm.com>, <monstr@monstr.eu>,
<ralf@linux-mips.org>, <jason@lakedaemon.net>,
<alistair@popple.id.au>, <mporter@kernel.crashing.org>,
<linux-kernel@vger.kernel.org>, <linux-mips@linux-mips.org>,
<michal.simek@xilinx.com>, <linuxppc-dev@lists.ozlabs.org>,
<mpe@ellerman.id.au>, <paulus@samba.org>,
<benh@kernel.crashing.org>
Subject: Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc
Date: Tue, 25 Oct 2016 07:44:59 -0700 [thread overview]
Message-ID: <20161025144459.GF14444@xsjsorenbubuntu> (raw)
In-Reply-To: <alpine.DEB.2.20.1610251246020.4990@nanos>
On Tue, 2016-10-25 at 12:49:33 +0200, Thomas Gleixner wrote:
> On Tue, 25 Oct 2016, Zubair Lutfullah Kakakhel wrote:
> > On 10/21/2016 10:48 AM, Marc Zyngier wrote:
> > > Shouldn't you return an error if irq is zero?
> > >
> >
> > I'll add the following for the error case
> >
> > pr_err("%s: Parent exists but interrupts property not defined\n" ,
> > __func__);
>
> Please do not use this silly __func__ stuff. It's not giving any value to
> the printout.
>
> Set a proper prefix for your pr_* stuff, so the string is prefixed with
> 'irq-xilinx:' or whatever you think is appropriate. Then the string itself
> is good enough to find from which place this printk comes.
Haven't looked at the real code, but is there probably a way to get a
struct device pointer and use dev_err?
Sören
WARNING: multiple messages have this Message-ID (diff)
From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
Marc Zyngier <marc.zyngier@arm.com>,
monstr@monstr.eu, ralf@linux-mips.org, jason@lakedaemon.net,
alistair@popple.id.au, mporter@kernel.crashing.org,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
michal.simek@xilinx.com, linuxppc-dev@lists.ozlabs.org,
mpe@ellerman.id.au, paulus@samba.org, benh@kernel.crashing.org
Subject: Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc
Date: Tue, 25 Oct 2016 07:44:59 -0700 [thread overview]
Message-ID: <20161025144459.GF14444@xsjsorenbubuntu> (raw)
Message-ID: <20161025144459.XMez0oB6bYJXauXxb10n2EmzT7XdUzUDouYyO6uDuY0@z> (raw)
In-Reply-To: <alpine.DEB.2.20.1610251246020.4990@nanos>
On Tue, 2016-10-25 at 12:49:33 +0200, Thomas Gleixner wrote:
> On Tue, 25 Oct 2016, Zubair Lutfullah Kakakhel wrote:
> > On 10/21/2016 10:48 AM, Marc Zyngier wrote:
> > > Shouldn't you return an error if irq is zero?
> > >
> >
> > I'll add the following for the error case
> >
> > pr_err("%s: Parent exists but interrupts property not defined\n" ,
> > __func__);
>
> Please do not use this silly __func__ stuff. It's not giving any value to
> the printout.
>
> Set a proper prefix for your pr_* stuff, so the string is prefixed with
> 'irq-xilinx:' or whatever you think is appropriate. Then the string itself
> is good enough to find from which place this printk comes.
Haven't looked at the real code, but is there probably a way to get a
struct device pointer and use dev_err?
Sören
next prev parent reply other threads:[~2016-10-25 14:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 16:52 [Patch v5 00/12] microblaze/MIPS/PowerPC: Xilinx intc Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` [Patch v5 01/12] microblaze: irqchip: Move intc driver to irqchip Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` [Patch v5 02/12] irqchip: xilinx: Clean up irqdomain argument and read/write Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` [Patch v5 03/12] irqchip: xilinx: Rename get_irq to xintc_get_irq Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` [Patch v5 04/12] irqchip: xilinx: Add support for parent intc Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` Zubair Lutfullah Kakakhel
2016-10-21 9:48 ` Marc Zyngier
2016-10-25 9:42 ` Zubair Lutfullah Kakakhel
2016-10-25 9:42 ` Zubair Lutfullah Kakakhel
2016-10-25 10:49 ` Thomas Gleixner
2016-10-25 14:44 ` Sören Brinkmann [this message]
2016-10-25 14:44 ` Sören Brinkmann
2016-10-25 14:52 ` Marc Zyngier
2016-10-17 16:52 ` [Patch v5 05/12] irqchip: xilinx: Try to fall back if xlnx,kind-of-intr not provided Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` [Patch v5 06/12] powerpc/virtex: Use generic xilinx irqchip driver Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` Zubair Lutfullah Kakakhel
2016-10-19 11:53 ` Michael Ellerman
2016-10-17 16:52 ` [Patch v5 07/12] MIPS: xilfpga: Use irqchip instead of the legacy way Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` [Patch v5 08/12] MIPS: xilfpga: Use Xilinx Interrupt Controller Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` [Patch v5 09/12] MIPS: xilfpga: Update DT node and specify uart irq Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` [Patch v5 10/12] MIPS: xilfpga: Add DT node for AXI I2C Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` [Patch v5 11/12] MIPS: xilfpga: Add DT node for AXI emaclite Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` [Patch v5 12/12] MIPS: xilfpga: Update defconfig Zubair Lutfullah Kakakhel
2016-10-17 16:52 ` Zubair Lutfullah Kakakhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025144459.GF14444@xsjsorenbubuntu \
--to=soren.brinkmann@xilinx.com \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=alistair@popple.id.au \
--cc=benh@kernel.crashing.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=marc.zyngier@arm.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=mporter@kernel.crashing.org \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).