linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mips: vdso: Explicitly use -fno-asynchronous-unwind-tables
@ 2017-01-26 14:34 Alexander Sverdlin
  2017-01-26 14:34 ` Alexander Sverdlin
  2017-01-26 14:49 ` Maciej W. Rozycki
  0 siblings, 2 replies; 8+ messages in thread
From: Alexander Sverdlin @ 2017-01-26 14:34 UTC (permalink / raw)
  Cc: Alexander Sverdlin, Robert Schiele, Ralf Baechle, James Hogan,
	Maciej W. Rozycki, linux-mips

From: Robert Schiele <rschiele@gmail.com>

Not every toolchain has -fno-asynchronous-unwind-tables per default on MIPS.
This patch specifies the necessary option explicitly for VDSO library build.

This prevents the following build failure:
GENVDSO arch/mips/vdso/vdso-image.c
arch/mips/vdso/genvdso: 'arch/mips/vdso/vdso.so.dbg' contains relocation sections
.../arch/mips/vdso/Makefile:84: recipe for target 'arch/mips/vdso/vdso-image.c' failed

Signed-off-by: Robert Schiele <rschiele@gmail.com>
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <james.hogan@imgtec.com>
Cc: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc: linux-mips@linux-mips.org
---
 arch/mips/vdso/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile
index c3dc12a8b7d9..0512f56685c2 100644
--- a/arch/mips/vdso/Makefile
+++ b/arch/mips/vdso/Makefile
@@ -10,7 +10,7 @@ ccflags-vdso := \
 cflags-vdso := $(ccflags-vdso) \
 	$(filter -W%,$(filter-out -Wa$(comma)%,$(KBUILD_CFLAGS))) \
 	-O2 -g -fPIC -fno-strict-aliasing -fno-common -fno-builtin -G 0 \
-	-DDISABLE_BRANCH_PROFILING \
+	-DDISABLE_BRANCH_PROFILING -fno-asynchronous-unwind-tables \
 	$(call cc-option, -fno-stack-protector)
 aflags-vdso := $(ccflags-vdso) \
 	-D__ASSEMBLY__ -Wa,-gdwarf-2
-- 
2.11.0

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] mips: vdso: Explicitly use -fno-asynchronous-unwind-tables
  2017-01-26 14:34 [PATCH] mips: vdso: Explicitly use -fno-asynchronous-unwind-tables Alexander Sverdlin
@ 2017-01-26 14:34 ` Alexander Sverdlin
  2017-01-26 14:49 ` Maciej W. Rozycki
  1 sibling, 0 replies; 8+ messages in thread
From: Alexander Sverdlin @ 2017-01-26 14:34 UTC (permalink / raw)
  Cc: Alexander Sverdlin, Robert Schiele, Ralf Baechle, James Hogan,
	Maciej W. Rozycki, linux-mips

From: Robert Schiele <rschiele@gmail.com>

Not every toolchain has -fno-asynchronous-unwind-tables per default on MIPS.
This patch specifies the necessary option explicitly for VDSO library build.

This prevents the following build failure:
GENVDSO arch/mips/vdso/vdso-image.c
arch/mips/vdso/genvdso: 'arch/mips/vdso/vdso.so.dbg' contains relocation sections
.../arch/mips/vdso/Makefile:84: recipe for target 'arch/mips/vdso/vdso-image.c' failed

Signed-off-by: Robert Schiele <rschiele@gmail.com>
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <james.hogan@imgtec.com>
Cc: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc: linux-mips@linux-mips.org
---
 arch/mips/vdso/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile
index c3dc12a8b7d9..0512f56685c2 100644
--- a/arch/mips/vdso/Makefile
+++ b/arch/mips/vdso/Makefile
@@ -10,7 +10,7 @@ ccflags-vdso := \
 cflags-vdso := $(ccflags-vdso) \
 	$(filter -W%,$(filter-out -Wa$(comma)%,$(KBUILD_CFLAGS))) \
 	-O2 -g -fPIC -fno-strict-aliasing -fno-common -fno-builtin -G 0 \
-	-DDISABLE_BRANCH_PROFILING \
+	-DDISABLE_BRANCH_PROFILING -fno-asynchronous-unwind-tables \
 	$(call cc-option, -fno-stack-protector)
 aflags-vdso := $(ccflags-vdso) \
 	-D__ASSEMBLY__ -Wa,-gdwarf-2
-- 
2.11.0

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] mips: vdso: Explicitly use -fno-asynchronous-unwind-tables
  2017-01-26 14:34 [PATCH] mips: vdso: Explicitly use -fno-asynchronous-unwind-tables Alexander Sverdlin
  2017-01-26 14:34 ` Alexander Sverdlin
@ 2017-01-26 14:49 ` Maciej W. Rozycki
  2017-01-26 14:49   ` Maciej W. Rozycki
  2017-01-26 15:00   ` [PATCH v2] " Alexander Sverdlin
  1 sibling, 2 replies; 8+ messages in thread
From: Maciej W. Rozycki @ 2017-01-26 14:49 UTC (permalink / raw)
  To: Alexander Sverdlin; +Cc: Robert Schiele, Ralf Baechle, James Hogan, linux-mips

On Thu, 26 Jan 2017, Alexander Sverdlin wrote:

> Not every toolchain has -fno-asynchronous-unwind-tables per default on MIPS.
> This patch specifies the necessary option explicitly for VDSO library build.

 It looks reasonable to me, but you need to wrap it into `$(call 
cc-option,...)' as older compilers didn't have this option.

  Maciej

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] mips: vdso: Explicitly use -fno-asynchronous-unwind-tables
  2017-01-26 14:49 ` Maciej W. Rozycki
@ 2017-01-26 14:49   ` Maciej W. Rozycki
  2017-01-26 15:00   ` [PATCH v2] " Alexander Sverdlin
  1 sibling, 0 replies; 8+ messages in thread
From: Maciej W. Rozycki @ 2017-01-26 14:49 UTC (permalink / raw)
  To: Alexander Sverdlin; +Cc: Robert Schiele, Ralf Baechle, James Hogan, linux-mips

On Thu, 26 Jan 2017, Alexander Sverdlin wrote:

> Not every toolchain has -fno-asynchronous-unwind-tables per default on MIPS.
> This patch specifies the necessary option explicitly for VDSO library build.

 It looks reasonable to me, but you need to wrap it into `$(call 
cc-option,...)' as older compilers didn't have this option.

  Maciej

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2] mips: vdso: Explicitly use -fno-asynchronous-unwind-tables
  2017-01-26 14:49 ` Maciej W. Rozycki
  2017-01-26 14:49   ` Maciej W. Rozycki
@ 2017-01-26 15:00   ` Alexander Sverdlin
  2017-01-26 15:00     ` Alexander Sverdlin
  2017-02-17 13:38     ` James Hogan
  1 sibling, 2 replies; 8+ messages in thread
From: Alexander Sverdlin @ 2017-01-26 15:00 UTC (permalink / raw)
  Cc: Alexander Sverdlin, Robert Schiele, Ralf Baechle, James Hogan,
	Maciej W. Rozycki, linux-mips

From: Robert Schiele <rschiele@gmail.com>

Not every toolchain has -fno-asynchronous-unwind-tables per default on MIPS.
This patch specifies the necessary option explicitly for VDSO library build.

This prevents the following build failure:
GENVDSO arch/mips/vdso/vdso-image.c
arch/mips/vdso/genvdso: 'arch/mips/vdso/vdso.so.dbg' contains relocation sections
.../arch/mips/vdso/Makefile:84: recipe for target 'arch/mips/vdso/vdso-image.c' failed

Signed-off-by: Robert Schiele <rschiele@gmail.com>
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <james.hogan@imgtec.com>
Cc: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc: linux-mips@linux-mips.org
---
 arch/mips/vdso/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile
index c3dc12a8b7d9..c08077e43e73 100644
--- a/arch/mips/vdso/Makefile
+++ b/arch/mips/vdso/Makefile
@@ -11,6 +11,7 @@ cflags-vdso := $(ccflags-vdso) \
 	$(filter -W%,$(filter-out -Wa$(comma)%,$(KBUILD_CFLAGS))) \
 	-O2 -g -fPIC -fno-strict-aliasing -fno-common -fno-builtin -G 0 \
 	-DDISABLE_BRANCH_PROFILING \
+	$(call cc-option, -fno-asynchronous-unwind-tables) \
 	$(call cc-option, -fno-stack-protector)
 aflags-vdso := $(ccflags-vdso) \
 	-D__ASSEMBLY__ -Wa,-gdwarf-2
-- 
2.11.0

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2] mips: vdso: Explicitly use -fno-asynchronous-unwind-tables
  2017-01-26 15:00   ` [PATCH v2] " Alexander Sverdlin
@ 2017-01-26 15:00     ` Alexander Sverdlin
  2017-02-17 13:38     ` James Hogan
  1 sibling, 0 replies; 8+ messages in thread
From: Alexander Sverdlin @ 2017-01-26 15:00 UTC (permalink / raw)
  Cc: Alexander Sverdlin, Robert Schiele, Ralf Baechle, James Hogan,
	Maciej W. Rozycki, linux-mips

From: Robert Schiele <rschiele@gmail.com>

Not every toolchain has -fno-asynchronous-unwind-tables per default on MIPS.
This patch specifies the necessary option explicitly for VDSO library build.

This prevents the following build failure:
GENVDSO arch/mips/vdso/vdso-image.c
arch/mips/vdso/genvdso: 'arch/mips/vdso/vdso.so.dbg' contains relocation sections
.../arch/mips/vdso/Makefile:84: recipe for target 'arch/mips/vdso/vdso-image.c' failed

Signed-off-by: Robert Schiele <rschiele@gmail.com>
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <james.hogan@imgtec.com>
Cc: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc: linux-mips@linux-mips.org
---
 arch/mips/vdso/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile
index c3dc12a8b7d9..c08077e43e73 100644
--- a/arch/mips/vdso/Makefile
+++ b/arch/mips/vdso/Makefile
@@ -11,6 +11,7 @@ cflags-vdso := $(ccflags-vdso) \
 	$(filter -W%,$(filter-out -Wa$(comma)%,$(KBUILD_CFLAGS))) \
 	-O2 -g -fPIC -fno-strict-aliasing -fno-common -fno-builtin -G 0 \
 	-DDISABLE_BRANCH_PROFILING \
+	$(call cc-option, -fno-asynchronous-unwind-tables) \
 	$(call cc-option, -fno-stack-protector)
 aflags-vdso := $(ccflags-vdso) \
 	-D__ASSEMBLY__ -Wa,-gdwarf-2
-- 
2.11.0

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] mips: vdso: Explicitly use -fno-asynchronous-unwind-tables
  2017-01-26 15:00   ` [PATCH v2] " Alexander Sverdlin
  2017-01-26 15:00     ` Alexander Sverdlin
@ 2017-02-17 13:38     ` James Hogan
  2017-02-17 13:38       ` James Hogan
  1 sibling, 1 reply; 8+ messages in thread
From: James Hogan @ 2017-02-17 13:38 UTC (permalink / raw)
  To: Alexander Sverdlin
  Cc: Robert Schiele, Ralf Baechle, Maciej W. Rozycki, linux-mips

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

On Thu, Jan 26, 2017 at 04:00:05PM +0100, Alexander Sverdlin wrote:
> From: Robert Schiele <rschiele@gmail.com>
> 
> Not every toolchain has -fno-asynchronous-unwind-tables per default on MIPS.
> This patch specifies the necessary option explicitly for VDSO library build.
> 
> This prevents the following build failure:
> GENVDSO arch/mips/vdso/vdso-image.c
> arch/mips/vdso/genvdso: 'arch/mips/vdso/vdso.so.dbg' contains relocation sections
> .../arch/mips/vdso/Makefile:84: recipe for target 'arch/mips/vdso/vdso-image.c' failed
> 
> Signed-off-by: Robert Schiele <rschiele@gmail.com>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: James Hogan <james.hogan@imgtec.com>
> Cc: "Maciej W. Rozycki" <macro@imgtec.com>
> Cc: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> Cc: linux-mips@linux-mips.org

Applied

Thanks
James

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] mips: vdso: Explicitly use -fno-asynchronous-unwind-tables
  2017-02-17 13:38     ` James Hogan
@ 2017-02-17 13:38       ` James Hogan
  0 siblings, 0 replies; 8+ messages in thread
From: James Hogan @ 2017-02-17 13:38 UTC (permalink / raw)
  To: Alexander Sverdlin
  Cc: Robert Schiele, Ralf Baechle, Maciej W. Rozycki, linux-mips

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

On Thu, Jan 26, 2017 at 04:00:05PM +0100, Alexander Sverdlin wrote:
> From: Robert Schiele <rschiele@gmail.com>
> 
> Not every toolchain has -fno-asynchronous-unwind-tables per default on MIPS.
> This patch specifies the necessary option explicitly for VDSO library build.
> 
> This prevents the following build failure:
> GENVDSO arch/mips/vdso/vdso-image.c
> arch/mips/vdso/genvdso: 'arch/mips/vdso/vdso.so.dbg' contains relocation sections
> .../arch/mips/vdso/Makefile:84: recipe for target 'arch/mips/vdso/vdso-image.c' failed
> 
> Signed-off-by: Robert Schiele <rschiele@gmail.com>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: James Hogan <james.hogan@imgtec.com>
> Cc: "Maciej W. Rozycki" <macro@imgtec.com>
> Cc: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> Cc: linux-mips@linux-mips.org

Applied

Thanks
James

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-02-17 13:39 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-26 14:34 [PATCH] mips: vdso: Explicitly use -fno-asynchronous-unwind-tables Alexander Sverdlin
2017-01-26 14:34 ` Alexander Sverdlin
2017-01-26 14:49 ` Maciej W. Rozycki
2017-01-26 14:49   ` Maciej W. Rozycki
2017-01-26 15:00   ` [PATCH v2] " Alexander Sverdlin
2017-01-26 15:00     ` Alexander Sverdlin
2017-02-17 13:38     ` James Hogan
2017-02-17 13:38       ` James Hogan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).