* [PATCH] MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch
@ 2017-01-25 17:00 Matt Redfearn
2017-01-25 17:00 ` Matt Redfearn
2017-02-11 21:49 ` James Hogan
0 siblings, 2 replies; 4+ messages in thread
From: Matt Redfearn @ 2017-01-25 17:00 UTC (permalink / raw)
To: Ralf Baechle
Cc: linux-mips, Matt Redfearn, linux-kernel, James Hogan, Paul Burton
Commit dda45f701c9d ("MIPS: Switch to the irq_stack in interrupts")
changed both the normal and vectored interrupt handlers. Unfortunately
the vectored version, "except_vec_vi_handler", was incorrectly modified
to unconditionally jal to plat_irq_dispatch, rather than doing a jalr to
the vectored handler that has been set up. This is ok for many platforms
which set the vectored handler to plat_irq_dispatch anyway, but will
cause problems with platforms that use other handlers.
Fixes: dda45f701c9d ("MIPS: Switch to the irq_stack in interrupts")
Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
---
Ralf, if possible please could you squash this?
---
arch/mips/kernel/genex.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/kernel/genex.S b/arch/mips/kernel/genex.S
index 0a7ba4b2f687..7ec9612cb007 100644
--- a/arch/mips/kernel/genex.S
+++ b/arch/mips/kernel/genex.S
@@ -329,7 +329,7 @@ NESTED(except_vec_vi_handler, 0, sp)
PTR_ADD sp, t0, t1
2:
- jal plat_irq_dispatch
+ jalr v0
/* Restore sp */
move sp, s1
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch
2017-01-25 17:00 [PATCH] MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch Matt Redfearn
@ 2017-01-25 17:00 ` Matt Redfearn
2017-02-11 21:49 ` James Hogan
1 sibling, 0 replies; 4+ messages in thread
From: Matt Redfearn @ 2017-01-25 17:00 UTC (permalink / raw)
To: Ralf Baechle
Cc: linux-mips, Matt Redfearn, linux-kernel, James Hogan, Paul Burton
Commit dda45f701c9d ("MIPS: Switch to the irq_stack in interrupts")
changed both the normal and vectored interrupt handlers. Unfortunately
the vectored version, "except_vec_vi_handler", was incorrectly modified
to unconditionally jal to plat_irq_dispatch, rather than doing a jalr to
the vectored handler that has been set up. This is ok for many platforms
which set the vectored handler to plat_irq_dispatch anyway, but will
cause problems with platforms that use other handlers.
Fixes: dda45f701c9d ("MIPS: Switch to the irq_stack in interrupts")
Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
---
Ralf, if possible please could you squash this?
---
arch/mips/kernel/genex.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/kernel/genex.S b/arch/mips/kernel/genex.S
index 0a7ba4b2f687..7ec9612cb007 100644
--- a/arch/mips/kernel/genex.S
+++ b/arch/mips/kernel/genex.S
@@ -329,7 +329,7 @@ NESTED(except_vec_vi_handler, 0, sp)
PTR_ADD sp, t0, t1
2:
- jal plat_irq_dispatch
+ jalr v0
/* Restore sp */
move sp, s1
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch
2017-01-25 17:00 [PATCH] MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch Matt Redfearn
2017-01-25 17:00 ` Matt Redfearn
@ 2017-02-11 21:49 ` James Hogan
2017-02-11 21:49 ` James Hogan
1 sibling, 1 reply; 4+ messages in thread
From: James Hogan @ 2017-02-11 21:49 UTC (permalink / raw)
To: Matt Redfearn; +Cc: Ralf Baechle, linux-mips, linux-kernel, Paul Burton
[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]
On Wed, Jan 25, 2017 at 05:00:25PM +0000, Matt Redfearn wrote:
> Commit dda45f701c9d ("MIPS: Switch to the irq_stack in interrupts")
> changed both the normal and vectored interrupt handlers. Unfortunately
> the vectored version, "except_vec_vi_handler", was incorrectly modified
> to unconditionally jal to plat_irq_dispatch, rather than doing a jalr to
> the vectored handler that has been set up. This is ok for many platforms
> which set the vectored handler to plat_irq_dispatch anyway, but will
> cause problems with platforms that use other handlers.
>
> Fixes: dda45f701c9d ("MIPS: Switch to the irq_stack in interrupts")
> Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
Applied
Thanks
James
> ---
>
> Ralf, if possible please could you squash this?
>
> ---
> arch/mips/kernel/genex.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/genex.S b/arch/mips/kernel/genex.S
> index 0a7ba4b2f687..7ec9612cb007 100644
> --- a/arch/mips/kernel/genex.S
> +++ b/arch/mips/kernel/genex.S
> @@ -329,7 +329,7 @@ NESTED(except_vec_vi_handler, 0, sp)
> PTR_ADD sp, t0, t1
>
> 2:
> - jal plat_irq_dispatch
> + jalr v0
>
> /* Restore sp */
> move sp, s1
> --
> 2.7.4
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch
2017-02-11 21:49 ` James Hogan
@ 2017-02-11 21:49 ` James Hogan
0 siblings, 0 replies; 4+ messages in thread
From: James Hogan @ 2017-02-11 21:49 UTC (permalink / raw)
To: Matt Redfearn; +Cc: Ralf Baechle, linux-mips, linux-kernel, Paul Burton
[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]
On Wed, Jan 25, 2017 at 05:00:25PM +0000, Matt Redfearn wrote:
> Commit dda45f701c9d ("MIPS: Switch to the irq_stack in interrupts")
> changed both the normal and vectored interrupt handlers. Unfortunately
> the vectored version, "except_vec_vi_handler", was incorrectly modified
> to unconditionally jal to plat_irq_dispatch, rather than doing a jalr to
> the vectored handler that has been set up. This is ok for many platforms
> which set the vectored handler to plat_irq_dispatch anyway, but will
> cause problems with platforms that use other handlers.
>
> Fixes: dda45f701c9d ("MIPS: Switch to the irq_stack in interrupts")
> Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
Applied
Thanks
James
> ---
>
> Ralf, if possible please could you squash this?
>
> ---
> arch/mips/kernel/genex.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/genex.S b/arch/mips/kernel/genex.S
> index 0a7ba4b2f687..7ec9612cb007 100644
> --- a/arch/mips/kernel/genex.S
> +++ b/arch/mips/kernel/genex.S
> @@ -329,7 +329,7 @@ NESTED(except_vec_vi_handler, 0, sp)
> PTR_ADD sp, t0, t1
>
> 2:
> - jal plat_irq_dispatch
> + jalr v0
>
> /* Restore sp */
> move sp, s1
> --
> 2.7.4
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-11 21:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-25 17:00 [PATCH] MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch Matt Redfearn
2017-01-25 17:00 ` Matt Redfearn
2017-02-11 21:49 ` James Hogan
2017-02-11 21:49 ` James Hogan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).