* [PATCH v4 3/3] MIPS: ath79: Fix the USB PHY reset names [not found] <1486324352-15188-1-git-send-email-albeu@free.fr> @ 2017-02-05 19:52 ` Alban 2017-02-08 22:11 ` Rob Herring 2017-02-11 22:01 ` James Hogan 0 siblings, 2 replies; 6+ messages in thread From: Alban @ 2017-02-05 19:52 UTC (permalink / raw) To: linux-kernel Cc: Alban Bedel, Rob Herring, Mark Rutland, Ralf Baechle, Antony Pavlov, devicetree, linux-mips From: Alban Bedel <albeu@free.fr> The binding for the USB PHY went thru before the driver. However the new version of the driver now use the PHY core support for reset, and this expect the reset to be named "phy". So remove the "usb-" prefix from the the reset names. Signed-off-by: Alban Bedel <albeu@free.fr> --- Documentation/devicetree/bindings/phy/phy-ath79-usb.txt | 4 ++-- arch/mips/boot/dts/qca/ar9132.dtsi | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/phy-ath79-usb.txt b/Documentation/devicetree/bindings/phy/phy-ath79-usb.txt index cafe219..c3a29c5 100644 --- a/Documentation/devicetree/bindings/phy/phy-ath79-usb.txt +++ b/Documentation/devicetree/bindings/phy/phy-ath79-usb.txt @@ -3,7 +3,7 @@ Required properties: - compatible: "qca,ar7100-usb-phy" - #phys-cells: should be 0 -- reset-names: "usb-phy"[, "usb-suspend-override"] +- reset-names: "phy"[, "suspend-override"] - resets: references to the reset controllers Example: @@ -11,7 +11,7 @@ Example: usb-phy { compatible = "qca,ar7100-usb-phy"; - reset-names = "usb-phy", "usb-suspend-override"; + reset-names = "phy", "suspend-override"; resets = <&rst 4>, <&rst 3>; #phy-cells = <0>; diff --git a/arch/mips/boot/dts/qca/ar9132.dtsi b/arch/mips/boot/dts/qca/ar9132.dtsi index 302f0a8..808c2bb 100644 --- a/arch/mips/boot/dts/qca/ar9132.dtsi +++ b/arch/mips/boot/dts/qca/ar9132.dtsi @@ -160,7 +160,7 @@ usb_phy: usb-phy { compatible = "qca,ar7100-usb-phy"; - reset-names = "usb-phy", "usb-suspend-override"; + reset-names = "phy", "suspend-override"; resets = <&rst 4>, <&rst 3>; #phy-cells = <0>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4 3/3] MIPS: ath79: Fix the USB PHY reset names 2017-02-05 19:52 ` [PATCH v4 3/3] MIPS: ath79: Fix the USB PHY reset names Alban @ 2017-02-08 22:11 ` Rob Herring 2017-02-11 22:01 ` James Hogan 1 sibling, 0 replies; 6+ messages in thread From: Rob Herring @ 2017-02-08 22:11 UTC (permalink / raw) To: Alban Cc: linux-kernel, Mark Rutland, Ralf Baechle, Antony Pavlov, devicetree, linux-mips On Sun, Feb 05, 2017 at 08:52:32PM +0100, Alban wrote: > From: Alban Bedel <albeu@free.fr> > > The binding for the USB PHY went thru before the driver. However the > new version of the driver now use the PHY core support for reset, and > this expect the reset to be named "phy". So remove the "usb-" prefix > from the the reset names. > > Signed-off-by: Alban Bedel <albeu@free.fr> > --- > Documentation/devicetree/bindings/phy/phy-ath79-usb.txt | 4 ++-- > arch/mips/boot/dts/qca/ar9132.dtsi | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 3/3] MIPS: ath79: Fix the USB PHY reset names 2017-02-05 19:52 ` [PATCH v4 3/3] MIPS: ath79: Fix the USB PHY reset names Alban 2017-02-08 22:11 ` Rob Herring @ 2017-02-11 22:01 ` James Hogan 2017-02-11 22:01 ` James Hogan 2017-02-13 8:30 ` Alban 1 sibling, 2 replies; 6+ messages in thread From: James Hogan @ 2017-02-11 22:01 UTC (permalink / raw) To: Alban Cc: linux-kernel, Rob Herring, Mark Rutland, Ralf Baechle, Antony Pavlov, devicetree, linux-mips [-- Attachment #1: Type: text/plain, Size: 1044 bytes --] Hi Alban, On Sun, Feb 05, 2017 at 08:52:32PM +0100, Alban wrote: > From: Alban Bedel <albeu@free.fr> > > The binding for the USB PHY went thru before the driver. However the > new version of the driver now use the PHY core support for reset, and > this expect the reset to be named "phy". So remove the "usb-" prefix > from the the reset names. > > Signed-off-by: Alban Bedel <albeu@free.fr> > --- > Documentation/devicetree/bindings/phy/phy-ath79-usb.txt | 4 ++-- > arch/mips/boot/dts/qca/ar9132.dtsi | 2 +- <snip> > diff --git a/arch/mips/boot/dts/qca/ar9132.dtsi b/arch/mips/boot/dts/qca/ar9132.dtsi > index 302f0a8..808c2bb 100644 > --- a/arch/mips/boot/dts/qca/ar9132.dtsi > +++ b/arch/mips/boot/dts/qca/ar9132.dtsi > @@ -160,7 +160,7 @@ > usb_phy: usb-phy { > compatible = "qca,ar7100-usb-phy"; > > - reset-names = "usb-phy", "usb-suspend-override"; > + reset-names = "phy", "suspend-override"; Does arch/mips/boot/dts/qca/ar9331.dtsi need updating too? Cheers James [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 3/3] MIPS: ath79: Fix the USB PHY reset names 2017-02-11 22:01 ` James Hogan @ 2017-02-11 22:01 ` James Hogan 2017-02-13 8:30 ` Alban 1 sibling, 0 replies; 6+ messages in thread From: James Hogan @ 2017-02-11 22:01 UTC (permalink / raw) To: Alban Cc: linux-kernel, Rob Herring, Mark Rutland, Ralf Baechle, Antony Pavlov, devicetree, linux-mips [-- Attachment #1: Type: text/plain, Size: 1044 bytes --] Hi Alban, On Sun, Feb 05, 2017 at 08:52:32PM +0100, Alban wrote: > From: Alban Bedel <albeu@free.fr> > > The binding for the USB PHY went thru before the driver. However the > new version of the driver now use the PHY core support for reset, and > this expect the reset to be named "phy". So remove the "usb-" prefix > from the the reset names. > > Signed-off-by: Alban Bedel <albeu@free.fr> > --- > Documentation/devicetree/bindings/phy/phy-ath79-usb.txt | 4 ++-- > arch/mips/boot/dts/qca/ar9132.dtsi | 2 +- <snip> > diff --git a/arch/mips/boot/dts/qca/ar9132.dtsi b/arch/mips/boot/dts/qca/ar9132.dtsi > index 302f0a8..808c2bb 100644 > --- a/arch/mips/boot/dts/qca/ar9132.dtsi > +++ b/arch/mips/boot/dts/qca/ar9132.dtsi > @@ -160,7 +160,7 @@ > usb_phy: usb-phy { > compatible = "qca,ar7100-usb-phy"; > > - reset-names = "usb-phy", "usb-suspend-override"; > + reset-names = "phy", "suspend-override"; Does arch/mips/boot/dts/qca/ar9331.dtsi need updating too? Cheers James [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 3/3] MIPS: ath79: Fix the USB PHY reset names 2017-02-11 22:01 ` James Hogan 2017-02-11 22:01 ` James Hogan @ 2017-02-13 8:30 ` Alban 2017-02-13 8:30 ` Alban 1 sibling, 1 reply; 6+ messages in thread From: Alban @ 2017-02-13 8:30 UTC (permalink / raw) To: James Hogan Cc: Aban Bedel, linux-kernel, Rob Herring, Mark Rutland, Ralf Baechle, Antony Pavlov, devicetree, linux-mips [-- Attachment #1: Type: text/plain, Size: 1265 bytes --] On Sat, 11 Feb 2017 22:01:29 +0000 James Hogan <james.hogan@imgtec.com> wrote: > Hi Alban, > > On Sun, Feb 05, 2017 at 08:52:32PM +0100, Alban wrote: > > From: Alban Bedel <albeu@free.fr> > > > > The binding for the USB PHY went thru before the driver. However the > > new version of the driver now use the PHY core support for reset, and > > this expect the reset to be named "phy". So remove the "usb-" prefix > > from the the reset names. > > > > Signed-off-by: Alban Bedel <albeu@free.fr> > > --- > > Documentation/devicetree/bindings/phy/phy-ath79-usb.txt | 4 ++-- > > arch/mips/boot/dts/qca/ar9132.dtsi | 2 +- > > <snip> > > > diff --git a/arch/mips/boot/dts/qca/ar9132.dtsi b/arch/mips/boot/dts/qca/ar9132.dtsi > > index 302f0a8..808c2bb 100644 > > --- a/arch/mips/boot/dts/qca/ar9132.dtsi > > +++ b/arch/mips/boot/dts/qca/ar9132.dtsi > > @@ -160,7 +160,7 @@ > > usb_phy: usb-phy { > > compatible = "qca,ar7100-usb-phy"; > > > > - reset-names = "usb-phy", "usb-suspend-override"; > > + reset-names = "phy", "suspend-override"; > > Does arch/mips/boot/dts/qca/ar9331.dtsi need updating too? Right, I forgot the AR9331 had been added since then, I'll send a new series. Alban [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 3/3] MIPS: ath79: Fix the USB PHY reset names 2017-02-13 8:30 ` Alban @ 2017-02-13 8:30 ` Alban 0 siblings, 0 replies; 6+ messages in thread From: Alban @ 2017-02-13 8:30 UTC (permalink / raw) To: James Hogan Cc: Aban Bedel, linux-kernel, Rob Herring, Mark Rutland, Ralf Baechle, Antony Pavlov, devicetree, linux-mips [-- Attachment #1: Type: text/plain, Size: 1265 bytes --] On Sat, 11 Feb 2017 22:01:29 +0000 James Hogan <james.hogan@imgtec.com> wrote: > Hi Alban, > > On Sun, Feb 05, 2017 at 08:52:32PM +0100, Alban wrote: > > From: Alban Bedel <albeu@free.fr> > > > > The binding for the USB PHY went thru before the driver. However the > > new version of the driver now use the PHY core support for reset, and > > this expect the reset to be named "phy". So remove the "usb-" prefix > > from the the reset names. > > > > Signed-off-by: Alban Bedel <albeu@free.fr> > > --- > > Documentation/devicetree/bindings/phy/phy-ath79-usb.txt | 4 ++-- > > arch/mips/boot/dts/qca/ar9132.dtsi | 2 +- > > <snip> > > > diff --git a/arch/mips/boot/dts/qca/ar9132.dtsi b/arch/mips/boot/dts/qca/ar9132.dtsi > > index 302f0a8..808c2bb 100644 > > --- a/arch/mips/boot/dts/qca/ar9132.dtsi > > +++ b/arch/mips/boot/dts/qca/ar9132.dtsi > > @@ -160,7 +160,7 @@ > > usb_phy: usb-phy { > > compatible = "qca,ar7100-usb-phy"; > > > > - reset-names = "usb-phy", "usb-suspend-override"; > > + reset-names = "phy", "suspend-override"; > > Does arch/mips/boot/dts/qca/ar9331.dtsi need updating too? Right, I forgot the AR9331 had been added since then, I'll send a new series. Alban [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-13 8:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1486324352-15188-1-git-send-email-albeu@free.fr>
2017-02-05 19:52 ` [PATCH v4 3/3] MIPS: ath79: Fix the USB PHY reset names Alban
2017-02-08 22:11 ` Rob Herring
2017-02-11 22:01 ` James Hogan
2017-02-11 22:01 ` James Hogan
2017-02-13 8:30 ` Alban
2017-02-13 8:30 ` Alban
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).