Re: [PATCH v5 0/8] MIPS: Loongson: Add the Loongson-1A processor support

From: James Hogan <james.hogan@imgtec.com>
To: Binbin Zhou <zhoubb@lemote.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	John Crispin <john@phrozen.org>,
	"Steven J . Hill" <Steven.Hill@imgtec.com>,
	<linux-mips@linux-mips.org>, Fuxin Zhang <zhangfx@lemote.com>,
	Zhangjin Wu <wuzhangjin@gmail.com>,
	Kelvin Cheung <keguang.zhang@gmail.com>,
	Yang Ling <gnaygnil@gmail.com>, Huacai Chen <chenhc@lemote.com>
Subject: Re: [PATCH v5 0/8] MIPS: Loongson: Add the Loongson-1A processor support
Date: Mon, 13 Feb 2017 15:20:17 +0000	[thread overview]
Message-ID: <20170213152017.GK24226@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <1486519069-9364-1-git-send-email-zhoubb@lemote.com>

[-- Attachment #1: Type: text/plain, Size: 4058 bytes --]

Hi,

On Wed, Feb 08, 2017 at 09:57:41AM +0800, Binbin Zhou wrote:
> The Loongson-1A CPU is similar with Loongson-1B/1C, which is a 32-bit SoC.
> 
> It is a cost-effective single chip system based on LS232 processor core,
> and is applicable to fields such as industrial control, and security applications.
> 
> It implements the MIPS32 release 2 instruction set.
> 
> They share the same PRID, so we rewrite them into PRID_REV_LOONGSON1ABC,
> and use their CPU macros to distinguish.
> 
> Changes since v1:
> 
> 1. According commit c908656a7531771ae7642990a7c5f3c7307bd612
>    (MIPS: Loongson: Naming style cleanup and rework) to fix the naming style.
> 
> Changes since v2:
> 
> 1. Remove __irq_set_handler_locked()
> 2. Rebases on top of v4.5-rc5.
> 
> Changes since v3:
> 
> 1. Rename the Loongson-1 series's PRID name
> 2. Rewite Loongson-1A's clk driver
> 2. Rebases on top of v4.10-rc2.
> 
> Changes since v4:
> 
> 1. Fix some commit message error

Please can you look back at review comments from previous revisions, as
most of them seem to be unaddressed & unanswered unless I'm missing
something, and the common clock framework maintainers still aren't Cc'd
on the relevant patches.

Regarding switching to devicetree, note that it can usually be done
incrementally and without any boot ABI changes by embedding the
flattened devicetree(s) in the kernel.

Cheers
James

> 
> Binbin Zhou(8):
>  MIPS: Loongson: Merge PRID macro for Loongson-1A/1B/1C
>  MIPS: Loongson: Expand Loongson-1's register definition
>  MIPS: Loongson: Add basic Loongson-1A CPU support
>  MIPS: Loongson: Add Loongson-1A Kconfig options
>  MIPS: Loongson: Add platform devices for Loongson-1A
>  MIPS: Loongson: Add Loongson-1A board support
>  clk: Loongson: Add Loongson-1A clock support
>  MIPS: Loongson: Add Loongson-1A default config file
> 
> Signed-off-by: Binbin Zhou <zhoubb@lemote.com>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> -- 
>  arch/mips/Kconfig                                 |  12 +++++++++
>  arch/mips/configs/loongson1a_defconfig            | 131 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  arch/mips/include/asm/cpu-type.h                  |   3 ++-
>  arch/mips/include/asm/cpu.h                       |   3 +--
>  arch/mips/include/asm/mach-loongson32/irq.h       |  16 ++++++++----
>  arch/mips/include/asm/mach-loongson32/loongson1.h | 172 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
>  arch/mips/include/asm/mach-loongson32/platform.h  |   2 ++
>  arch/mips/include/asm/mach-loongson32/regs-clk.h  |  30 ++++++++++++++++++++-
>  arch/mips/include/asm/mach-loongson32/regs-mux.h  |  36 ++++++++++++++++++++++++-
>  arch/mips/kernel/cpu-probe.c                      |   6 ++++-
>  arch/mips/loongson32/Kconfig                      |  20 ++++++++++++++
>  arch/mips/loongson32/Makefile                     |   6 +++++
>  arch/mips/loongson32/Platform                     |   1 +
>  arch/mips/loongson32/common/irq.c                 |   2 +-
>  arch/mips/loongson32/common/platform.c            |  83 ++++++++++++++++++++++++++++++++++++++++++++++++----------
>  arch/mips/loongson32/common/setup.c               |   6 +++--
>  arch/mips/loongson32/ls1a/Makefile                |   5 ++++
>  arch/mips/loongson32/ls1a/board.c                 |  31 ++++++++++++++++++++++
>  arch/mips/mm/c-r4k.c                              |  10 +++++++
>  drivers/clk/loongson1/Makefile                    |   1 +
>  drivers/clk/loongson1/clk-loongson1a.c            |  75 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  21 files changed, 593 insertions(+), 58 deletions(-)
>  create mode 100644 arch/mips/configs/loongson1a_defconfig
>  create mode 100644 arch/mips/loongson32/ls1a/Makefile
>  create mode 100644 arch/mips/loongson32/ls1a/board.c
>  create mode 100644 drivers/clk/loongson1/clk-loongson1a.c
> --
> 1.9.0
> 
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]