* [PATCH v2] MIPS: Lantiq: fix missing xbar kernel panic
@ 2017-03-15 22:26 Hauke Mehrtens
2017-03-21 20:35 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Hauke Mehrtens @ 2017-03-15 22:26 UTC (permalink / raw)
To: ralf, james.hogan
Cc: arnd, sergei.shtylyov, john, linux-mips, Hauke Mehrtens, # 4 . 4 . x-
Commit 08b3c894e565 ("MIPS: lantiq: Disable xbar fpi burst mode")
accidentally requested the resources from the pmu address region
instead of the xbar registers region, but the check for the return
value of request_mem_region() was wrong. Commit 98ea51cb0c8c ("MIPS:
Lantiq: Fix another request_mem_region() return code check") fixed the
check of the return value of request_mem_region() which made the kernel
panics.
This patch now makes use of the correct memory region for the cross bar.
Fixes: 08b3c894e565 ("MIPS: lantiq: Disable xbar fpi burst mode")
Cc: <stable@vger.kernel.org> # 4.4.x-
Cc: John Crispin <john@phrozen.org>
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
arch/mips/lantiq/xway/sysctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c
index 3c3aa05891dd..95bec460b651 100644
--- a/arch/mips/lantiq/xway/sysctrl.c
+++ b/arch/mips/lantiq/xway/sysctrl.c
@@ -467,7 +467,7 @@ void __init ltq_soc_init(void)
if (!np_xbar)
panic("Failed to load xbar nodes from devicetree");
- if (of_address_to_resource(np_pmu, 0, &res_xbar))
+ if (of_address_to_resource(np_xbar, 0, &res_xbar))
panic("Failed to get xbar resources");
if (!request_mem_region(res_xbar.start, resource_size(&res_xbar),
res_xbar.name))
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] MIPS: Lantiq: fix missing xbar kernel panic
2017-03-15 22:26 [PATCH v2] MIPS: Lantiq: fix missing xbar kernel panic Hauke Mehrtens
@ 2017-03-21 20:35 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2017-03-21 20:35 UTC (permalink / raw)
To: Hauke Mehrtens
Cc: james.hogan, arnd, sergei.shtylyov, john, linux-mips, # 4 . 4 . x-
Thanks, applied.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-21 20:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-15 22:26 [PATCH v2] MIPS: Lantiq: fix missing xbar kernel panic Hauke Mehrtens
2017-03-21 20:35 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).