From: Matt Redfearn <matt.redfearn@imgtec.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <james.hogan@imgtec.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
Paul Burton <paul.burton@imgtec.com>
Subject: Re: [PATCH 1/2] MIPS: Malta: Fix i8259 irqchip setup
Date: Fri, 31 Mar 2017 13:53:15 +0100 [thread overview]
Message-ID: <52fea079-fb63-6619-8115-2dbfc5ab022b@imgtec.com> (raw)
Message-ID: <20170331125315.07srIlPvFGcXWzOiBc0bBABK5_47sK463bX_ASANACs@z> (raw)
In-Reply-To: <20170331124916.GB26330@linux-mips.org>
Hi Ralf,
On 31/03/17 13:49, Ralf Baechle wrote:
> On Fri, Mar 31, 2017 at 12:05:31PM +0100, Matt Redfearn wrote:
>
>> diff --git a/arch/mips/mti-malta/malta-int.c b/arch/mips/mti-malta/malta-int.c
>> index cb675ec6f283..474b372e0dd9 100644
>> --- a/arch/mips/mti-malta/malta-int.c
>> +++ b/arch/mips/mti-malta/malta-int.c
>> @@ -232,6 +232,19 @@ void __init arch_init_irq(void)
>> {
>> int corehi_irq;
>>
>> +#ifdef CONFIG_I8259
>> + /*
>> + * Preallocate the i8259's expected virq's here. Since irqchip_init()
>> + * will probe the irqchips in hierarchial order, i8259 is probed last.
>> + * If anything allocates a virq before the i8259 is probed, it will
>> + * be given one of the i8259's expected range and consequently setup
>> + * of the i8259 will fail.
>> + */
>> + WARN(irq_alloc_descs(I8259A_IRQ_BASE, I8259A_IRQ_BASE,
>> + 16, numa_node_id()) < 0,
>> + "Cannot reserve i8259 virqs at IRQ%d\n", I8259A_IRQ_BASE);
>> +#endif /* CONFIG_I8259 */
>> +
>> i8259_set_poll(mips_pcibios_iack);
> CONFIG_I8259 is always defined on Malta so the #ifdef is pointless.
>
> Ralf
Ah, true. I was looking at arch/mips/include/asm/mach-generic/irq.h
where I8259A_IRQ_BASE is defined, it's wrapped in that CONFIG so I kept
it here, but you're right of course that Malta always defines it. Would
you like a v2 with that removed?
Thanks,
Matt
next prev parent reply other threads:[~2017-03-31 12:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 11:05 [PATCH 0/2] Fix v4.11 malta_defconfig regressions Matt Redfearn
2017-03-31 11:05 ` Matt Redfearn
2017-03-31 11:05 ` [PATCH 1/2] MIPS: Malta: Fix i8259 irqchip setup Matt Redfearn
2017-03-31 11:05 ` Matt Redfearn
2017-03-31 12:49 ` Ralf Baechle
2017-03-31 12:53 ` Matt Redfearn [this message]
2017-03-31 12:53 ` Matt Redfearn
2017-03-31 11:05 ` [PATCH 2/2] irqchip/mips-gic: Fix Local compare interrupt Matt Redfearn
2017-03-31 11:05 ` Matt Redfearn
2017-03-31 12:46 ` Ralf Baechle
2017-04-10 22:06 ` Paul Burton
2017-04-10 22:06 ` Paul Burton
2017-04-11 8:20 ` Matt Redfearn
2017-04-11 8:20 ` Matt Redfearn
2017-04-11 17:56 ` Paul Burton
2017-04-11 17:56 ` Paul Burton
2017-03-31 12:04 ` [PATCH 0/2] Fix v4.11 malta_defconfig regressions Marc Zyngier
2017-03-31 12:55 ` Matt Redfearn
2017-03-31 12:55 ` Matt Redfearn
2017-03-31 13:28 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52fea079-fb63-6619-8115-2dbfc5ab022b@imgtec.com \
--to=matt.redfearn@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).