From: Paul Burton <paul.burton@mips.com>
To: YunQiang Su <syq@debian.org>
Cc: Paul Burton <pburton@wavecomp.com>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"chehc@lemote.com" <chehc@lemote.com>,
"zhangfx@lemote.com" <zhangfx@lemote.com>,
"wuzhangjin@gmail.com" <wuzhangjin@gmail.com>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
Yunqiang Su <ysu@wavecomp.com>
Subject: Re: [PATCH 1/2] MIPS: Loongson, add sync before target of branch between llsc
Date: Wed, 9 Jan 2019 22:08:46 +0000 [thread overview]
Message-ID: <20190109220844.qk5ufkzjmfwxe5aq@pburton-laptop> (raw)
In-Reply-To: <20190105150037.30261-1-syq@debian.org>
Hi YunQiang,
On Sat, Jan 05, 2019 at 11:00:36PM +0800, YunQiang Su wrote:
> Loongson 2G/2H/3A/3B is quite weak sync'ed. If there is a branch,
> and the target is not in the scope of ll/sc or lld/scd, a sync is
> needed at the postion of target.
OK, so is this the same issue that the second patch in the series is
working around or a different one?
I'm pretty confused at this point about what the actual bugs are in
these various Loongson CPUs. Could someone provide an actual errata
writeup describing the bugs in detail?
What does "in the scope of ll/sc" mean?
What happens if a branch target is not "in the scope of ll/sc"?
How does the sync help?
Are jumps affected, or just branches?
Does this affect userland as well as the kernel?
...and probably more questions depending upon the answers to these ones.
> Loongson doesn't plan to fix this problem in future, so we add the
> sync here for any condition.
So are you saying that future Loongson CPUs will all be buggy too, and
someone there has said that they consider this to be OK..? I really
really hope that is not true.
If hardware people say they're not going to fix their bugs then working
around them is definitely not going to be a priority. It's one thing if
a CPU designer says "oops, my bad, work around this & I'll fix it next
time". It's quite another for them to say they're not interested in
fixing their bugs at all.
Thanks,
Paul
next prev parent reply other threads:[~2019-01-09 22:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 15:00 [PATCH 1/2] MIPS: Loongson, add sync before target of branch between llsc YunQiang Su
2019-01-05 15:00 ` [PATCH 2/2] MIPS: Loongson, workaround ll/sc weak ordering YunQiang Su
2019-01-09 22:08 ` Paul Burton [this message]
2019-01-10 1:59 ` [PATCH 1/2] MIPS: Loongson, add sync before target of branch between llsc Yunqiang Su
2019-01-10 17:35 ` Paul Burton
2019-01-10 18:42 ` YunQiang Su
2019-01-11 12:40 徐成华
2019-01-11 19:00 ` Paul Burton
2019-01-12 8:02 ` 徐成华
2019-01-12 8:19 ` huangpei
2019-01-12 3:25 ` huangpei
2019-01-12 3:41 ` Yunqiang Su
2019-01-12 6:21 ` huangpei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109220844.qk5ufkzjmfwxe5aq@pburton-laptop \
--to=paul.burton@mips.com \
--cc=chehc@lemote.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-mips@vger.kernel.org \
--cc=pburton@wavecomp.com \
--cc=syq@debian.org \
--cc=wuzhangjin@gmail.com \
--cc=ysu@wavecomp.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).