* [PATCH 08/16] mips: prefer __section from compiler_attributes.h
[not found] <20190812215052.71840-1-ndesaulniers@google.com>
@ 2019-08-12 21:50 ` Nick Desaulniers
2019-08-15 9:38 ` Paul Burton
0 siblings, 1 reply; 3+ messages in thread
From: Nick Desaulniers @ 2019-08-12 21:50 UTC (permalink / raw)
To: akpm
Cc: sedat.dilek, jpoimboe, yhs, miguel.ojeda.sandonis,
clang-built-linux, Nick Desaulniers, Ralf Baechle, Paul Burton,
James Hogan, Alexei Starovoitov, Daniel Borkmann,
Martin KaFai Lau, Song Liu, linux-mips, linux-kernel, netdev,
bpf
Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
arch/mips/include/asm/cache.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/include/asm/cache.h b/arch/mips/include/asm/cache.h
index 8b14c2706aa5..af2d943580ee 100644
--- a/arch/mips/include/asm/cache.h
+++ b/arch/mips/include/asm/cache.h
@@ -14,6 +14,6 @@
#define L1_CACHE_SHIFT CONFIG_MIPS_L1_CACHE_SHIFT
#define L1_CACHE_BYTES (1 << L1_CACHE_SHIFT)
-#define __read_mostly __attribute__((__section__(".data..read_mostly")))
+#define __read_mostly __section(.data..read_mostly)
#endif /* _ASM_CACHE_H */
--
2.23.0.rc1.153.gdeed80330f-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 08/16] mips: prefer __section from compiler_attributes.h
2019-08-12 21:50 ` [PATCH 08/16] mips: prefer __section from compiler_attributes.h Nick Desaulniers
@ 2019-08-15 9:38 ` Paul Burton
2019-08-27 0:19 ` Nick Desaulniers
0 siblings, 1 reply; 3+ messages in thread
From: Paul Burton @ 2019-08-15 9:38 UTC (permalink / raw)
To: Nick Desaulniers
Cc: akpm, sedat.dilek, jpoimboe, yhs, miguel.ojeda.sandonis,
clang-built-linux, Ralf Baechle, James Hogan, Alexei Starovoitov,
Daniel Borkmann, Martin KaFai Lau, Song Liu, linux-mips,
linux-kernel, netdev, bpf
Hi Nick,
On Mon, Aug 12, 2019 at 02:50:41PM -0700, Nick Desaulniers wrote:
> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
It would be good to add a commit message, even if it's just a line
repeating the subject & preferably describing the motivation.
> ---
> arch/mips/include/asm/cache.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/cache.h b/arch/mips/include/asm/cache.h
> index 8b14c2706aa5..af2d943580ee 100644
> --- a/arch/mips/include/asm/cache.h
> +++ b/arch/mips/include/asm/cache.h
> @@ -14,6 +14,6 @@
> #define L1_CACHE_SHIFT CONFIG_MIPS_L1_CACHE_SHIFT
> #define L1_CACHE_BYTES (1 << L1_CACHE_SHIFT)
>
> -#define __read_mostly __attribute__((__section__(".data..read_mostly")))
> +#define __read_mostly __section(.data..read_mostly)
>
> #endif /* _ASM_CACHE_H */
> --
> 2.23.0.rc1.153.gdeed80330f-goog
I'm not copied on the rest of the series so I'm not sure what your
expectations are about where this should be applied. Let me know if
you'd prefer this to go through mips-next, otherwise:
Acked-by: Paul Burton <paul.burton@mips.com>
Thanks,
Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 08/16] mips: prefer __section from compiler_attributes.h
2019-08-15 9:38 ` Paul Burton
@ 2019-08-27 0:19 ` Nick Desaulniers
0 siblings, 0 replies; 3+ messages in thread
From: Nick Desaulniers @ 2019-08-27 0:19 UTC (permalink / raw)
To: Paul Burton
Cc: akpm, sedat.dilek, jpoimboe, yhs, miguel.ojeda.sandonis,
clang-built-linux, Ralf Baechle, James Hogan, Alexei Starovoitov,
Daniel Borkmann, Martin KaFai Lau, Song Liu, linux-mips,
linux-kernel, netdev, bpf
On Thu, Aug 15, 2019 at 2:38 AM Paul Burton <paul.burton@mips.com> wrote:
>
> Hi Nick,
>
> On Mon, Aug 12, 2019 at 02:50:41PM -0700, Nick Desaulniers wrote:
> > Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> > Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com>
> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
>
> It would be good to add a commit message, even if it's just a line
> repeating the subject & preferably describing the motivation.
>
> > ---
> > arch/mips/include/asm/cache.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/mips/include/asm/cache.h b/arch/mips/include/asm/cache.h
> > index 8b14c2706aa5..af2d943580ee 100644
> > --- a/arch/mips/include/asm/cache.h
> > +++ b/arch/mips/include/asm/cache.h
> > @@ -14,6 +14,6 @@
> > #define L1_CACHE_SHIFT CONFIG_MIPS_L1_CACHE_SHIFT
> > #define L1_CACHE_BYTES (1 << L1_CACHE_SHIFT)
> >
> > -#define __read_mostly __attribute__((__section__(".data..read_mostly")))
> > +#define __read_mostly __section(.data..read_mostly)
> >
> > #endif /* _ASM_CACHE_H */
> > --
> > 2.23.0.rc1.153.gdeed80330f-goog
>
> I'm not copied on the rest of the series so I'm not sure what your
> expectations are about where this should be applied. Let me know if
> you'd prefer this to go through mips-next, otherwise:
>
> Acked-by: Paul Burton <paul.burton@mips.com>
Thanks Paul, going to send this up via Miguel's tree, if you don't
mind. Updating my series now. (Will probably avoid running
get_maintainer.pl on every patch...too hard to cc everyone on the
whole series).
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-27 0:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190812215052.71840-1-ndesaulniers@google.com>
2019-08-12 21:50 ` [PATCH 08/16] mips: prefer __section from compiler_attributes.h Nick Desaulniers
2019-08-15 9:38 ` Paul Burton
2019-08-27 0:19 ` Nick Desaulniers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).