From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>, Chris Snook <chris.snook@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
James Hogan <jhogan@kernel.org>, Jay Cliburn <jcliburn@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Paul Burton <paul.burton@mips.com>,
Ralf Baechle <ralf@linux-mips.org>,
Rob Herring <robh+dt@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH v3 1/5] net: ag71xx: port to phylink
Date: Mon, 21 Oct 2019 23:21:22 +0100 [thread overview]
Message-ID: <20191021222122.GM25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20191021053811.19818-2-o.rempel@pengutronix.de>
On Mon, Oct 21, 2019 at 07:38:07AM +0200, Oleksij Rempel wrote:
> +static void ag71xx_mac_validate(struct phylink_config *config,
> + unsigned long *supported,
> + struct phylink_link_state *state)
> {
> - struct ag71xx *ag = netdev_priv(ndev);
> + __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, };
> +
> + if (state->interface != PHY_INTERFACE_MODE_NA &&
> + state->interface != PHY_INTERFACE_MODE_GMII &&
> + state->interface != PHY_INTERFACE_MODE_MII) {
> + bitmap_zero(supported, __ETHTOOL_LINK_MODE_MASK_NBITS);
> + return;
> + }
> +
> + phylink_set(mask, MII);
> +
> + /* flow control is not supported */
> +
> + phylink_set(mask, 10baseT_Half);
> + phylink_set(mask, 10baseT_Full);
> + phylink_set(mask, 100baseT_Half);
> + phylink_set(mask, 100baseT_Full);
>
> - ag71xx_link_adjust(ag, true);
> + if (state->interface == PHY_INTERFACE_MODE_NA &&
> + state->interface == PHY_INTERFACE_MODE_GMII) {
This is always false.
Apart from that, from just reading the patch I have no further concerns.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-10-21 22:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 5:38 [PATCH v3 0/5] add dsa switch support for ar9331 Oleksij Rempel
2019-10-21 5:38 ` [PATCH v3 1/5] net: ag71xx: port to phylink Oleksij Rempel
2019-10-21 22:21 ` Russell King - ARM Linux admin [this message]
2019-10-22 5:12 ` Oleksij Rempel
2019-10-21 5:38 ` [PATCH v3 2/5] dt-bindings: net: dsa: qca,ar9331 switch documentation Oleksij Rempel
2019-10-21 5:38 ` [PATCH v3 3/5] MIPS: ath79: ar9331: add ar9331-switch node Oleksij Rempel
2019-10-21 5:38 ` [PATCH v3 4/5] net: dsa: add support for Atheros AR9331 TAG format Oleksij Rempel
2019-10-21 15:49 ` Andrew Lunn
2019-10-21 18:36 ` Oleksij Rempel
2019-10-21 5:38 ` [PATCH v3 5/5] net: dsa: add support for Atheros AR9331 build-in switch Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021222122.GM25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jcliburn@gmail.com \
--cc=jhogan@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).