linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] MIPS: Loongson2ef: drop pointless static qualifier in loongson_suspend_enter()
@ 2019-12-04  1:08 Mao Wenan
  2020-01-09 18:52 ` Paul Burton
  0 siblings, 1 reply; 2+ messages in thread
From: Mao Wenan @ 2019-12-04  1:08 UTC (permalink / raw)
  To: jiaxun.yang, ralf, paulburton, jhogan, gregkh, tglx, maowenan
  Cc: linux-mips, linux-kernel, kernel-janitors, Hulk Robot

There is no need to have the 'T *v' variable static
since new value always be assigned before use it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 arch/mips/loongson2ef/common/pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/loongson2ef/common/pm.c b/arch/mips/loongson2ef/common/pm.c
index 11f4cfd581fb..bcb7ae9777cf 100644
--- a/arch/mips/loongson2ef/common/pm.c
+++ b/arch/mips/loongson2ef/common/pm.c
@@ -91,7 +91,7 @@ static inline void stop_perf_counters(void)
 
 static void loongson_suspend_enter(void)
 {
-	static unsigned int cached_cpu_freq;
+	unsigned int cached_cpu_freq;
 
 	/* setup wakeup events via enabling the IRQs */
 	setup_wakeup_events();
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] MIPS: Loongson2ef: drop pointless static qualifier in  loongson_suspend_enter()
  2019-12-04  1:08 [PATCH -next] MIPS: Loongson2ef: drop pointless static qualifier in loongson_suspend_enter() Mao Wenan
@ 2020-01-09 18:52 ` Paul Burton
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Burton @ 2020-01-09 18:52 UTC (permalink / raw)
  To: Mao Wenan
  Cc: jiaxun.yang, ralf, paulburton, jhogan, gregkh, tglx, maowenan,
	linux-mips, linux-kernel, kernel-janitors, Hulk Robot,
	linux-mips

Hello,

Mao Wenan wrote:
> There is no need to have the 'T *v' variable static
> since new value always be assigned before use it.

Applied to mips-next.

> commit 11d06df7b9f2
> https://git.kernel.org/mips/c/11d06df7b9f2
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> Signed-off-by: Paul Burton <paulburton@kernel.org>

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paulburton@kernel.org to report it. ]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-01-09 18:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04  1:08 [PATCH -next] MIPS: Loongson2ef: drop pointless static qualifier in loongson_suspend_enter() Mao Wenan
2020-01-09 18:52 ` Paul Burton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).