From: Andrew Lunn <andrew@lunn.ch>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Paul Cercueil" <paul@crapouillou.net>,
"Paul Boddie" <paul@boddie.org.uk>,
"Alex Smith" <alex.smith@imgtec.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ralf Baechle" <ralf@linux-mips.org>,
"Paul Burton" <paulburton@kernel.org>,
"James Hogan" <jhogan@kernel.org>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David S. Miller" <davem@davemloft.net>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Andi Kleen" <ak@linux.intel.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Petr Štetiar" <ynezz@true.cz>,
"Richard Fontana" <rfontana@redhat.com>,
"Allison Randal" <allison@lohutok.net>,
"Stephen Boyd" <swboyd@chromium.org>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-i2c@vger.kernel.org, netdev@vger.kernel.org,
linux-gpio@vger.kernel.org, letux-kernel@openphoenux.org,
kernel@pyra-handheld.com
Subject: Re: [PATCH 03/14] net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter
Date: Tue, 11 Feb 2020 23:25:06 +0100 [thread overview]
Message-ID: <20200211222506.GP19213@lunn.ch> (raw)
In-Reply-To: <4e11dd4183da55012198824ca7b8933b1eb57e4a.1581457290.git.hns@goldelico.com>
On Tue, Feb 11, 2020 at 10:41:20PM +0100, H. Nikolaus Schaller wrote:
> This is needed to give the MIPS Ingenic CI20 board a stable MAC address
> which can be optionally provided by vendor U-Boot.
>
> For get_mac_addr() we use an adapted copy of from ksz884x.c which
> has very similar functionality.
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Hi Nikolaus
Please split these patches by subsystem. So this one patch needs to go
via netdev.
> +static char *mac_addr = ":";
> +module_param(mac_addr, charp, 0);
> +MODULE_PARM_DESC(mac_addr, "MAC address");
Module parameters are not liked.
Can it be passed via device tree? The driver already has code to get
it out of the device tree.
Andrew
next prev parent reply other threads:[~2020-02-11 22:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 21:41 [PATCH 00/14] MIPS: Fixes and improvements for CI20 board (JZ4780) H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 01/14] i2c: jz4780: suppress txabrt reports for i2cdetect H. Nikolaus Schaller
2020-02-12 9:46 ` i2c: jz4780: silence log flood on txabrt Wolfram Sang
2020-02-12 14:46 ` H. Nikolaus Schaller
2020-02-12 14:53 ` Wolfram Sang
2020-02-12 14:59 ` H. Nikolaus Schaller
2020-02-13 9:10 ` Wolfram Sang
2020-02-11 21:41 ` [PATCH 02/14] drm: ingenic-drm: add MODULE_DEVICE_TABLE H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 03/14] net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter H. Nikolaus Schaller
2020-02-11 22:25 ` Andrew Lunn [this message]
2020-02-12 8:07 ` Geert Uytterhoeven
2020-02-12 8:13 ` H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 04/14] MIPS: DTS: jz4780: fix #includes for irq.h and gpio.h H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 05/14] MIPS: CI20: defconfig: configure for supporting modules H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 06/14] MIPS: CI20: defconfig: compile leds-gpio driver into the kernel and configure for LED triggers H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 07/14] MIPS: DTS: CI20: fix PMU definitions for ACT8600 H. Nikolaus Schaller
2020-02-11 21:48 ` [Letux-kernel] " Andreas Kemnade
2020-02-11 21:41 ` [PATCH 08/14] MIPS: CI20: defconfig: configure CONFIG_REGULATOR_ACT8865 for PMU H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 09/14] MIPS: DTS: CI20: give eth0_power a defined voltage H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 10/14] MIPS: DTS: CI20: add DT node for IR sensor H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 11/14] MIPS: CI20: defconfig: compile gpio-ir driver H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 12/14] MIPS: DTS: CI20: add DT node for SW1 as Enter button H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 13/14] MIPS: CI20: defconfig: configure for CONFIG_KEYBOARD_GPIO=m H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 14/14] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211222506.GP19213@lunn.ch \
--to=andrew@lunn.ch \
--cc=airlied@linux.ie \
--cc=ak@linux.intel.com \
--cc=alex.smith@imgtec.com \
--cc=allison@lohutok.net \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=hns@goldelico.com \
--cc=jhogan@kernel.org \
--cc=kernel@pyra-handheld.com \
--cc=krzk@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=paul@boddie.org.uk \
--cc=paul@crapouillou.net \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=rfontana@redhat.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).