* [PATCH] MIPS: SNI: Fix SCSI interrupt
@ 2020-09-02 21:32 Thomas Bogendoerfer
2020-09-03 8:21 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Bogendoerfer @ 2020-09-02 21:32 UTC (permalink / raw)
To: afzal mohammed, linux-mips, linux-kernel
On RM400(a20r) machines ISA and SCSI interrupts share the same interrupt
line. Commit 49e6e07e3c80 ("MIPS: pass non-NULL dev_id on shared
request_irq()") accidently dropped the IRQF_SHARED bit, which breaks
registering SCSI interrupt. Put back IRQF_SHARED and add dev_id for
ISA interrupt.
Fixes: 49e6e07e3c80 ("MIPS: pass non-NULL dev_id on shared request_irq()")
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
arch/mips/sni/a20r.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/sni/a20r.c b/arch/mips/sni/a20r.c
index 0ecffb65fd6d..b09dc844985a 100644
--- a/arch/mips/sni/a20r.c
+++ b/arch/mips/sni/a20r.c
@@ -222,8 +222,8 @@ void __init sni_a20r_irq_init(void)
irq_set_chip_and_handler(i, &a20r_irq_type, handle_level_irq);
sni_hwint = a20r_hwint;
change_c0_status(ST0_IM, IE_IRQ0);
- if (request_irq(SNI_A20R_IRQ_BASE + 3, sni_isa_irq_handler, 0, "ISA",
- NULL))
+ if (request_irq(SNI_A20R_IRQ_BASE + 3, sni_isa_irq_handler,
+ IRQF_SHARED, "ISA", sni_isa_irq_handler))
pr_err("Failed to register ISA interrupt\n");
}
--
2.16.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: SNI: Fix SCSI interrupt
2020-09-02 21:32 [PATCH] MIPS: SNI: Fix SCSI interrupt Thomas Bogendoerfer
@ 2020-09-03 8:21 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2020-09-03 8:21 UTC (permalink / raw)
To: afzal mohammed, linux-mips, linux-kernel
On Wed, Sep 02, 2020 at 11:32:14PM +0200, Thomas Bogendoerfer wrote:
> On RM400(a20r) machines ISA and SCSI interrupts share the same interrupt
> line. Commit 49e6e07e3c80 ("MIPS: pass non-NULL dev_id on shared
> request_irq()") accidently dropped the IRQF_SHARED bit, which breaks
> registering SCSI interrupt. Put back IRQF_SHARED and add dev_id for
> ISA interrupt.
>
> Fixes: 49e6e07e3c80 ("MIPS: pass non-NULL dev_id on shared request_irq()")
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> ---
> arch/mips/sni/a20r.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
applied ti mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-03 8:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 21:32 [PATCH] MIPS: SNI: Fix SCSI interrupt Thomas Bogendoerfer
2020-09-03 8:21 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).