From: Paul Cercueil <paul@crapouillou.net>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: "Maciej W . Rozycki" <macro@linux-mips.org>,
Paul Burton <paulburton@kernel.org>,
Zhou Yanjie <zhouyanjie@wanyeetech.com>,
od@zcrc.me, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, Paul Cercueil <paul@crapouillou.net>
Subject: [PATCH v3 07/15] MIPS: generic: Init command line with fw_init_cmdline()
Date: Sun, 6 Sep 2020 21:29:27 +0200 [thread overview]
Message-ID: <20200906192935.107086-8-paul@crapouillou.net> (raw)
In-Reply-To: <20200906192935.107086-1-paul@crapouillou.net>
The function bootcmdline_init() in arch/mips/kernel/setup.c will
populate the boot_command_line string using the parameters hardcoded in
the kernel, and those provided in the devicetree file. Then, it would
append the content of the arcs_cmdline variable, which is filled by the
board's plat_mem_setup() function.
The plat_mem_setup() function for the generic MIPS board would just copy
the current boot_command_line to arcs_cmdline, which is nonsense for two
reasons:
- the result will be appended to the boot_command_line anyway, so all it
does is duplicate every single parameter on the command line;
- the code did not perform at all what it's supposed to, which is to
retrieve the parameters passed by the bootloader.
Fix this by calling fw_init_cmdline() in plat_mem_setup(), which will
properly initialize arcs_cmdline to the parameters passed by the
bootloader.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
Notes:
v2: New patch
v3: No change
arch/mips/generic/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/generic/init.c b/arch/mips/generic/init.c
index 805d0135a9f4..029f47ea390c 100644
--- a/arch/mips/generic/init.c
+++ b/arch/mips/generic/init.c
@@ -106,7 +106,7 @@ void __init plat_mem_setup(void)
if (mach && mach->fixup_fdt)
fdt = mach->fixup_fdt(fdt, mach_match_data);
- strlcpy(arcs_cmdline, boot_command_line, COMMAND_LINE_SIZE);
+ fw_init_cmdline();
__dt_setup_arch((void *)fdt);
}
--
2.28.0
next prev parent reply other threads:[~2020-09-06 19:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 19:29 [PATCH v3 00/15] MIPS: Convert Ingenic to a generic board v3 Paul Cercueil
2020-09-06 19:29 ` [PATCH v3 01/15] MIPS: configs: lb60: Fix defconfig not selecting correct board Paul Cercueil
2020-09-06 19:29 ` [PATCH v3 02/15] MIPS: cpu-probe: Set Ingenic's writecombine to _CACHE_CACHABLE_WA Paul Cercueil
2020-09-06 19:29 ` [PATCH v3 03/15] MIPS: cpu-probe: Mark XBurst CPU as having vtagged caches Paul Cercueil
2020-09-06 19:29 ` [PATCH v3 04/15] MIPS: cpu-probe: ingenic: Fix broken BUG_ON Paul Cercueil
2020-09-06 19:29 ` [PATCH v3 05/15] MIPS: Kconfig: add MIPS_GENERIC_KERNEL symbol Paul Cercueil
2020-09-06 19:29 ` [PATCH v3 06/15] MIPS: generic: Allow boards to set system type Paul Cercueil
2020-09-08 16:27 ` Philippe Mathieu-Daudé
2020-09-06 19:29 ` Paul Cercueil [this message]
2020-09-06 19:29 ` [PATCH v3 08/15] MIPS: generic: Support booting with built-in or appended DTB Paul Cercueil
2020-09-07 7:54 ` Sergei Shtylyov
2020-09-07 12:39 ` Paul Cercueil
2020-09-06 19:29 ` [PATCH v3 09/15] MIPS: generic: Add support for zboot Paul Cercueil
2020-09-06 19:29 ` [PATCH v3 10/15] MIPS: generic: Increase NR_IRQS to 256 Paul Cercueil
2020-09-07 19:53 ` Thomas Bogendoerfer
2020-09-06 19:29 ` [PATCH v3 11/15] MIPS: generic: Add support for Ingenic SoCs Paul Cercueil
2020-10-12 14:33 ` Guenter Roeck
2020-10-12 14:59 ` Paul Cercueil
2020-10-12 18:26 ` Guenter Roeck
2020-10-12 19:27 ` [PATCH] MIPS: ingenic: Remove CPU_SUPPORTS_HUGEPAGES Paul Cercueil
2020-10-13 9:31 ` Thomas Bogendoerfer
2020-09-06 19:29 ` [PATCH v3 12/15] MIPS: jz4740: Drop all obsolete files Paul Cercueil
2020-09-06 19:29 ` [PATCH v3 13/15] MIPS: jz4740: Rename jz4740 folders to ingenic Paul Cercueil
2020-09-06 19:29 ` [PATCH v3 14/15] MIPS: configs: Regenerate configs of Ingenic boards Paul Cercueil
2020-09-06 19:29 ` [PATCH v3 15/15] MAINTAINERS: Update paths to Ingenic platform code Paul Cercueil
2020-09-18 14:40 ` [PATCH v3 00/15] MIPS: Convert Ingenic to a generic board v3 Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200906192935.107086-8-paul@crapouillou.net \
--to=paul@crapouillou.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=od@zcrc.me \
--cc=paulburton@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).