linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mips: disable branch profiling in boot/decompress.o
@ 2021-07-04 23:02 Randy Dunlap
  2021-07-05 15:08 ` Thomas Bogendoerfer
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2021-07-04 23:02 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, kernel test robot, Thomas Bogendoerfer, linux-mips,
	Kyungsik Lee

Use DISABLE_BRANCH_PROFILING for arch/mips/boot/compressed/decompress.o
to prevent linkage errors.

mips64-linux-ld: arch/mips/boot/compressed/decompress.o: in function `LZ4_decompress_fast_extDict':
decompress.c:(.text+0x8c): undefined reference to `ftrace_likely_update'
mips64-linux-ld: decompress.c:(.text+0xf4): undefined reference to `ftrace_likely_update'
mips64-linux-ld: decompress.c:(.text+0x200): undefined reference to `ftrace_likely_update'
mips64-linux-ld: decompress.c:(.text+0x230): undefined reference to `ftrace_likely_update'
mips64-linux-ld: decompress.c:(.text+0x320): undefined reference to `ftrace_likely_update'
mips64-linux-ld: arch/mips/boot/compressed/decompress.o:decompress.c:(.text+0x3f4): more undefined references to `ftrace_likely_update' follow

Fixes: e76e1fdfa8f8 ("lib: add support for LZ4-compressed kernel")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org
Cc: Kyungsik Lee <kyungsik.lee@lge.com>
---
 arch/mips/boot/compressed/decompress.c |    2 ++
 1 file changed, 2 insertions(+)

--- linux-next-20210701.orig/arch/mips/boot/compressed/decompress.c
+++ linux-next-20210701/arch/mips/boot/compressed/decompress.c
@@ -7,6 +7,8 @@
  * Author: Wu Zhangjin <wuzhangjin@gmail.com>
  */
 
+#define DISABLE_BRANCH_PROFILING
+
 #include <linux/types.h>
 #include <linux/kernel.h>
 #include <linux/string.h>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mips: disable branch profiling in boot/decompress.o
  2021-07-04 23:02 [PATCH] mips: disable branch profiling in boot/decompress.o Randy Dunlap
@ 2021-07-05 15:08 ` Thomas Bogendoerfer
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2021-07-05 15:08 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: linux-kernel, kernel test robot, linux-mips, Kyungsik Lee

On Sun, Jul 04, 2021 at 04:02:11PM -0700, Randy Dunlap wrote:
> Use DISABLE_BRANCH_PROFILING for arch/mips/boot/compressed/decompress.o
> to prevent linkage errors.
> 
> mips64-linux-ld: arch/mips/boot/compressed/decompress.o: in function `LZ4_decompress_fast_extDict':
> decompress.c:(.text+0x8c): undefined reference to `ftrace_likely_update'
> mips64-linux-ld: decompress.c:(.text+0xf4): undefined reference to `ftrace_likely_update'
> mips64-linux-ld: decompress.c:(.text+0x200): undefined reference to `ftrace_likely_update'
> mips64-linux-ld: decompress.c:(.text+0x230): undefined reference to `ftrace_likely_update'
> mips64-linux-ld: decompress.c:(.text+0x320): undefined reference to `ftrace_likely_update'
> mips64-linux-ld: arch/mips/boot/compressed/decompress.o:decompress.c:(.text+0x3f4): more undefined references to `ftrace_likely_update' follow
> 
> Fixes: e76e1fdfa8f8 ("lib: add support for LZ4-compressed kernel")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
> Cc: Kyungsik Lee <kyungsik.lee@lge.com>
> ---
>  arch/mips/boot/compressed/decompress.c |    2 ++
>  1 file changed, 2 insertions(+)

applied to mips-next (for second pull request).

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-05 15:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-04 23:02 [PATCH] mips: disable branch profiling in boot/decompress.o Randy Dunlap
2021-07-05 15:08 ` Thomas Bogendoerfer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).