* [PATCH] mips: bcm63xx: add support for clk_set_parent()
@ 2021-12-29 0:05 Randy Dunlap
2021-12-29 16:40 ` Jonathan Cameron
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Randy Dunlap @ 2021-12-29 0:05 UTC (permalink / raw)
To: linux-kernel, linux-mips, Thomas Bogendoerfer
Cc: Paul Cercueil, Jonathan Cameron, Lars-Peter Clausen,
Florian Fainelli, Andy Shevchenko, Russell King,
bcm-kernel-feedback-list, alsa-devel, Randy Dunlap
The MIPS BMC63XX subarch does not provide/support clk_set_parent().
This causes build errors in a few drivers, so add a simple implementation
of that function so that callers of it will build without errors.
Fixes these build errors:
ERROR: modpost: "clk_set_parent" [sound/soc/jz4740/snd-soc-jz4740-i2s.ko] undefined!
ERROR: modpost: "clk_set_parent" [sound/soc/atmel/snd-soc-atmel-i2s.ko] undefined!
Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs." )
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
arch/mips/bcm63xx/clk.c | 6 ++++++
1 file changed, 6 insertions(+)
--- linux-next-20211224.orig/arch/mips/bcm63xx/clk.c
+++ linux-next-20211224/arch/mips/bcm63xx/clk.c
@@ -387,6 +387,12 @@ struct clk *clk_get_parent(struct clk *c
}
EXPORT_SYMBOL(clk_get_parent);
+int clk_set_parent(struct clk *clk, struct clk *parent)
+{
+ return 0;
+}
+EXPORT_SYMBOL(clk_set_parent);
+
unsigned long clk_get_rate(struct clk *clk)
{
if (!clk)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mips: bcm63xx: add support for clk_set_parent()
2021-12-29 0:05 [PATCH] mips: bcm63xx: add support for clk_set_parent() Randy Dunlap
@ 2021-12-29 16:40 ` Jonathan Cameron
2021-12-29 16:41 ` Florian Fainelli
2022-01-03 19:51 ` Thomas Bogendoerfer
2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2021-12-29 16:40 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, linux-mips, Thomas Bogendoerfer, Paul Cercueil,
Lars-Peter Clausen, Florian Fainelli, Andy Shevchenko,
Russell King, bcm-kernel-feedback-list, alsa-devel
On Tue, 28 Dec 2021 16:05:53 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:
> The MIPS BMC63XX subarch does not provide/support clk_set_parent().
> This causes build errors in a few drivers, so add a simple implementation
> of that function so that callers of it will build without errors.
>
> Fixes these build errors:
>
> ERROR: modpost: "clk_set_parent" [sound/soc/jz4740/snd-soc-jz4740-i2s.ko] undefined!
> ERROR: modpost: "clk_set_parent" [sound/soc/atmel/snd-soc-atmel-i2s.ko] undefined!
>
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs." )
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Hi Randy,
As with the other one, perhaps consider a WARN_ON()
With or without that FWIW
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> arch/mips/bcm63xx/clk.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> --- linux-next-20211224.orig/arch/mips/bcm63xx/clk.c
> +++ linux-next-20211224/arch/mips/bcm63xx/clk.c
> @@ -387,6 +387,12 @@ struct clk *clk_get_parent(struct clk *c
> }
> EXPORT_SYMBOL(clk_get_parent);
>
> +int clk_set_parent(struct clk *clk, struct clk *parent)
> +{
> + return 0;
> +}
> +EXPORT_SYMBOL(clk_set_parent);
> +
> unsigned long clk_get_rate(struct clk *clk)
> {
> if (!clk)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mips: bcm63xx: add support for clk_set_parent()
2021-12-29 0:05 [PATCH] mips: bcm63xx: add support for clk_set_parent() Randy Dunlap
2021-12-29 16:40 ` Jonathan Cameron
@ 2021-12-29 16:41 ` Florian Fainelli
2022-01-03 19:51 ` Thomas Bogendoerfer
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2021-12-29 16:41 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel, linux-mips, Thomas Bogendoerfer
Cc: Paul Cercueil, Jonathan Cameron, Lars-Peter Clausen,
Andy Shevchenko, Russell King, bcm-kernel-feedback-list,
alsa-devel
On 12/28/2021 4:05 PM, Randy Dunlap wrote:
> The MIPS BMC63XX subarch does not provide/support clk_set_parent().
> This causes build errors in a few drivers, so add a simple implementation
> of that function so that callers of it will build without errors.
>
> Fixes these build errors:
>
> ERROR: modpost: "clk_set_parent" [sound/soc/jz4740/snd-soc-jz4740-i2s.ko] undefined!
> ERROR: modpost: "clk_set_parent" [sound/soc/atmel/snd-soc-atmel-i2s.ko] undefined!
>
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs." )
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks!
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mips: bcm63xx: add support for clk_set_parent()
2021-12-29 0:05 [PATCH] mips: bcm63xx: add support for clk_set_parent() Randy Dunlap
2021-12-29 16:40 ` Jonathan Cameron
2021-12-29 16:41 ` Florian Fainelli
@ 2022-01-03 19:51 ` Thomas Bogendoerfer
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2022-01-03 19:51 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, linux-mips, Paul Cercueil, Jonathan Cameron,
Lars-Peter Clausen, Florian Fainelli, Andy Shevchenko,
Russell King, bcm-kernel-feedback-list, alsa-devel
On Tue, Dec 28, 2021 at 04:05:53PM -0800, Randy Dunlap wrote:
> The MIPS BMC63XX subarch does not provide/support clk_set_parent().
> This causes build errors in a few drivers, so add a simple implementation
> of that function so that callers of it will build without errors.
>
> Fixes these build errors:
>
> ERROR: modpost: "clk_set_parent" [sound/soc/jz4740/snd-soc-jz4740-i2s.ko] undefined!
> ERROR: modpost: "clk_set_parent" [sound/soc/atmel/snd-soc-atmel-i2s.ko] undefined!
>
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs." )
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> arch/mips/bcm63xx/clk.c | 6 ++++++
> 1 file changed, 6 insertions(+)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-03 19:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-29 0:05 [PATCH] mips: bcm63xx: add support for clk_set_parent() Randy Dunlap
2021-12-29 16:40 ` Jonathan Cameron
2021-12-29 16:41 ` Florian Fainelli
2022-01-03 19:51 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).